hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27297 "HBASE-26810 Add dynamic configuration support for system…

Open taklwu opened this issue 3 years ago • 4 comments

… coprocessors" to branch-2.5

please see the original commit 87555093cf4e2fbf14484eb9a9c147010820aefc as a reference

taklwu avatar Aug 12 '22 05:08 taklwu

as mentioned in HBASE-26882, I was thinking if we should wait till a new release of 2.5.x comes, but I will give a try to merge it back to branch-2.5 (master, branch-2 and branch-2.4 also have this change) before the next RC vote.

taklwu avatar Aug 12 '22 05:08 taklwu

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+1 :green_heart: mvninstall 2m 20s branch-2.5 passed
+1 :green_heart: compile 2m 13s branch-2.5 passed
+1 :green_heart: checkstyle 0m 29s branch-2.5 passed
+1 :green_heart: spotless 0m 43s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 13s branch-2.5 passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 14s the patch passed
+1 :green_heart: compile 2m 10s the patch passed
+1 :green_heart: javac 2m 10s the patch passed
+1 :green_heart: checkstyle 0m 28s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 15m 25s Patch does not cause any errors with Hadoop 2.10.1 or 3.1.2 3.2.2 3.3.1.
+1 :green_heart: spotless 0m 40s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 17s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
35m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4697/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4697
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 3d5ec177ac73 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / ad6770652f
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 65 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4697/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 12 '22 05:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 52s Docker mode activated.
-0 :warning: yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 :green_heart: mvninstall 2m 20s branch-2.5 passed
+1 :green_heart: compile 0m 34s branch-2.5 passed
+1 :green_heart: shadedjars 3m 49s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 22s branch-2.5 passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 1s the patch passed
+1 :green_heart: compile 0m 35s the patch passed
+1 :green_heart: javac 0m 35s the patch passed
+1 :green_heart: shadedjars 3m 49s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 20s the patch passed
_ Other Tests _
+1 :green_heart: unit 177m 40s hbase-server in the patch passed.
193m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4697/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4697
Optional Tests javac javadoc unit shadedjars compile
uname Linux 80b171326ebc 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / ad6770652f
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4697/1/testReport/
Max. process+thread count 2337 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4697/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 12 '22 08:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 24s Docker mode activated.
-0 :warning: yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 :green_heart: mvninstall 3m 53s branch-2.5 passed
+1 :green_heart: compile 1m 8s branch-2.5 passed
+1 :green_heart: shadedjars 4m 49s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 28s branch-2.5 passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 32s the patch passed
+1 :green_heart: compile 0m 54s the patch passed
+1 :green_heart: javac 0m 54s the patch passed
+1 :green_heart: shadedjars 5m 6s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 33s the patch passed
_ Other Tests _
+1 :green_heart: unit 248m 32s hbase-server in the patch passed.
273m 40s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4697/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4697
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3535c84d9609 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / ad6770652f
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4697/1/testReport/
Max. process+thread count 2818 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4697/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 12 '22 09:08 Apache-HBase

Let's just reopen HBASE-26882 and use that issue to land this change? It is a bit weird that HBASE-26882 has been committed to branch-2 and branch-2.4 but no branch-2.5?

Apache9 avatar Aug 22 '22 01:08 Apache9

Yes, go ahead and push to branch-2.5 on HBASE-26882.

ndimiduk avatar Aug 22 '22 10:08 ndimiduk

thanks Nick and Duo.

taklwu avatar Aug 23 '22 20:08 taklwu