hbase icon indicating copy to clipboard operation
hbase copied to clipboard
verified publisher icon apache

HBASE-27249 Remove invalid peer RegionServer crash

Open SiCheng-Zheng opened this issue 3 years ago • 10 comments

SiCheng-Zheng avatar Jul 27 '22 14:07 SiCheng-Zheng

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 7s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 46s master passed
+1 :green_heart: compile 2m 51s master passed
+1 :green_heart: checkstyle 0m 35s master passed
+1 :green_heart: spotless 0m 50s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 34s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 10s the patch passed
+1 :green_heart: compile 3m 0s the patch passed
+1 :green_heart: javac 3m 0s the patch passed
+1 :green_heart: checkstyle 0m 36s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 18m 0s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 :green_heart: spotless 1m 12s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 2m 24s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
47m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4660
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 22a899afd3d7 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3eeab8c56
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 69 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 27 '22 15:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 4m 5s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 29s master passed
+1 :green_heart: compile 0m 34s master passed
+1 :green_heart: shadedjars 3m 56s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 23s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 12s the patch passed
+1 :green_heart: compile 0m 33s the patch passed
+1 :green_heart: javac 0m 33s the patch passed
+1 :green_heart: shadedjars 3m 55s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 21s the patch passed
_ Other Tests _
-1 :x: unit 207m 2s hbase-server in the patch failed.
227m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4660
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0a6819f9c305 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3eeab8c56
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/testReport/
Max. process+thread count 2419 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 27 '22 18:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 11s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 15s master passed
+1 :green_heart: compile 1m 1s master passed
+1 :green_heart: shadedjars 4m 46s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 40s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 41s the patch passed
+1 :green_heart: compile 1m 3s the patch passed
+1 :green_heart: javac 1m 3s the patch passed
+1 :green_heart: shadedjars 4m 31s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 28s the patch passed
_ Other Tests _
-1 :x: unit 206m 34s hbase-server in the patch failed.
231m 9s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4660
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9cadb0093874 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3eeab8c56
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/testReport/
Max. process+thread count 2691 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 27 '22 18:07 Apache-HBase

What is the problem we actually fix here? Mind explaining a bit why we need to add the new condition?

Apache9 avatar Aug 14 '22 15:08 Apache9

What is the problem we actually fix here? Mind explaining a bit why we need to add the new condition? When add peer cluster, but peer cluster zookeeper shuotdown or invalid. remove peer cause source cluster RS abort

SiCheng-Zheng avatar Aug 16 '22 12:08 SiCheng-Zheng

I mean why adding the check can fix the problem?

Apache9 avatar Aug 16 '22 12:08 Apache9

I mean why adding the check can fix the problem? From the HBASE-27249 log, Remove invalid peer causes InterruptedException. Thread.currentThread().isInterrupted() does not meet expectations, add !this.sourceRunning to make it meet expectations

SiCheng-Zheng avatar Aug 23 '22 10:08 SiCheng-Zheng

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 37s master passed
+1 :green_heart: compile 2m 17s master passed
+1 :green_heart: checkstyle 0m 31s master passed
+1 :green_heart: spotless 0m 40s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 15s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 11s the patch passed
+1 :green_heart: compile 2m 14s the patch passed
+1 :green_heart: javac 2m 14s the patch passed
+1 :green_heart: checkstyle 0m 28s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 8m 6s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 :green_heart: spotless 0m 36s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 19s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 7s The patch does not generate ASF License warnings.
28m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4660
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 94635d0fb65c 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 950ad8dd3e
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 72 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '22 10:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 17s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 7s master passed
+1 :green_heart: compile 1m 3s master passed
+1 :green_heart: shadedjars 4m 50s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 31s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 46s the patch passed
+1 :green_heart: compile 0m 43s the patch passed
+1 :green_heart: javac 0m 43s the patch passed
+1 :green_heart: shadedjars 3m 51s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 23s the patch passed
_ Other Tests _
-1 :x: unit 230m 53s hbase-server in the patch failed.
251m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4660
Optional Tests javac javadoc unit shadedjars compile
uname Linux edf670195031 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 950ad8dd3e
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/testReport/
Max. process+thread count 2575 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '22 14:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 40s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 47s master passed
+1 :green_heart: compile 0m 43s master passed
+1 :green_heart: shadedjars 3m 55s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 24s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 32s the patch passed
+1 :green_heart: compile 0m 41s the patch passed
+1 :green_heart: javac 0m 41s the patch passed
+1 :green_heart: shadedjars 4m 4s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 27s the patch passed
_ Other Tests _
+1 :green_heart: unit 271m 27s hbase-server in the patch passed.
290m 29s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4660
Optional Tests javac javadoc unit shadedjars compile
uname Linux 469ad9003bb7 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 950ad8dd3e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/testReport/
Max. process+thread count 2515 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4660/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '22 15:08 Apache-HBase