hbase icon indicating copy to clipboard operation
hbase copied to clipboard

[HBASE-27116]fix the ruby issue which cause disable all table failure

Open alexdongli0829 opened this issue 3 years ago • 6 comments

https://issues.apache.org/jira/browse/HBASE-27116

alexdongli0829 avatar Jun 14 '22 01:06 alexdongli0829

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 24s master passed
+1 :green_heart: spotless 0m 42s branch has no errors when running spotless:check.
-0 :warning: patch 0m 48s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 4s the patch passed
-0 :warning: rubocop 0m 12s The patch generated 1 new + 31 unchanged - 0 fixed = 32 total (was 31)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: spotless 0m 39s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
8m 7s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4531
JIRA Issue HBASE-27116
Optional Tests dupname asflicense javac spotless rubocop
uname Linux 80933bca80be 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f526609331
Default Java AdoptOpenJDK-1.8.0_282-b08
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 14 '22 01:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 36s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 54s master passed
+1 :green_heart: javadoc 0m 13s master passed
-0 :warning: patch 3m 15s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 41s the patch passed
+1 :green_heart: javadoc 0m 10s the patch passed
_ Other Tests _
+1 :green_heart: unit 6m 49s hbase-shell in the patch passed.
15m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4531
JIRA Issue HBASE-27116
Optional Tests javac javadoc unit
uname Linux 98445ed1dd3f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f526609331
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/testReport/
Max. process+thread count 1523 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 14 '22 01:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 53s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 32s master passed
+1 :green_heart: javadoc 0m 21s master passed
-0 :warning: patch 4m 1s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 5s the patch passed
+1 :green_heart: javadoc 0m 11s the patch passed
_ Other Tests _
+1 :green_heart: unit 8m 3s hbase-shell in the patch passed.
17m 8s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4531
JIRA Issue HBASE-27116
Optional Tests javac javadoc unit
uname Linux ed40905be62d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f526609331
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/testReport/
Max. process+thread count 1536 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4531/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 14 '22 01:06 Apache-HBase

@busbey Mind taking a look at this one?

Apache9 avatar Jul 27 '22 06:07 Apache9

Hi @alexdongli0829, I've tested your patch on the master branch, and in this combination it throws NoSuchMetrod error. Can you check?

echo "list\nexit 1" > error_exit.rb

./bin/hbase shell -n < error_exit.rb ; echo $?
TABLE
peter
1 row(s)
Took 0.4349 seconds
peter
ERROR NoMethodError: undefined method `irb' for nil:NilClass
1

petersomogyi avatar Aug 26 '22 13:08 petersomogyi

It is also failing with clean exit.

echo "list\nexit" > clean_exit.rb

/bin/hbase shell -n < clean_exit.rb ; echo $?
TABLE
peter
1 row(s)
Took 0.4534 seconds
peter
ERROR NoMethodError: undefined method `irb' for nil:NilClass
1

petersomogyi avatar Aug 26 '22 13:08 petersomogyi