hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27086 Fix graceful_stop cannot take previous balancer status by incompatibility of hbase shell prompt

Open bitterfox opened this issue 2 years ago • 4 comments

https://issues.apache.org/jira/browse/HBASE-27086

There're 2 issues

  • hbase shell shows prompt always even through echo "balance_switch false" | hbase shell -n (noninteractive mode or piped)
  • irb now shows an empty line at end of the output, so tail -1 retrieve the empty line. need tail -2 | head -1 to retrieve true/false for previous balancer status

Need this patch in branch-2.4, 2.5, 2, 3, master

bitterfox avatar Jun 06 '22 06:06 bitterfox

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: shelldocs 0m 1s Shelldocs was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 1m 14s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 53s master passed
+1 :green_heart: spotless 0m 56s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 53s the patch passed
+1 :green_heart: rubocop 0m 9s There were no new rubocop issues.
+1 :green_heart: shellcheck 0m 1s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: spotless 0m 51s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 20s The patch does not generate ASF License warnings.
11m 49s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4490
Optional Tests dupname asflicense spotless shellcheck shelldocs javac rubocop
uname Linux d8ba6d329f3d 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 12a9e6e5ec
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 71 (vs. ulimit of 30000)
modules C: hbase-shell . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 06 '22 07:06 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 39s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 31s master passed
+1 :green_heart: javadoc 2m 5s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 28s the patch passed
+1 :green_heart: javadoc 1m 57s the patch passed
_ Other Tests _
-1 :x: unit 213m 43s root in the patch failed.
227m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4490
Optional Tests javac javadoc unit
uname Linux 51658f48cfff 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 12a9e6e5ec
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/testReport/
Max. process+thread count 2441 (vs. ulimit of 30000)
modules C: hbase-shell . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 06 '22 10:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: shelldocs 0m 0s Shelldocs was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 1m 15s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 4s master passed
+1 :green_heart: spotless 0m 37s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 9s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 36s the patch passed
-0 :warning: rubocop 0m 9s The patch generated 1 new + 8 unchanged - 0 fixed = 9 total (was 8)
+1 :green_heart: shellcheck 0m 1s There were no new shellcheck issues.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: spotless 0m 38s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 17s The patch does not generate ASF License warnings.
10m 35s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4490
Optional Tests dupname asflicense spotless shellcheck shelldocs javac rubocop
uname Linux 6043e5b5e80b 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9342653691
Default Java AdoptOpenJDK-1.8.0_282-b08
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 61 (vs. ulimit of 30000)
modules C: hbase-shell . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 09 '22 10:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 10s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 16s master passed
+1 :green_heart: javadoc 2m 9s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 2s the patch passed
+1 :green_heart: javadoc 2m 8s the patch passed
_ Other Tests _
+1 :green_heart: unit 251m 18s root in the patch passed.
265m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4490
Optional Tests javac javadoc unit
uname Linux 2d5d3a07d442 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9342653691
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/testReport/
Max. process+thread count 3799 (vs. ulimit of 30000)
modules C: hbase-shell . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4490/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 09 '22 14:06 Apache-HBase