hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-25955 Setting NAMESPACES when adding a replication peer still requires scope definition at CF level

Open wchevreuil opened this issue 3 years ago • 7 comments

As mentioned on the jira description, setting either NAMESPACES or TABLECFs when calling add_peer still doesn't suffice to allow entries for the related namespaces/tables to be replicated, if those don't have replication scope set to '1' in the CF descriptor. The above happens because ChainWalEntryFilter, currently, applies conjunction (AND) to all its chained filters. Following suggestions from @anoopsjohn on an previous PR, rather than changing this behaviour completely, this PR introduces an option to define between conjunction (AND) or disjunction (OR) logic for ChainWalEntryFilter, keeping current logic (AND) the default one, if not specified.

wchevreuil avatar Jan 21 '22 21:01 wchevreuil

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for branch
+1 :green_heart: mvninstall 5m 16s master passed
+1 :green_heart: compile 7m 46s master passed
+1 :green_heart: checkstyle 2m 14s master passed
+1 :green_heart: spotbugs 9m 8s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 54s the patch passed
+1 :green_heart: compile 7m 52s the patch passed
+1 :green_heart: cc 7m 52s the patch passed
+1 :green_heart: javac 7m 52s the patch passed
+1 :green_heart: checkstyle 2m 34s the patch passed
-0 :warning: rubocop 0m 19s The patch generated 19 new + 481 unchanged - 5 fixed = 500 total (was 486)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 26m 4s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 :green_heart: hbaseprotoc 3m 2s the patch passed
+1 :green_heart: spotbugs 9m 11s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 49s The patch does not generate ASF License warnings.
91m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4052
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 12cba21a2a95 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d2b8a033d
Default Java AdoptOpenJDK-1.8.0_282-b08
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 21 '22 23:01 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 25s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for branch
+1 :green_heart: mvninstall 4m 8s master passed
+1 :green_heart: compile 2m 42s master passed
+1 :green_heart: shadedjars 8m 23s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 33s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 50s the patch passed
+1 :green_heart: compile 2m 40s the patch passed
+1 :green_heart: javac 2m 40s the patch passed
+1 :green_heart: shadedjars 8m 22s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 29s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 46s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 20s hbase-client in the patch passed.
+1 :green_heart: unit 147m 32s hbase-server in the patch passed.
+1 :green_heart: unit 7m 24s hbase-shell in the patch passed.
194m 14s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4052
Optional Tests javac javadoc unit shadedjars compile
uname Linux e87ae0bc4181 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d2b8a033d
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/testReport/
Max. process+thread count 4967 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 22 '22 00:01 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 16s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 5m 1s master passed
+1 :green_heart: compile 3m 28s master passed
+1 :green_heart: shadedjars 8m 50s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 46s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 18s Maven dependency ordering for patch
+1 :green_heart: mvninstall 4m 50s the patch passed
+1 :green_heart: compile 3m 23s the patch passed
+1 :green_heart: javac 3m 23s the patch passed
+1 :green_heart: shadedjars 8m 44s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 44s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 7s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 32s hbase-client in the patch passed.
-1 :x: unit 148m 55s hbase-server in the patch failed.
+1 :green_heart: unit 7m 34s hbase-shell in the patch passed.
201m 50s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4052
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4f4dd5837a0b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1d2b8a033d
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/testReport/
Max. process+thread count 4098 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 22 '22 01:01 Apache-HBase

TestFromClientSide5 pass locally for me. Flakey?

wchevreuil avatar Jan 24 '22 12:01 wchevreuil

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 9s master passed
+1 :green_heart: compile 5m 30s master passed
+1 :green_heart: checkstyle 1m 25s master passed
+1 :green_heart: spotbugs 7m 4s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 56s the patch passed
+1 :green_heart: compile 5m 2s the patch passed
+1 :green_heart: cc 5m 2s the patch passed
+1 :green_heart: javac 5m 2s the patch passed
+1 :green_heart: checkstyle 1m 26s the patch passed
-0 :warning: rubocop 0m 12s The patch generated 19 new + 481 unchanged - 5 fixed = 500 total (was 486)
+1 :green_heart: whitespace 0m 1s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 14m 39s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 :green_heart: hbaseprotoc 1m 39s the patch passed
+1 :green_heart: spotbugs 6m 23s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 29s The patch does not generate ASF License warnings.
57m 22s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4052
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux ffe0c23e1c73 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f78f232b28
Default Java AdoptOpenJDK-1.8.0_282-b08
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 60 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 21 '22 15:03 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 39s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for branch
+1 :green_heart: mvninstall 2m 19s master passed
+1 :green_heart: compile 1m 24s master passed
+1 :green_heart: shadedjars 3m 47s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 50s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 6s the patch passed
+1 :green_heart: compile 1m 24s the patch passed
+1 :green_heart: javac 1m 24s the patch passed
+1 :green_heart: shadedjars 3m 48s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 48s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 24s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 1m 9s hbase-client in the patch passed.
-1 :x: unit 170m 25s hbase-server in the patch failed.
-1 :x: unit 7m 31s hbase-shell in the patch failed.
198m 40s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4052
Optional Tests javac javadoc unit shadedjars compile
uname Linux f4a5b98635de 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f78f232b28
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/testReport/
Max. process+thread count 2782 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 21 '22 18:03 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 49s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for branch
+1 :green_heart: mvninstall 3m 54s master passed
+1 :green_heart: compile 2m 35s master passed
+1 :green_heart: shadedjars 4m 58s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 26s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
+1 :green_heart: mvninstall 3m 42s the patch passed
+1 :green_heart: compile 2m 25s the patch passed
+1 :green_heart: javac 2m 25s the patch passed
+1 :green_heart: shadedjars 5m 4s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 25s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 55s hbase-protocol-shaded in the patch passed.
+1 :green_heart: unit 2m 10s hbase-client in the patch passed.
+1 :green_heart: unit 233m 57s hbase-server in the patch passed.
-1 :x: unit 9m 4s hbase-shell in the patch failed.
276m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/4052
Optional Tests javac javadoc unit shadedjars compile
uname Linux f97c52aff568 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f78f232b28
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/testReport/
Max. process+thread count 2703 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 21 '22 19:03 Apache-HBase