hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-26565 Make StatisticThread alternative in LruBC

Open YutSean opened this issue 3 years ago • 15 comments

https://issues.apache.org/jira/browse/HBASE-26565

YutSean avatar Dec 13 '21 02:12 YutSean

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 1s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 32s master passed
+1 :green_heart: compile 3m 24s master passed
+1 :green_heart: checkstyle 1m 11s master passed
+1 :green_heart: spotbugs 2m 14s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 15s the patch passed
+1 :green_heart: compile 3m 24s the patch passed
+1 :green_heart: javac 3m 24s the patch passed
+1 :green_heart: checkstyle 1m 10s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 21m 38s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 :green_heart: spotbugs 2m 21s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
54m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 784df1d8da33 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8bca21b47d
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 13 '21 03:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 53s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 33s master passed
+1 :green_heart: compile 1m 4s master passed
+1 :green_heart: shadedjars 9m 6s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 38s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 17s the patch passed
+1 :green_heart: compile 1m 3s the patch passed
+1 :green_heart: javac 1m 3s the patch passed
+1 :green_heart: shadedjars 9m 11s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 36s the patch passed
_ Other Tests _
+1 :green_heart: unit 211m 24s hbase-server in the patch passed.
244m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3bf2de56b265 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8bca21b47d
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/1/testReport/
Max. process+thread count 3780 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 13 '21 06:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 49s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 6m 18s master passed
+1 :green_heart: compile 1m 29s master passed
+1 :green_heart: shadedjars 10m 58s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 1m 0s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 6m 14s the patch passed
+1 :green_heart: compile 1m 44s the patch passed
+1 :green_heart: javac 1m 44s the patch passed
+1 :green_heart: shadedjars 10m 15s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 51s the patch passed
_ Other Tests _
+1 :green_heart: unit 226m 57s hbase-server in the patch passed.
270m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests javac javadoc unit shadedjars compile
uname Linux c415b9d7f8f8 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8bca21b47d
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/1/testReport/
Max. process+thread count 2864 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 13 '21 06:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 14s master passed
+1 :green_heart: compile 3m 25s master passed
+1 :green_heart: checkstyle 1m 9s master passed
+1 :green_heart: spotbugs 2m 10s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 12s the patch passed
+1 :green_heart: compile 3m 22s the patch passed
+1 :green_heart: javac 3m 22s the patch passed
+1 :green_heart: checkstyle 1m 9s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 21m 28s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 :green_heart: spotbugs 2m 26s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 12s The patch does not generate ASF License warnings.
53m 25s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 0f1951731cbc 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8bca21b47d
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 13 '21 07:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 55s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 33s master passed
+1 :green_heart: compile 1m 4s master passed
+1 :green_heart: shadedjars 8m 59s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 39s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 18s the patch passed
+1 :green_heart: compile 1m 3s the patch passed
+1 :green_heart: javac 1m 3s the patch passed
+1 :green_heart: shadedjars 9m 3s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 37s the patch passed
_ Other Tests _
+1 :green_heart: unit 212m 2s hbase-server in the patch passed.
244m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests javac javadoc unit shadedjars compile
uname Linux b31ec77ba0fa 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8bca21b47d
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/2/testReport/
Max. process+thread count 3659 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 13 '21 10:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 32s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 31s master passed
+1 :green_heart: compile 1m 26s master passed
+1 :green_heart: shadedjars 9m 58s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 45s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 5m 27s the patch passed
+1 :green_heart: compile 1m 23s the patch passed
+1 :green_heart: javac 1m 23s the patch passed
+1 :green_heart: shadedjars 9m 15s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 44s the patch passed
_ Other Tests _
+1 :green_heart: unit 211m 14s hbase-server in the patch passed.
249m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests javac javadoc unit shadedjars compile
uname Linux d90eec4279f3 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8bca21b47d
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/2/testReport/
Max. process+thread count 2762 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 13 '21 10:12 Apache-HBase

Can we define common config that is applicable to any LRU we use?

virajjasani avatar Dec 18 '21 18:12 virajjasani

Spread this config to all the LRU. Found that it is really hard to spread a common feature among all LRUs. There are plenty of redundant code in them. Maybe we could also reconstruct them in another ticket. But this time, I just make FirstLevelBC as an abstract class to try my best to avoid redundant coding.......

YutSean avatar Dec 19 '21 02:12 YutSean

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 5s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 22s master passed
+1 :green_heart: compile 3m 21s master passed
+1 :green_heart: checkstyle 1m 10s master passed
+1 :green_heart: spotbugs 2m 12s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 17s the patch passed
+1 :green_heart: compile 3m 21s the patch passed
+1 :green_heart: javac 3m 21s the patch passed
-0 :warning: checkstyle 1m 10s hbase-server: The patch generated 1 new + 12 unchanged - 2 fixed = 13 total (was 14)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 21m 31s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 :x: spotbugs 2m 26s hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 :green_heart: asflicense 0m 13s The patch does not generate ASF License warnings.
53m 44s
Reason Tests
FindBugs module:hbase-server
org.apache.hadoop.hbase.io.hfile.FirstLevelBlockCache.STAT_THREAD_ENABLE_DEFAULT isn't final but should be At FirstLevelBlockCache.java:be At FirstLevelBlockCache.java:[line 35]
org.apache.hadoop.hbase.io.hfile.FirstLevelBlockCache.STAT_THREAD_ENABLE_KEY isn't final but should be At FirstLevelBlockCache.java:be At FirstLevelBlockCache.java:[line 34]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 55cf46783863 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d399799c29
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 19 '21 03:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 55s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 21s master passed
+1 :green_heart: compile 1m 5s master passed
+1 :green_heart: shadedjars 9m 4s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 38s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 16s the patch passed
+1 :green_heart: compile 1m 4s the patch passed
+1 :green_heart: javac 1m 4s the patch passed
+1 :green_heart: shadedjars 9m 4s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 37s the patch passed
_ Other Tests _
+1 :green_heart: unit 211m 14s hbase-server in the patch passed.
244m 3s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests javac javadoc unit shadedjars compile
uname Linux f72f4465fae7 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d399799c29
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/testReport/
Max. process+thread count 3663 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 19 '21 06:12 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 26s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 50s master passed
+1 :green_heart: compile 1m 34s master passed
+1 :green_heart: shadedjars 9m 53s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 50s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 5m 37s the patch passed
+1 :green_heart: compile 1m 34s the patch passed
+1 :green_heart: javac 1m 34s the patch passed
+1 :green_heart: shadedjars 9m 47s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 49s the patch passed
_ Other Tests _
-1 :x: unit 231m 55s hbase-server in the patch failed.
271m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1081752a3a28 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d399799c29
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/testReport/
Max. process+thread count 2951 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 19 '21 07:12 Apache-HBase

The failed UT is not related to the changes. Has rebased master branch and see the UT result this time.

YutSean avatar Dec 21 '21 08:12 YutSean

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 9s master passed
+1 :green_heart: compile 3m 12s master passed
+1 :green_heart: checkstyle 1m 5s master passed
+1 :green_heart: spotbugs 2m 6s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 51s the patch passed
+1 :green_heart: compile 3m 12s the patch passed
+1 :green_heart: javac 3m 12s the patch passed
-0 :warning: checkstyle 1m 3s hbase-server: The patch generated 1 new + 12 unchanged - 2 fixed = 13 total (was 14)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 19m 39s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 :x: spotbugs 2m 16s hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 :green_heart: asflicense 0m 16s The patch does not generate ASF License warnings.
49m 13s
Reason Tests
FindBugs module:hbase-server
org.apache.hadoop.hbase.io.hfile.FirstLevelBlockCache.STAT_THREAD_ENABLE_DEFAULT isn't final but should be At FirstLevelBlockCache.java:be At FirstLevelBlockCache.java:[line 35]
org.apache.hadoop.hbase.io.hfile.FirstLevelBlockCache.STAT_THREAD_ENABLE_KEY isn't final but should be At FirstLevelBlockCache.java:be At FirstLevelBlockCache.java:[line 34]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 34e8ad9cbad7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 314e924e96
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count 95 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 21 '21 09:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 6s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 49s master passed
+1 :green_heart: compile 1m 17s master passed
+1 :green_heart: shadedjars 8m 25s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 44s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 30s the patch passed
+1 :green_heart: compile 1m 13s the patch passed
+1 :green_heart: javac 1m 13s the patch passed
+1 :green_heart: shadedjars 8m 12s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 43s the patch passed
_ Other Tests _
+1 :green_heart: unit 146m 7s hbase-server in the patch passed.
178m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests javac javadoc unit shadedjars compile
uname Linux f2de6f5bb401 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 314e924e96
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/testReport/
Max. process+thread count 3506 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 21 '21 11:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 6m 58s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 33s master passed
+1 :green_heart: compile 1m 4s master passed
+1 :green_heart: shadedjars 9m 10s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 39s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 16s the patch passed
+1 :green_heart: compile 1m 4s the patch passed
+1 :green_heart: javac 1m 4s the patch passed
+1 :green_heart: shadedjars 9m 5s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 38s the patch passed
_ Other Tests _
+1 :green_heart: unit 211m 43s hbase-server in the patch passed.
250m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3939
Optional Tests javac javadoc unit shadedjars compile
uname Linux c5f61c2f40ac 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 314e924e96
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/testReport/
Max. process+thread count 2427 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3939/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 21 '21 12:12 Apache-HBase