HBASE-26117 RIT counts should be configured when cluster is balancing

[leyangyueshan]

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 :green_heart:	dupname	0m 0s	No case conflicting files found.
+1 :green_heart:	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 :green_heart:	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 :ok:	mvndep	0m 16s	Maven dependency ordering for branch
+1 :green_heart:	mvninstall	3m 55s	master passed
+1 :green_heart:	compile	4m 4s	master passed
+1 :green_heart:	checkstyle	1m 29s	master passed
+1 :green_heart:	spotbugs	2m 49s	master passed
		_ Patch Compile Tests _
+0 :ok:	mvndep	0m 14s	Maven dependency ordering for patch
+1 :green_heart:	mvninstall	3m 44s	the patch passed
+1 :green_heart:	compile	3m 55s	the patch passed
+1 :green_heart:	javac	3m 55s	the patch passed
+1 :green_heart:	checkstyle	1m 26s	the patch passed
+1 :green_heart:	whitespace	0m 0s	The patch has no whitespace issues.
+1 :green_heart:	hadoopcheck	18m 24s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 :green_heart:	spotbugs	3m 7s	the patch passed
		_ Other Tests _
+1 :green_heart:	asflicense	0m 26s	The patch does not generate ASF License warnings.
		52m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3524/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/3524
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 65b5d42b91ac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 51ed95c0cb
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3524/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	1m 16s	Docker mode activated.
-0 :warning:	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 :ok:	mvndep	0m 15s	Maven dependency ordering for branch
+1 :green_heart:	mvninstall	3m 51s	master passed
+1 :green_heart:	compile	1m 26s	master passed
+1 :green_heart:	shadedjars	8m 9s	branch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	1m 2s	master passed
		_ Patch Compile Tests _
+0 :ok:	mvndep	0m 16s	Maven dependency ordering for patch
+1 :green_heart:	mvninstall	3m 41s	the patch passed
+1 :green_heart:	compile	1m 26s	the patch passed
+1 :green_heart:	javac	1m 26s	the patch passed
+1 :green_heart:	shadedjars	8m 18s	patch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 59s	the patch passed
		_ Other Tests _
+1 :green_heart:	unit	1m 40s	hbase-common in the patch passed.
+1 :green_heart:	unit	152m 16s	hbase-server in the patch passed.
		187m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3524/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/3524
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b74814a23fb4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 51ed95c0cb
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3524/1/testReport/
Max. process+thread count	4463 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3524/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	0m 55s	Docker mode activated.
-0 :warning:	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 :ok:	mvndep	0m 15s	Maven dependency ordering for branch
+1 :green_heart:	mvninstall	5m 0s	master passed
+1 :green_heart:	compile	1m 44s	master passed
+1 :green_heart:	shadedjars	9m 3s	branch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	1m 8s	master passed
		_ Patch Compile Tests _
+0 :ok:	mvndep	0m 14s	Maven dependency ordering for patch
+1 :green_heart:	mvninstall	4m 51s	the patch passed
+1 :green_heart:	compile	1m 45s	the patch passed
+1 :green_heart:	javac	1m 45s	the patch passed
+1 :green_heart:	shadedjars	9m 1s	patch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	1m 4s	the patch passed
		_ Other Tests _
+1 :green_heart:	unit	2m 11s	hbase-common in the patch passed.
+1 :green_heart:	unit	202m 46s	hbase-server in the patch passed.
		241m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3524/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/3524
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7455e250046c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 51ed95c0cb
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3524/1/testReport/
Max. process+thread count	3329 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3524/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

This is hard coded in the past? Oh no.

And maybe it should be a percentage instead of a fixed value? Consider you have 10 regions, maybe 5 is too large but if you have 100k regions, 5 is too small?

WDYT?

[leyangyueshan]

@Apache9 Thanks， It’s should be configured！The percentage is complicated for business side I think。

[Apache9]

Checking the code again, I think here, the hard coded 5 is just for printing logs, not for the actual balancing work.

Could you please confirm this again?

        List<RegionStateNode> toPrint = regionsInTransition;
        int max = 5;
        boolean truncated = false;
        if (regionsInTransition.size() > max) {
          toPrint = regionsInTransition.subList(0, max);
          truncated = true;
        }

        if (!request.isIgnoreRegionsInTransition() || metaInTransition) {
          LOG.info("Not running balancer (ignoreRIT=false" + ", metaRIT=" + metaInTransition +
            ") because " + regionsInTransition.size() + " region(s) in transition: " + toPrint
            + (truncated? "(truncated list)": ""));
          return responseBuilder.build();
        }

The code is like this, we never use the toPrint list in other places.

Thanks.