hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-23761: The new cache entry can overflow the maxSize in CachedEn…

Open swaroopak opened this issue 5 years ago • 7 comments
trafficstars

…tryQueue

swaroopak avatar Jan 31 '20 01:01 swaroopak

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-0 :warning: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 55s master passed
+1 :green_heart: compile 0m 58s master passed
+1 :green_heart: checkstyle 1m 13s master passed
+1 :green_heart: shadedjars 5m 3s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 38s master passed
+0 :ok: spotbugs 4m 46s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 4m 44s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 5m 37s the patch passed
+1 :green_heart: compile 0m 58s the patch passed
+1 :green_heart: javac 0m 58s the patch passed
+1 :green_heart: checkstyle 1m 12s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: shadedjars 5m 8s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: hadoopcheck 17m 22s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 :green_heart: javadoc 0m 37s the patch passed
+1 :green_heart: findbugs 4m 38s the patch passed
_ Other Tests _
+1 :green_heart: unit 155m 48s hbase-server in the patch passed.
+1 :green_heart: asflicense 0m 28s The patch does not generate ASF License warnings.
218m 19s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/1110
JIRA Issue HBASE-23761
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d58f3f64047e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1110/out/precommit/personality/provided.sh
git revision master / 85b0c8e6bc
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/testReport/
Max. process+thread count 4472 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 31 '20 04:01 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-0 :warning: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 6m 0s master passed
+1 :green_heart: compile 0m 59s master passed
+1 :green_heart: checkstyle 1m 14s master passed
+1 :green_heart: shadedjars 5m 5s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 38s master passed
+0 :ok: spotbugs 4m 5s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 4m 3s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 5m 29s the patch passed
+1 :green_heart: compile 0m 59s the patch passed
+1 :green_heart: javac 0m 59s the patch passed
+1 :green_heart: checkstyle 1m 15s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: shadedjars 5m 9s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: hadoopcheck 17m 22s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 :green_heart: javadoc 0m 36s the patch passed
+1 :green_heart: findbugs 4m 52s the patch passed
_ Other Tests _
-1 :x: unit 33m 20s hbase-server in the patch failed.
+1 :green_heart: asflicense 0m 16s The patch does not generate ASF License warnings.
95m 16s
Reason Tests
Failed junit tests hadoop.hbase.io.hfile.TestCachedBlockQueue
hadoop.hbase.io.hfile.TestLruBlockCache
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1110/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/1110
JIRA Issue HBASE-23761
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 06c5a7ac2e54 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1110/out/precommit/personality/provided.sh
git revision master / 85b0c8e6bc
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1110/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1110/2/testReport/
Max. process+thread count 678 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1110/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 31 '20 06:01 Apache-HBase

@bharathv where should I add UT? I dont see an existing UT class for this class. Should I create a new one?

swaroopak avatar Feb 06 '20 21:02 swaroopak

Closing inactive PR. Please open new one when the unit test is done.

saintstack avatar Aug 21 '21 19:08 saintstack

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 17s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 28s master passed
+1 :green_heart: compile 1m 5s master passed
+1 :green_heart: shadedjars 9m 11s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 40s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 8s the patch passed
+1 :green_heart: compile 1m 4s the patch passed
+1 :green_heart: javac 1m 4s the patch passed
+1 :green_heart: shadedjars 9m 5s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 37s the patch passed
_ Other Tests _
-1 :x: unit 10m 43s hbase-server in the patch failed.
43m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/1110
JIRA Issue HBASE-23761
Optional Tests javac javadoc unit shadedjars compile
uname Linux 716fcdd00aa3 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6b5bd75e46
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/testReport/
Max. process+thread count 634 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '21 03:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 0s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 10s master passed
+1 :green_heart: compile 1m 21s master passed
+1 :green_heart: shadedjars 9m 4s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 43s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 51s the patch passed
+1 :green_heart: compile 1m 17s the patch passed
+1 :green_heart: javac 1m 17s the patch passed
+1 :green_heart: shadedjars 9m 4s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 41s the patch passed
_ Other Tests _
-1 :x: unit 12m 2s hbase-server in the patch failed.
46m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/1110
JIRA Issue HBASE-23761
Optional Tests javac javadoc unit shadedjars compile
uname Linux ba5f36812537 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6b5bd75e46
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/testReport/
Max. process+thread count 622 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '21 03:08 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 17s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 23s master passed
+1 :green_heart: compile 4m 39s master passed
+1 :green_heart: checkstyle 1m 13s master passed
+1 :green_heart: spotbugs 2m 12s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 5s the patch passed
+1 :green_heart: compile 3m 23s the patch passed
+1 :green_heart: javac 3m 23s the patch passed
+1 :green_heart: checkstyle 1m 10s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 20m 24s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 :green_heart: spotbugs 2m 21s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 13s The patch does not generate ASF License warnings.
53m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/1110
JIRA Issue HBASE-23761
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux de4ed633ba85 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6b5bd75e46
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1110/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 23 '21 03:08 Apache-HBase