hbase-thirdparty icon indicating copy to clipboard operation
hbase-thirdparty copied to clipboard

HBASE-29354 Jetty12 dependencies compiled with JDK17 violate hbase-thirdparty bytecode restrictions

Open NihalJain opened this issue 7 months ago • 3 comments

  • Override the maxJdkVersion to 17 in the jetty12 related modules
  • Unrelated: Fix spotless issue for existing changes

NihalJain avatar May 23 '25 22:05 NihalJain

Ran mvn clean verify -Prelease locally with this change.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.11-SNAPSHOT:
[INFO]
[INFO] Apache HBase Third-Party Libs ...................... SUCCESS [  4.768 s]
[INFO] Apache HBase Patched and Relocated (Shaded) Protobuf SUCCESS [ 30.952 s]
[INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SUCCESS [ 17.538 s]
[INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs  SUCCESS [  5.415 s]
[INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SUCCESS [  0.845 s]
[INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SUCCESS [ 10.829 s]
[INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SUCCESS [ 21.360 s]
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SUCCESS [  5.965 s]
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8  SUCCESS [  5.448 s]
[INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SUCCESS [ 14.518 s]
[INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SUCCESS [  1.448 s]
[INFO] Apache HBase Drop-in noop HTrace replacement ....... SUCCESS [01:41 min]
[INFO] Apache HBase Unsafe Wrapper ........................ SUCCESS [  2.655 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:44 min
[INFO] Finished at: 2025-05-23T22:37:59Z
[INFO] ------------------------------------------------------------------------

NihalJain avatar May 23 '25 22:05 NihalJain

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 19s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-0 :warning: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for branch
-1 :x: mvninstall 0m 18s root in master failed.
-1 :x: compile 0m 17s hbase-shaded-jetty-12-plus-core in master failed.
-1 :x: compile 0m 17s hbase-shaded-jetty-12-plus-ee8 in master failed.
-1 :x: javadoc 0m 17s hbase-shaded-jetty-12-plus-core in master failed.
-1 :x: javadoc 0m 17s hbase-shaded-jetty-12-plus-ee8 in master failed.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for patch
-1 :x: mvninstall 0m 17s hbase-shaded-jetty-12-plus-core in the patch failed.
-1 :x: mvninstall 0m 17s hbase-shaded-jetty-12-plus-ee8 in the patch failed.
-1 :x: compile 0m 17s hbase-shaded-jetty-12-plus-core in the patch failed.
-1 :x: compile 0m 18s hbase-shaded-jetty-12-plus-ee8 in the patch failed.
-1 :x: javac 0m 17s hbase-shaded-jetty-12-plus-core in the patch failed.
-1 :x: javac 0m 18s hbase-shaded-jetty-12-plus-ee8 in the patch failed.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 3s The patch has no ill-formed XML file.
-1 :x: javadoc 0m 17s hbase-shaded-jetty-12-plus-core in the patch failed.
-1 :x: javadoc 0m 17s hbase-shaded-jetty-12-plus-ee8 in the patch failed.
_ Other Tests _
-1 :x: unit 0m 18s hbase-shaded-jetty-12-plus-core in the patch failed.
-1 :x: unit 0m 17s hbase-shaded-jetty-12-plus-ee8 in the patch failed.
+0 :ok: asflicense 0m 35s ASF License check generated no output?
6m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-thirdparty/pull/139
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 04eb5371956b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / 223f4c6
Default Java Temurin-1.8.0_452-b09
mvninstall https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-jetty-12-plus-core.txt
compile https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-jetty-12-plus-ee8.txt
javadoc https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-jetty-12-plus-core.txt
javadoc https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt
mvninstall https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt
mvninstall https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt
compile https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt
compile https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt
javac https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt
javac https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt
javadoc https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt
javadoc https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt
unit https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt
unit https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/testReport/
Max. process+thread count 27 (vs. ulimit of 1000)
modules C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/1/console
versions git=2.43.0 maven=3.9.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 24 '25 01:05 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 5m 47s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-0 :warning: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for branch
+1 :green_heart: mvninstall 0m 46s master passed
+1 :green_heart: compile 0m 12s master passed
+1 :green_heart: javadoc 0m 15s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 5s Maven dependency ordering for patch
+1 :green_heart: mvninstall 0m 15s the patch passed
+1 :green_heart: compile 0m 10s the patch passed
+1 :green_heart: javac 0m 10s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 2s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 0m 10s the patch passed
_ Other Tests _
+1 :green_heart: unit 0m 5s hbase-shaded-jetty-12-plus-core in the patch passed.
+1 :green_heart: unit 0m 5s hbase-shaded-jetty-12-plus-ee8 in the patch passed.
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
8m 51s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-thirdparty/pull/139
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 02e449d7c86a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / 223f4c6
Default Java Temurin-1.8.0_452-b09
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/2/testReport/
Max. process+thread count 34 (vs. ulimit of 1000)
modules C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-139/2/console
versions git=2.43.0 maven=3.9.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar May 24 '25 05:05 Apache-HBase

closing in favor of #142, it fixes this issue!

NihalJain avatar Jul 22 '25 08:07 NihalJain