hbase-thirdparty
hbase-thirdparty copied to clipboard
apache
HBASE-28883 Manage hbase-thirdparty transitive dependencies via BOM pom
Also, please see code change required in HBase to consume this: https://github.com/NihalJain/hbase/commit/0b51c7161d6b891a703546d8ec90a64cb2d8535b
NOTE: Could not remove the hardcoding of internal.protobuf.version as with BOM seems its not possible to pass on properties.
Have kept relevant code still here in this PR. Will cleanup based on review.
CC: @ndimiduk
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 57s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 0m 47s | master passed |
| +1 :green_heart: | compile | 0m 13s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 40s | the patch passed |
| +1 :green_heart: | compile | 0m 17s | the patch passed |
| +1 :green_heart: | javac | 0m 17s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 11s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 0m 4s | hbase-thirdparty-bom in the patch passed. |
| +1 :green_heart: | unit | 0m 35s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| 4m 20s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/1/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/124 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 51519e3bfb6b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / a98a74b |
| Default Java | Temurin-1.8.0_422-b05 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/1/testReport/ |
| Max. process+thread count | 406 (vs. ulimit of 1000) |
| modules | C: hbase-thirdparty-bom . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/1/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 0m 46s | master passed |
| +1 :green_heart: | compile | 0m 12s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 40s | the patch passed |
| +1 :green_heart: | compile | 0m 18s | the patch passed |
| +1 :green_heart: | javac | 0m 18s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 11s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 0m 5s | hbase-thirdparty-bom in the patch passed. |
| +1 :green_heart: | unit | 0m 33s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| 3m 45s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/2/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/124 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux bd2c5f08ac3d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / a98a74b |
| Default Java | Temurin-1.8.0_422-b05 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/2/testReport/ |
| Max. process+thread count | 406 (vs. ulimit of 1000) |
| modules | C: hbase-thirdparty-bom . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/2/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 1m 14s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 0m 48s | master passed |
| +1 :green_heart: | compile | 0m 14s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 41s | the patch passed |
| +1 :green_heart: | compile | 0m 19s | the patch passed |
| +1 :green_heart: | javac | 0m 19s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 11s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 0m 5s | hbase-thirdparty-bom in the patch passed. |
| +1 :green_heart: | unit | 0m 33s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| 4m 41s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/3/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/124 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux ced608014c2e 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / a98a74b |
| Default Java | Temurin-1.8.0_422-b05 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/3/testReport/ |
| Max. process+thread count | 394 (vs. ulimit of 1000) |
| modules | C: hbase-thirdparty-bom . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-124/3/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
Looks alright by me. How does it work? have you tried a PR vs. the main repo that makes use of this?
Hi @ndimiduk Please refer https://github.com/apache/hbase/pull/6366
Actually should we have logging dependencies here?
Yes we can technically have all dependencies we want to keep common across our projects. Please let me know if we would like to add log4j and other logging jars over here. Also please let me know if we should evaluate other libs which can be moved to this bom, for eg: junit, mockito, hamcrest etc?
This PR was blocked due to open comment at https://github.com/apache/hbase/pull/6366#discussion_r1800961984
CC: @ndimiduk