hbase-native-client icon indicating copy to clipboard operation
hbase-native-client copied to clipboard

HBASE-23105: Download lib double conversion, fizz, update folly

Open phrocker opened this issue 5 years ago • 36 comments

and wangle and use std c++17

phrocker avatar Jun 13 '20 01:06 phrocker

@bharathv Thanks. making some changes now to download double conversion and gsasl2. will mark as ready for review after. thanks!

phrocker avatar Jun 23 '20 00:06 phrocker

Had a chance to apply your patch locally and try it out, running into this weird linker issue.

dependencies/facebook-folly-proj-install/lib/libfolly.a(AtFork.cpp.o): In function folly::detail::(anonymous namespace)::AtForkList::AtForkList()': /hbase-native-client2/build/dependencies/facebook-folly-proj-src/folly/detail/AtFork.cpp:95: undefined reference to pthread_atfork' collect2: error: ld returned 1 exit status CMakeFiles/simple-client.dir/build.make:139: recipe for target 'bin/examples/simple-client' failed make[2]: *** [bin/examples/simple-client] Error 1 CMakeFiles/Makefile2:554: recipe for target 'CMakeFiles/simple-client.dir/all' failed make[1]: *** [CMakeFiles/simple-client.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [ 96%] Building CXX object CMakeFiles/delete-test.dir/src/test/d

You don't run into this? I don't see anything the patch touches related to this.. I thought find_package(Threads) should transparently handle this and set CMAKE_THREAD_LIBS_INIT and I see it is being added to simple-client.. or may be I messed something up locally.

I'm back from vacation so I'll take a look with a fresh build environment. Thanks!

phrocker avatar Jul 07 '20 14:07 phrocker

Had a chance to apply your patch locally and try it out, running into this weird linker issue.

dependencies/facebook-folly-proj-install/lib/libfolly.a(AtFork.cpp.o): In function folly::detail::(anonymous namespace)::AtForkList::AtForkList()': /hbase-native-client2/build/dependencies/facebook-folly-proj-src/folly/detail/AtFork.cpp:95: undefined reference to pthread_atfork' collect2: error: ld returned 1 exit status CMakeFiles/simple-client.dir/build.make:139: recipe for target 'bin/examples/simple-client' failed make[2]: *** [bin/examples/simple-client] Error 1 CMakeFiles/Makefile2:554: recipe for target 'CMakeFiles/simple-client.dir/all' failed make[1]: *** [CMakeFiles/simple-client.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [ 96%] Building CXX object CMakeFiles/delete-test.dir/src/test/d

You don't run into this? I don't see anything the patch touches related to this.. I thought find_package(Threads) should transparently handle this and set CMAKE_THREAD_LIBS_INIT and I see it is being added to simple-client.. or may be I messed something up locally.

I'm back from vacation so I'll take a look with a fresh build environment. Thanks!

I did not notice any linker issues. I noticed a few things that were poorly extracted from my rebase ( and pulling commits from the original PR ), so it could be related to that. I have only tried on U20, so I will try across distros and docker now.

phrocker avatar Jul 09 '20 15:07 phrocker

Had a chance to apply your patch locally and try it out, running into this weird linker issue.

dependencies/facebook-folly-proj-install/lib/libfolly.a(AtFork.cpp.o): In function folly::detail::(anonymous namespace)::AtForkList::AtForkList()': /hbase-native-client2/build/dependencies/facebook-folly-proj-src/folly/detail/AtFork.cpp:95: undefined reference to pthread_atfork' collect2: error: ld returned 1 exit status CMakeFiles/simple-client.dir/build.make:139: recipe for target 'bin/examples/simple-client' failed make[2]: *** [bin/examples/simple-client] Error 1 CMakeFiles/Makefile2:554: recipe for target 'CMakeFiles/simple-client.dir/all' failed make[1]: *** [CMakeFiles/simple-client.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [ 96%] Building CXX object CMakeFiles/delete-test.dir/src/test/d

You don't run into this? I don't see anything the patch touches related to this.. I thought find_package(Threads) should transparently handle this and set CMAKE_THREAD_LIBS_INIT and I see it is being added to simple-client.. or may be I messed something up locally.

I'm back from vacation so I'll take a look with a fresh build environment. Thanks!

I did not notice any linker issues. I noticed a few things that were poorly extracted from my rebase ( and pulling commits from the original PR ), so it could be related to that. I have only tried on U20, so I will try across distros and docker now.

@bharathv I just checked my docker builds and they failed due to c++17. I anticipated this so I'll verify that and fix accordingly.

phrocker avatar Jul 09 '20 20:07 phrocker

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/console in case of problems.

Apache-HBase avatar Jul 13 '20 18:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 331 Docker mode activated.
_ Prechecks _
_ master Compile Tests _
-1 CMakeLists.txt 1059 root in master failed.
-1 compile 6 root in master failed.
_ Patch Compile Tests _
-1 CMakeLists.txt 296 root in the patch failed.
-1 compile 48 root in the patch failed.
_ Other Tests _
-1 unit 7 root in the patch failed.
1767
Reason Tests
Failed CTEST tests server-name-test
concurrent-map-test
zk-util-test
get-test
rpc-test
zk-deserializer-test
append-test
put-test
region-info-deserializer-test
scan-result-cache-test
hbase-configuration-test
cell-test
increment-test
user-util-test
scan-test
filter-test
client-deserializer-test
async-batch-rpc-retrying-test
connection-pool-test
table-name-test
location-cache-test
async-rpc-retrying-test
bytes-util-test
client-test
result-test
delete-test
exception-test
time-range-test
scanner-test
configuration-test
request-converter-test
client-serializer-test
location-cache-retry-test
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Optional Tests compile unit
uname Linux securecluster 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool cmake
Personality bin/hbase-native-client-personality.sh
git revision master / 931ecad
CMakeLists.txt https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt
compile https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/branch-compile-root.txt
CMakeLists.txt https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-CMakeLists.txt-root.txt
compile https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-compile-root.txt
CTEST https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt
unit https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/testReport/
Max. process+thread count 75 (vs. ulimit of 1000)
modules C: . U: .
Console output https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/1/console
versions git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 13 '20 18:07 Apache-HBase

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/console in case of problems.

Apache-HBase avatar Jul 14 '20 10:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 813 Docker mode activated.
_ Prechecks _
_ master Compile Tests _
-1 CMakeLists.txt 1243 root in master failed.
-1 compile 4 root in master failed.
_ Patch Compile Tests _
+1 CMakeLists.txt 351 the patch passed
-1 compile 53 root in the patch failed.
_ Other Tests _
-1 unit 6 root in the patch failed.
2486
Reason Tests
Failed CTEST tests zk-deserializer-test
filter-test
scanner-test
scan-result-cache-test
get-test
hbase-configuration-test
client-test
location-cache-retry-test
table-name-test
async-batch-rpc-retrying-test
cell-test
increment-test
connection-pool-test
put-test
user-util-test
server-name-test
bytes-util-test
delete-test
rpc-test
client-deserializer-test
region-info-deserializer-test
configuration-test
location-cache-test
concurrent-map-test
async-rpc-retrying-test
append-test
time-range-test
result-test
zk-util-test
request-converter-test
client-serializer-test
exception-test
scan-test
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/artifact/hbase-native-client-precommit/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Optional Tests compile unit
uname Linux securecluster 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool cmake
Personality bin/hbase-native-client-personality.sh
git revision master / 931ecad
CMakeLists.txt https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt
compile https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/artifact/hbase-native-client-precommit/output/branch-compile-root.txt
compile https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/artifact/hbase-native-client-precommit/output/patch-compile-root.txt
CTEST https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt
unit https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/artifact/hbase-native-client-precommit/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/testReport/
Max. process+thread count 63 (vs. ulimit of 1000)
modules C: . U: .
Console output https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/3/console
versions git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 14 '20 11:07 Apache-HBase

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/console in case of problems.

Apache-HBase avatar Jul 28 '20 10:07 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 326 Docker mode activated.
_ Prechecks _
_ master Compile Tests _
-1 CMakeLists.txt 1063 root in master failed.
-1 compile 6 root in master failed.
_ Patch Compile Tests _
+1 CMakeLists.txt 279 the patch passed
-1 compile 20 root in the patch failed.
_ Other Tests _
-1 unit 7 root in the patch failed.
1725
Reason Tests
Failed CTEST tests hbase-configuration-test
server-name-test
client-deserializer-test
location-cache-test
concurrent-map-test
rpc-test
scanner-test
cell-test
result-test
connection-pool-test
scan-result-cache-test
location-cache-retry-test
append-test
zk-util-test
get-test
user-util-test
region-info-deserializer-test
time-range-test
bytes-util-test
client-serializer-test
async-rpc-retrying-test
scan-test
put-test
configuration-test
request-converter-test
client-test
table-name-test
filter-test
increment-test
delete-test
async-batch-rpc-retrying-test
zk-deserializer-test
exception-test
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Optional Tests compile unit
uname Linux securecluster 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool cmake
Personality bin/hbase-native-client-personality.sh
git revision master / 931ecad
CMakeLists.txt https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt
compile https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/branch-compile-root.txt
compile https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/patch-compile-root.txt
CTEST https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt
unit https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/patch-unit-root.txt
Test Results https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/testReport/
Max. process+thread count 76 (vs. ulimit of 1000)
modules C: . U: .
Console output https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-6/4/console
versions git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 28 '20 10:07 Apache-HBase

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/console in case of problems.

Apache-HBase avatar Aug 02 '20 19:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 961 Docker mode activated.
_ Prechecks _
_ master Compile Tests _
-1 CMakeLists.txt 1055 root in master failed.
-1 compile 4 root in master failed.
_ Patch Compile Tests _
+1 CMakeLists.txt 291 the patch passed
-1 compile 36 root in the patch failed.
_ Other Tests _
-1 unit 5 root in the patch failed.
2371
Reason Tests
Failed CTEST tests location-cache-test
filter-test
async-rpc-retrying-test
location-cache-retry-test
hbase-configuration-test
table-name-test
delete-test
client-test
client-serializer-test
scan-test
request-converter-test
concurrent-map-test
zk-util-test
result-test
exception-test
user-util-test
server-name-test
zk-deserializer-test
get-test
put-test
configuration-test
increment-test
cell-test
connection-pool-test
append-test
bytes-util-test
scanner-test
time-range-test
scan-result-cache-test
client-deserializer-test
rpc-test
region-info-deserializer-test
async-batch-rpc-retrying-test
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Optional Tests compile unit
uname Linux securecluster 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool cmake
Personality bin/hbase-native-client-personality.sh
git revision master / 7281fc6
CMakeLists.txt https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/branch-compile-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-compile-root.txt
CTEST https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt
unit https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/testReport/
Max. process+thread count 76 (vs. ulimit of 1000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/console
versions git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 02 '20 20:08 Apache-HBase

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/console in case of problems.

Apache-HBase avatar Aug 05 '20 14:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 316 Docker mode activated.
_ Prechecks _
_ master Compile Tests _
-1 CMakeLists.txt 1098 root in master failed.
-1 compile 5 root in master failed.
_ Patch Compile Tests _
+1 CMakeLists.txt 291 the patch passed
-1 compile 26 root in the patch failed.
_ Other Tests _
-1 unit 6 root in the patch failed.
1762
Reason Tests
Failed CTEST tests put-test
cell-test
client-serializer-test
location-cache-test
get-test
scan-test
table-name-test
client-test
append-test
scan-result-cache-test
filter-test
zk-util-test
async-rpc-retrying-test
connection-pool-test
bytes-util-test
result-test
time-range-test
exception-test
zk-deserializer-test
user-util-test
configuration-test
rpc-test
async-batch-rpc-retrying-test
hbase-configuration-test
location-cache-retry-test
server-name-test
region-info-deserializer-test
increment-test
concurrent-map-test
scanner-test
request-converter-test
delete-test
client-deserializer-test
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/artifact/hbase-native-client-precommit/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Optional Tests compile unit
uname Linux securecluster 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool cmake
Personality bin/hbase-native-client-personality.sh
git revision master / 3b86174
CMakeLists.txt https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/artifact/hbase-native-client-precommit/output/branch-compile-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/artifact/hbase-native-client-precommit/output/patch-compile-root.txt
CTEST https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt
unit https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/artifact/hbase-native-client-precommit/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/testReport/
Max. process+thread count 76 (vs. ulimit of 1000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/2/console
versions git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 05 '20 14:08 Apache-HBase

@bharathv Sorry for the delay. I'm rebasing and rebuilding. ran into some issues with boost so I'll correct those then push them up . Thanks!

phrocker avatar Aug 14 '20 14:08 phrocker

@phrocker Sounds good, will take a look.

Sounds good. I had issues fixing the boost build problems. I think the issues may be linking in folly but was able to solve it in the root cmake. I'll track yetus, but had no build issues across my platforms ( u20, centos, etc ).

phrocker avatar Aug 15 '20 11:08 phrocker

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/console in case of problems.

Apache-HBase avatar Aug 15 '20 11:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 326 Docker mode activated.
_ Prechecks _
_ master Compile Tests _
-1 CMakeLists.txt 15 root in master failed.
-1 compile 15 root in master failed.
_ Patch Compile Tests _
-1 CMakeLists.txt 16 root in the patch failed.
-1 compile 15 root in the patch failed.
_ Other Tests _
-1 unit 15 root in the patch failed.
427
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Optional Tests compile unit
uname Linux securecluster 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool cmake
Personality bin/hbase-native-client-personality.sh
git revision master / 926a6f9
CMakeLists.txt https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/branch-compile-root.txt
CMakeLists.txt https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/patch-CMakeLists.txt-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/patch-compile-root.txt
unit https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/artifact/hbase-native-client-precommit/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/testReport/
Max. process+thread count 28 (vs. ulimit of 1000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/4/console
versions git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 15 '20 11:08 Apache-HBase

@bharathv thanks! I saw something about whitespace. Probably hygiene. Will address!

phrocker avatar Aug 16 '20 00:08 phrocker

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/console in case of problems.

Apache-HBase avatar Aug 16 '20 14:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 552 Docker mode activated.
_ Prechecks _
_ master Compile Tests _
-1 CMakeLists.txt 1129 root in master failed.
-1 compile 4 root in master failed.
_ Patch Compile Tests _
+1 CMakeLists.txt 313 the patch passed
-1 compile 185 root in the patch failed.
_ Other Tests _
-1 unit 13 root in the patch failed.
2216
Reason Tests
Failed CTEST tests zk-deserializer-test
filter-test
scanner-test
scan-result-cache-test
get-test
hbase-configuration-test
client-test
location-cache-retry-test
table-name-test
async-batch-rpc-retrying-test
cell-test
increment-test
connection-pool-test
put-test
user-util-test
server-name-test
bytes-util-test
delete-test
rpc-test
client-deserializer-test
region-info-deserializer-test
configuration-test
location-cache-test
concurrent-map-test
async-rpc-retrying-test
append-test
time-range-test
result-test
zk-util-test
request-converter-test
client-serializer-test
exception-test
scan-test
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/artifact/hbase-native-client-precommit/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Optional Tests compile unit
uname Linux securecluster 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool cmake
Personality bin/hbase-native-client-personality.sh
git revision master / 926a6f9
CMakeLists.txt https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/artifact/hbase-native-client-precommit/output/branch-compile-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/artifact/hbase-native-client-precommit/output/patch-compile-root.txt
CTEST https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt
unit https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/artifact/hbase-native-client-precommit/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/testReport/
Max. process+thread count 63 (vs. ulimit of 1000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/5/console
versions git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 16 '20 15:08 Apache-HBase

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/6/console in case of problems.

Apache-HBase avatar Aug 16 '20 21:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 docker 12 Docker failed to build yetus/hbase-native-client:3b81c3d.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Console output https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/6/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 16 '20 21:08 Apache-HBase

@bharathv I relied on CI to run docker for me. that appears to be the issue. xenial doesn't have libfmt-dev -- so I'll have to download that manually or add it to the build to get it to work, which should be pretty easy. hopefully will check the pre-commit after or run yetus manually. thanks for the info on how to run it!

phrocker avatar Aug 16 '20 22:08 phrocker

I think your following change also is related to the issue I'm running into, so perhaps you already know what the problem is

target_link_libraries(simple-client ${WHOLE_ARCHIVE} ${Boost_context} ${NO_WHOLE_ARCHIVE})

bharathv avatar Oct 29 '20 22:10 bharathv

I figured out the issue, submitted a new PR with my patch on top #14.

A quick summary of my patch addition

  • Patched fizz/wangle to find boost libs and pass boost root during compilation
  • Fixed the linking issue (removed your WHOLE_ARCHIVE workaround), our linking is still a bit messed up but I think the patch should be ok for now
  • Added cyrussasl dependency so that its compiled correctly.

Lets see how the precommit goes. There was an issue with libfmt-dev not available for ubuntu 16.04 but that looks optional, so removed it (not sure though).

@phrocker Feel free to apply my patch on top of your PR, I don't wan't to take credit for your work with one small final patch :-).

bharathv avatar Oct 30 '20 05:10 bharathv

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/console in case of problems.

Apache-HBase avatar Dec 14 '20 10:12 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 docker 20 Docker failed to build yetus/hbase-native-client:3b81c3d.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Console output https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 14 '20 10:12 Apache-HBase

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/console in case of problems.

Apache-HBase avatar Aug 15 '21 21:08 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 docker 12 Docker failed to build yetus/hbase-native-client:3b81c3d.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hbase-native-client/pull/6
JIRA Issue HBASE-23105
Console output https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Aug 15 '21 21:08 Apache-HBase