hbase-connectors icon indicating copy to clipboard operation
hbase-connectors copied to clipboard

Compatible with Spark4

Open awol2005ex opened this issue 1 year ago • 4 comments

awol2005ex avatar Jul 08 '24 01:07 awol2005ex

Compatible with Spark4

awol2005ex avatar Jul 08 '24 01:07 awol2005ex

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 11s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: markdownlint 0m 0s markdownlint was not available.
+0 :ok: spotbugs 0m 0s spotbugs executables are not available.
+0 :ok: prototool 0m 0s prototool was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 18 new or modified test files.
_ master Compile Tests _
+1 :green_heart: mvninstall 1m 41s master passed
+1 :green_heart: compile 0m 49s master passed
+1 :green_heart: spotless 0m 14s branch has no errors when running spotless:check.
+1 :green_heart: javadoc 0m 50s master passed
+1 :green_heart: scaladoc 0m 0s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
-1 :x: mvninstall 1m 16s root in the patch failed.
-1 :x: compile 1m 1s root in the patch failed.
-1 :x: cc 1m 1s root in the patch failed.
-1 :x: javac 1m 1s root in the patch failed.
-1 :x: scalac 1m 1s root in the patch failed.
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 5s The patch has no ill-formed XML file.
-1 :x: spotless 0m 17s patch has 73 errors when running spotless:check, run spotless:apply to fix.
-1 :x: javadoc 1m 0s root in the patch failed.
+1 :green_heart: scaladoc 0m 0s the patch passed
_ Other Tests _
-1 :x: unit 8m 17s root in the patch failed.
17m 51s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase-connectors/pull/130
Optional Tests dupname javac javadoc unit spotless xml compile markdownlint spotbugs findbugs cc prototool scalac scaladoc
uname Linux 4e58cf8d36ca 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 307607c
Default Java Oracle Corporation-1.8.0_282-b08
mvninstall https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
cc https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
scalac https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
spotless https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/patch-spotless.txt
javadoc https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/patch-javadoc-root.txt
unit https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/testReport/
Max. process+thread count 944 (vs. ulimit of 12500)
modules C: spark4 spark4/hbase-spark4-protocol . spark4/hbase-spark4 spark4/hbase-spark4-it spark4/hbase-spark4-protocol-shaded U: .
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-130/1/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 08 '24 02:07 Apache-HBase

Hi @awol2005ex we use JIRA to track issues and related work. Mind if you capture what you plan to do with this PR by creating a new jira at https://issues.apache.org/jira/browse/hbase. Also it would be great if you describe what you are trying to do in this PR. The PR is huge and seems like a copy of current code.

NihalJain avatar Aug 12 '24 16:08 NihalJain

A completely new module may or may not be needed, depending on how backwards compatbile Spark4 is.

We should first decide if we want to maintain Spark2 compatbility (or even if the current code is still Spark 2 compatible)

Please start a discussion on [email protected] @awol2005ex .

stoty avatar Feb 19 '25 12:02 stoty