hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard
verified publisher icon apache

HDFS-17831. Unexpected exception in org.apache.hadoop.hdfs.server.namenode.TestCheckpoint with Java 24

Open stoty opened this issue 3 months ago • 8 comments

Description of PR

Java 24 has changed the behaviour for HTTP short reads, and now throws an IOException. Update the expected Exception for Java 24.

How was this patch tested?

Ran test with Java 8 and 24

For code changes:

  • [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

stoty avatar Sep 15 '25 08:09 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 33m 24s trunk passed
+1 :green_heart: compile 0m 46s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 0m 39s trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: checkstyle 0m 40s trunk passed
+1 :green_heart: mvnsite 0m 47s trunk passed
+1 :green_heart: javadoc 0m 45s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 9s trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: spotbugs 1m 42s trunk passed
+1 :green_heart: shadedclient 22m 33s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 37s the patch passed
+1 :green_heart: compile 0m 38s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 0m 38s the patch passed
+1 :green_heart: compile 0m 37s the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: javac 0m 37s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 28s the patch passed
+1 :green_heart: mvnsite 0m 36s the patch passed
+1 :green_heart: javadoc 0m 33s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 2s the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: spotbugs 1m 49s the patch passed
+1 :green_heart: shadedclient 21m 55s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 199m 10s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 28s The patch does not generate ASF License warnings.
290m 18s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithShortCircuitRead
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/7961
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 41dfc1dbf212 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9e243ac12b983eb7839dcefdd7bc9f12638bfb59
Default Java Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/4/testReport/
Max. process+thread count 3385 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 15 '25 14:09 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 55m 12s trunk passed
+1 :green_heart: compile 1m 32s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 1m 17s trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: checkstyle 1m 14s trunk passed
+1 :green_heart: mvnsite 1m 27s trunk passed
+1 :green_heart: javadoc 1m 16s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 45s trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: spotbugs 3m 38s trunk passed
+1 :green_heart: shadedclient 42m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 18s the patch passed
+1 :green_heart: compile 1m 25s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 1m 25s the patch passed
+1 :green_heart: compile 1m 9s the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: javac 1m 9s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 2s the patch passed
+1 :green_heart: mvnsite 1m 13s the patch passed
+1 :green_heart: javadoc 1m 3s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 36s the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: spotbugs 3m 32s the patch passed
+1 :green_heart: shadedclient 45m 57s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 243m 58s hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 53s The patch does not generate ASF License warnings.
411m 39s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/7961
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 398b111967b1 5.15.0-144-generic #157-Ubuntu SMP Mon Jun 16 07:33:10 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 28272fceb45283805493fd187f68c695f35e09d8
Default Java Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/1/testReport/
Max. process+thread count 3242 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 15 '25 15:09 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 22m 22s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 53m 16s trunk passed
+1 :green_heart: compile 1m 35s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 1m 17s trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: checkstyle 1m 14s trunk passed
+1 :green_heart: mvnsite 1m 25s trunk passed
+1 :green_heart: javadoc 1m 18s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 46s trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: spotbugs 3m 35s trunk passed
+1 :green_heart: shadedclient 41m 39s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 14s the patch passed
+1 :green_heart: compile 1m 26s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 1m 27s the patch passed
+1 :green_heart: compile 1m 10s the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: javac 1m 10s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 3s the patch passed
+1 :green_heart: mvnsite 1m 19s the patch passed
+1 :green_heart: javadoc 1m 10s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 39s the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: spotbugs 3m 35s the patch passed
+1 :green_heart: shadedclient 42m 5s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 412m 22s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 55s The patch does not generate ASF License warnings.
595m 32s
Reason Tests
Failed junit tests hadoop.hdfs.tools.TestDFSAdmin
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/7961
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux dfe3cea7ef7d 5.15.0-151-generic #161-Ubuntu SMP Tue Jul 22 14:25:40 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 24177eeca0a941f3fabac5f279e4f12f6a8c1fd9
Default Java Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/2/testReport/
Max. process+thread count 2232 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 15 '25 18:09 hadoop-yetus

PTAL @slfan1989 .

stoty avatar Sep 16 '25 04:09 stoty

The test failures are pre-existing and not related to my changes.

stoty avatar Sep 17 '25 08:09 stoty

Can you review this @slfan1989 ? This test breaks on JDK24+.

stoty avatar Oct 27 '25 11:10 stoty

rebased on trunk

stoty avatar Nov 21 '25 11:11 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 0s Docker mode activated.
-1 :x: patch 0m 36s https://github.com/apache/hadoop/pull/7961 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hadoop/pull/7961
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7961/5/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Nov 21 '25 11:11 hadoop-yetus