Fix: add NULL check in cJSON_InsertItemInArray
Description of PR
Applying a fix from the original codebase that has not been applied here yet. This adds a NULL check in cJSON_InsertItemInArray.
Referenced from the original commit here: https://github.com/DaveGamble/cJSON/commit/60ff122ef5862d04b39b150541459e7f5e35add8
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 40m 15s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 1s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 1s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | |
| _ trunk Compile Tests _ | ||||
| -1 :x: | mvninstall | 37m 25s | /branch-mvninstall-root.txt | root in trunk failed. |
| +1 :green_heart: | compile | 1m 22s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 50s | trunk passed | |
| +1 :green_heart: | shadedclient | 74m 14s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 36s | the patch passed | |
| +1 :green_heart: | compile | 1m 13s | the patch passed | |
| -1 :x: | cc | 1m 13s | /results-compile-cc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt | hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 3 new + 51 unchanged - 0 fixed = 54 total (was 51) |
| +1 :green_heart: | golang | 1m 13s | the patch passed | |
| +1 :green_heart: | javac | 1m 13s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| +1 :green_heart: | mvnsite | 0m 38s | the patch passed | |
| +1 :green_heart: | shadedclient | 34m 22s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 28m 12s | hadoop-yarn-server-nodemanager in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | |
| 181m 23s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.50 ServerAPI=1.50 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7741/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7741 |
| Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang |
| uname | Linux 3c264c0264b7 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 5355060a2260c5ad7c15699e1f04ab5b31228b80 |
| Default Java | Red Hat, Inc.-1.8.0_412-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7741/1/testReport/ |
| Max. process+thread count | 700 (vs. ulimit of 5500) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7741/1/console |
| versions | git=2.9.5 maven=3.6.3 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again. Thanks all for your contribution.