HDFS-17780. The retry logic in IncrementalBlockReport may bypass the configured IBR interval, causing contention on NameNode

[shangshu-qian]

Description of PR

As described in HDFS-17780, the retry logic in sendIBR() can bypass the configuration of dfs.blockreport.incremental.intervalMsec and cause the IBR to be sent with every heartbeat.

The fix updates the IBR timestamp every time the RPC is called.

How was this patch tested?

No test needed.

For code changes:

• [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	8m 3s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
-1 :x:	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 :green_heart:	mvninstall	23m 57s		trunk passed
+1 :green_heart:	compile	0m 43s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	compile	0m 40s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart:	checkstyle	0m 36s		trunk passed
+1 :green_heart:	mvnsite	0m 44s		trunk passed
+1 :green_heart:	javadoc	0m 43s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javadoc	1m 4s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart:	spotbugs	1m 45s		trunk passed
+1 :green_heart:	shadedclient	21m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	0m 36s		the patch passed
+1 :green_heart:	compile	0m 38s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javac	0m 38s		the patch passed
+1 :green_heart:	compile	0m 36s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart:	javac	0m 36s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 28s		the patch passed
+1 :green_heart:	mvnsite	0m 37s		the patch passed
+1 :green_heart:	javadoc	0m 32s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javadoc	0m 59s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart:	spotbugs	1m 38s		the patch passed
+1 :green_heart:	shadedclient	21m 12s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 :green_heart:	unit	9m 25s		hadoop-hdfs in the patch passed.
+1 :green_heart:	asflicense	0m 24s		The patch does not generate ASF License warnings.
		96m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7681/1/artifact/out/Dockerfile
GITHUB PR	https://github.com/apache/hadoop/pull/7681
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 604c9bfe46ee 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 4c74b4bd7ae864c483f9a2e1ae501ab43cc36de4
Default Java	Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7681/1/testReport/
Max. process+thread count	1180 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7681/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[github-actions[bot]]

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again. Thanks all for your contribution.