hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HADOOP-19517 [java.time] hadoop-common

Open YanivKunda opened this issue 9 months ago • 2 comments

Description of PR

Migration to java.time classes in hadoop-common

How was this patch tested?

Ran existing tests

For code changes:

  • [V] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

YanivKunda avatar Mar 31 '25 20:03 YanivKunda

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 13 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 6m 23s Maven dependency ordering for branch
+1 :green_heart: mvninstall 21m 21s trunk passed
+1 :green_heart: compile 9m 27s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 :green_heart: compile 7m 53s trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
+1 :green_heart: checkstyle 2m 12s trunk passed
+1 :green_heart: mvnsite 2m 33s trunk passed
+1 :green_heart: javadoc 2m 5s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 :green_heart: javadoc 2m 17s trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
+1 :green_heart: spotbugs 4m 30s trunk passed
+1 :green_heart: shadedclient 22m 46s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 23s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 21s the patch passed
+1 :green_heart: compile 8m 42s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 :green_heart: javac 8m 42s the patch passed
+1 :green_heart: compile 9m 2s the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
+1 :green_heart: javac 9m 2s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 2m 13s /results-checkstyle-root.txt root: The patch generated 12 new + 395 unchanged - 7 fixed = 407 total (was 402)
+1 :green_heart: mvnsite 2m 32s the patch passed
-1 :x: javadoc 0m 37s /results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt hadoop-common-project_hadoop-common-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 :green_heart: javadoc 2m 4s the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
+1 :green_heart: spotbugs 4m 34s the patch passed
+1 :green_heart: shadedclient 22m 9s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 13m 15s hadoop-common in the patch passed.
+1 :green_heart: unit 1m 13s hadoop-hdfs in the patch passed.
+1 :green_heart: unit 6m 46s hadoop-mapreduce-client-core in the patch passed.
+1 :green_heart: asflicense 0m 42s The patch does not generate ASF License warnings.
161m 14s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7562/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/7562
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 91674e50ebc7 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / fb9313fdad122c86a1dbaa2ead3190892b62b173
Default Java Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7562/1/testReport/
Max. process+thread count 2934 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7562/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Mar 31 '25 22:03 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 13 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 6m 53s Maven dependency ordering for branch
+1 :green_heart: mvninstall 36m 36s trunk passed
+1 :green_heart: compile 17m 17s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 :green_heart: compile 14m 48s trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
+1 :green_heart: checkstyle 4m 49s trunk passed
+1 :green_heart: mvnsite 4m 1s trunk passed
+1 :green_heart: javadoc 3m 20s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 :green_heart: javadoc 3m 25s trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
+1 :green_heart: spotbugs 7m 20s trunk passed
+1 :green_heart: shadedclient 39m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 33s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 32s the patch passed
+1 :green_heart: compile 16m 38s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 :green_heart: javac 16m 38s the patch passed
+1 :green_heart: compile 14m 47s the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
+1 :green_heart: javac 14m 47s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 4m 35s /results-checkstyle-root.txt root: The patch generated 12 new + 394 unchanged - 7 fixed = 406 total (was 401)
+1 :green_heart: mvnsite 4m 4s the patch passed
+1 :green_heart: javadoc 3m 14s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 :green_heart: javadoc 3m 29s the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
+1 :green_heart: spotbugs 7m 58s the patch passed
+1 :green_heart: shadedclient 39m 47s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 14m 44s hadoop-common in the patch passed.
+1 :green_heart: unit 1m 46s hadoop-hdfs in the patch passed.
+1 :green_heart: unit 8m 57s hadoop-mapreduce-client-core in the patch passed.
+1 :green_heart: asflicense 1m 4s The patch does not generate ASF License warnings.
267m 6s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7562/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/7562
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 6bf2d4aa1cf1 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2f48e9cbd7f2551e55ffe27c5ed583fd1bc2166b
Default Java Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7562/2/testReport/
Max. process+thread count 1273 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7562/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 01 '25 01:04 hadoop-yetus

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again. Thanks all for your contribution.

github-actions[bot] avatar Sep 11 '25 00:09 github-actions[bot]