HDFS-17751. [ARR] Add unit tests using asynchronous router rpc for all in org.apache.hadoop.hdfs.server.federation.router.
Description of PR
All unit tests in org.apache.hadoop.hdfs.server.federation.router package as below:
I will add async version soonly.
:negative_squared_cross_mark: means no needs to modify :white_check_mark: means done
| Test Case Name | Status |
|---|---|
| TestConnectionManager | :negative_squared_cross_mark: |
| TestDFSRouter | :negative_squared_cross_mark: |
| TestDisableNameservices | :white_check_mark: |
| TestDisableRouterQuota | |
| TestFederationUtil | |
| TestNoNamenodesAvailableLongTime | |
| TestObserverWithRouter | |
| TestPoolAlignmentContext | |
| TestRBFConfigFields | |
| TestRenewLeaseWithSameINodeId | |
| TestRouter | |
| TestRouterAdmin | |
| TestRouterAdminCLI | |
| TestRouterAdminGenericRefresh | |
| TestRouterAllResolver | |
| TestRouterClientRejectOverload | |
| TestRouterFaultTolerant | |
| TestRouterFederatedState | |
| TestRouterFederationRename | |
| TestRouterFederationRenameBase | |
| TestRouterFederationRenameInKerberosEnv | |
| TestRouterFederationRenamePermission | |
| TestRouterFsck | |
| TestRouterHeartbeatService | |
| TestRouterHttpServerXFrame | |
| TestRouterMissingFolderMulti | |
| TestRouterMountTable | |
| TestRouterMountTableCacheRefresh | |
| TestRouterMountTableCacheRefreshSecure | |
| TestRouterMountTableWithoutDefaultNS | |
| TestRouterMultiRack | |
| TestRouterNamenodeHeartbeat | |
| TestRouterNamenodeMonitoring | |
| TestRouterNamenodeWebScheme | |
| TestRouterNetworkTopologyServlet | |
| TestRouterPolicyProvider | |
| TestRouterQuota | |
| TestRouterQuotaManager | :negative_squared_cross_mark: |
| TestRouterRefreshSuperUserGroupsConfiguration | |
| TestRouterRetryCache | |
| TestRouterRpc | |
| TestRouterRPCClientRetries | |
| TestRouterRpcMultiDestination | |
| TestRouterRPCMultipleDestinationMountTableResolver | |
| TestRouterRpcSingleNS | |
| TestRouterRpcStoragePolicySatisfier | |
| TestRouterSafemode | |
| TestRouterTrash | |
| TestRouterUserMappings | |
| TestRouterWebHdfsMethods | |
| TestRouterWithSecureStartup | |
| TestSafeMode |
How was this patch tested?
Add unit tests.
@hfutatzhanghb Thank you for your contribution! However, I don't think adding unit tests for these packages is the best approach. If it's just a change in configuration, using parameterized tests would be a more appropriate choice, as it allows for maximum reuse of the existing test code. We can refer to the following documentation for more details: JUnit 5 Parameterized Tests.
cc: @ayushtkn @steveloughran @Hexiaoqiao
We can refer to TestRouterMountTableCacheRefresh as an example.
@RunWith(Parameterized.class)
public class TestRouterMountTableCacheRefresh {
private static TestingServer curatorTestingServer;
private static MiniRouterDFSCluster cluster;
private static RouterContext routerContext;
private static MountTableManager mountTableManager;
@Parameterized.Parameters
public static Collection<Object> data() {
return Arrays.asList(new Object[] {true, false});
}
......
Sir, Thanks a lot for your valuable suggestions. Will use parameterized tests to implement this.
---- Replied Message ---- | From | @.> | | Date | 03/05/2025 21:44 | | To | @.> | | Cc | @.>@.> | | Subject | Re: [apache/hadoop] HDFS-17751. [ARR] Add unit tests using asynchronous router rpc for all in org.apache.hadoop.hdfs.server.federation.router. (PR #7470) |
@hfutatzhanghb Thank you for your contribution! However, I don't think adding unit tests for these packages is the best approach. If it's just a change in configuration, using parameterized tests would be a more appropriate choice, as it allows for maximum reuse of the existing test code. We can refer to the following documentation for more details: JUnit 5 Parameterized Tests.
cc: @@.***@Hexiaoqiao
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
slfan1989 left a comment (apache/hadoop#7470)
@hfutatzhanghb Thank you for your contribution! However, I don't think adding unit tests for these packages is the best approach. If it's just a change in configuration, using parameterized tests would be a more appropriate choice, as it allows for maximum reuse of the existing test code. We can refer to the following documentation for more details: JUnit 5 Parameterized Tests.
cc: @@.***@Hexiaoqiao
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 1s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 1s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 36m 9s | trunk passed | |
| +1 :green_heart: | compile | 1m 7s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 42s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 33s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 48s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 44s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 34s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 31s | trunk passed | |
| +1 :green_heart: | shadedclient | 34m 31s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 36s | the patch passed | |
| +1 :green_heart: | compile | 0m 56s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 56s | the patch passed | |
| +1 :green_heart: | compile | 0m 33s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 33s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 20s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 38s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 25s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 28s | the patch passed | |
| +1 :green_heart: | shadedclient | 34m 13s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| -1 :x: | unit | 50m 46s | /patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-rbf in the patch passed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. | |
| 169m 58s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.hdfs.server.federation.router.TestRouterFederationRename |
| hadoop.hdfs.server.federation.router.async.TestSafeModeWithRouterAsync |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 1f2aedd1da8c 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 713d92fa565b9560859998aff1c763418052539d |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/1/testReport/ |
| Max. process+thread count | 3261 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
@hfutatzhanghb Thank you very much for being willing to add unit tests, as it will significantly improve the robustness of the system. However, we need to have a deeper discussion regarding these changes to the unit tests. Recently, I’ve been upgrading to JUnit 5, so I’m particularly focused on testing-related topics.
I’ve initially reviewed the relevant tests and found that the main difference between the synchronous and asynchronous routers lies in the configuration within the Configuration: The RBFConfigKeys.DFS_ROUTER_ASYNC_RPC_ENABLE_KEY parameter determines the type of router. If the parameter is set to true, it enables the asynchronous router; if set to false, the synchronous router is used.
My initial suggestion is to use JUnit 5’s Parameterized Tests so that we can validate both configurations in the same test class.
However, after discussing with hfutatzhanghb, I learned an important point: HDFS Router tests typically require initializing a minicluster, and miniclusters are resource-intensive components. If we use Parameterized Tests, it would mean starting a minicluster for each test case, which would incur a significant overhead.
I have considered two alternative approaches for the current situation:
Option 1: When using Parameterized Tests, we can use the @MethodSource annotation during initialization. In a custom method, we can initialize two different router miniclusters, then pass them into the test method for further testing.
After the test completes, we would need to destroy the corresponding MiniCluster to release the resources.
Here is an example code:
@ParameterizedTest
@MethodSource("getRouterMiniCluster")
void testWithExplicitLocalMethodSource(String argument) {
assertNotNull(argument);
}
Stream<String> getRouterMiniCluster() {
return Stream.of("MiniCluster1", "MiniCluster2");
}
Option 2: Referencing TestJettyHelper, we can define a utility class in JUnit 5 to manage the MiniCluster. This utility class would extend JUnit 5's BeforeEachCallback and AfterEachCallback.
Before each test method is executed, we can check whether the synchronous or asynchronous cluster has been created. If not, we create the cluster and store the information in ThreadLocal, which helps avoid creating the cluster multiple times.
Here is a part of the code:
private static final ThreadLocal<TestJettyHelper> TEST_JETTY_TL =
new InheritableThreadLocal<TestJettyHelper>();
private Server createJettyServer() {
try {
InetAddress localhost = InetAddress.getByName("localhost");
String host = "localhost";
ServerSocket ss = new ServerSocket(0, 50, localhost);
int port = ss.getLocalPort();
ss.close();
Server server = new Server();
ServerConnector conn = new ServerConnector(server);
HttpConfiguration http_config = new HttpConfiguration();
http_config.setRequestHeaderSize(JettyUtils.HEADER_SIZE);
http_config.setResponseHeaderSize(JettyUtils.HEADER_SIZE);
http_config.setSecureScheme("https");
http_config.addCustomizer(new SecureRequestCustomizer());
ConnectionFactory connFactory = new HttpConnectionFactory(http_config);
conn.addConnectionFactory(connFactory);
conn.setHost(host);
conn.setPort(port);
......
} catch (Exception ex) {
throw new RuntimeException("Could not start embedded servlet container, " + ex.getMessage(), ex);
}
}
@slfan1989 Sir, thanks so much for providing the approach to solve this problem gracefully. I will dive into these two suggestions and push this pr soonly. BTW, i think below PRs will not be blocked by this pr, because below PRs just add two classes and i will refactor them after merging or even ignore them. What's your opinions? https://github.com/apache/hadoop/pull/7445 https://github.com/apache/hadoop/pull/7462 https://github.com/apache/hadoop/pull/7464 https://github.com/apache/hadoop/pull/7466
@Hexiaoqiao @KeeProMise Sir, please also cc. Thanks all again.
@slfan1989 Sir, thanks so much for providing the approach to solve this problem gracefully. I will dive into these two suggestions and push this pr soonly. BTW, i think below PRs will not be blocked by this pr, because below PRs just add two classes and i will refactor them after merging or even ignore them. What's your opinions? #7445 #7462 #7464 #7466
@Hexiaoqiao @KeeProMise Sir, please also cc. Thanks all again.
@hfutatzhanghb I have no objections to other PRs, but if you need to make large-scale modifications to the unit tests to support ARR, feel free to @ me, and we can discuss it further. We aim to improve the system through unit tests, but we also want to adopt a better approach, rather than just relying on class inheritance. Thanks again for your contribution!
@slfan1989 Sir, thanks so much for providing the approach to solve this problem gracefully. I will dive into these two suggestions and push this pr soonly. BTW, i think below PRs will not be blocked by this pr, because below PRs just add two classes and i will refactor them after merging or even ignore them. What's your opinions? #7445 #7462 #7464 #7466 @Hexiaoqiao @KeeProMise Sir, please also cc. Thanks all again.
@hfutatzhanghb I have no objections to other PRs, but if you need to make large-scale modifications to the unit tests to support ARR, feel free to @ me, and we can discuss it further. We aim to improve the system through unit tests, but we also want to adopt a better approach, rather than just relying on class inheritance. Thanks again for your contribution!
Sir, totally agree with you, we should make system robust and code clean in the meantime. Thanks for your help.
Upload an example using xxxCallBack interface. It indeed initializes cluster only once for the same category tests.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 1s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 1s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 36m 17s | trunk passed | |
| +1 :green_heart: | compile | 1m 6s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 44s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 33s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 49s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 44s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 34s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 30s | trunk passed | |
| +1 :green_heart: | shadedclient | 34m 39s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 35s | the patch passed | |
| +1 :green_heart: | compile | 0m 58s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 58s | the patch passed | |
| +1 :green_heart: | compile | 0m 34s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 34s | the patch passed | |
| -1 :x: | blanks | 0m 0s | /blanks-eol.txt | The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | checkstyle | 0m 21s | the patch passed | |
| +1 :green_heart: | mvnsite | 0m 38s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 30s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 25s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 30s | the patch passed | |
| +1 :green_heart: | shadedclient | 34m 37s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 42m 13s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. | |
| 162m 1s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 3e22e38587b1 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 099e03c5029e29f897ffe8f8e4007fcd82ac075f |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/2/testReport/ |
| Max. process+thread count | 3104 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/2/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
@slfan1989 Sir, thanks so much for providing the approach to solve this problem gracefully. I will dive into these two suggestions and push this pr soonly. BTW, i think below PRs will not be blocked by this pr, because below PRs just add two classes and i will refactor them after merging or even ignore them. What's your opinions? #7445 #7462 #7464 #7466
@Hexiaoqiao @KeeProMise Sir, please also cc. Thanks all again.
hi @hfutatzhanghb I think other PRs are not closely related to UT. They are meant to solve other issues, so they shouldn't be blocked.
@slfan1989 Sir, thanks so much for providing the approach to solve this problem gracefully. I will dive into these two suggestions and push this pr soonly. BTW, i think below PRs will not be blocked by this pr, because below PRs just add two classes and i will refactor them after merging or even ignore them. What's your opinions? #7445 #7462 #7464 #7466 @Hexiaoqiao @KeeProMise Sir, please also cc. Thanks all again.
hi @hfutatzhanghb I think other PRs are not closely related to UT. They are meant to solve other issues, so they shouldn't be blocked.
Sir, thanks for responding. Got it.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 37m 43s | trunk passed | |
| +1 :green_heart: | compile | 1m 4s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 38s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 30s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 46s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 42s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 31s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 31s | trunk passed | |
| +1 :green_heart: | shadedclient | 35m 29s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 35s | the patch passed | |
| +1 :green_heart: | compile | 0m 56s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 56s | the patch passed | |
| +1 :green_heart: | compile | 0m 33s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 33s | the patch passed | |
| -1 :x: | blanks | 0m 0s | /blanks-eol.txt | The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -0 :warning: | checkstyle | 0m 21s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 48 new + 0 unchanged - 0 fixed = 48 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 36s | the patch passed | |
| -1 :x: | javadoc | 0m 30s | /results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt | hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | javadoc | 0m 24s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 27s | the patch passed | |
| +1 :green_heart: | shadedclient | 36m 5s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 49m 21s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. | |
| 172m 28s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux e7be41d3bb2d 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / d77d25e2d862df0204083163f5485a6d3d28d877 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/3/testReport/ |
| Max. process+thread count | 3763 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/3/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 37m 23s | trunk passed | |
| +1 :green_heart: | compile | 1m 4s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 41s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 32s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 43s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 41s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 32s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 31s | trunk passed | |
| +1 :green_heart: | shadedclient | 35m 57s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 34s | the patch passed | |
| +1 :green_heart: | compile | 0m 56s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 56s | the patch passed | |
| +1 :green_heart: | compile | 0m 31s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 31s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 21s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 48 new + 0 unchanged - 0 fixed = 48 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 36s | the patch passed | |
| -1 :x: | javadoc | 0m 30s | /results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt | hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | javadoc | 0m 24s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 30s | the patch passed | |
| +1 :green_heart: | shadedclient | 37m 38s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 49m 32s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. | |
| 174m 15s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 488636da13e5 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 831e45542f9aeea00e70189d031d7e9055b959c4 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/4/testReport/ |
| Max. process+thread count | 3653 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/4/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 1s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 1s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 37m 30s | trunk passed | |
| +1 :green_heart: | compile | 1m 1s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 39s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 29s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 43s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 40s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 30s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 27s | trunk passed | |
| +1 :green_heart: | shadedclient | 36m 18s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 33s | the patch passed | |
| +1 :green_heart: | compile | 0m 55s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 55s | the patch passed | |
| +1 :green_heart: | compile | 0m 32s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 32s | the patch passed | |
| +1 :green_heart: | blanks | 0m 1s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 20s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 48 new + 0 unchanged - 0 fixed = 48 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 37s | the patch passed | |
| -1 :x: | javadoc | 0m 30s | /results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt | hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | javadoc | 0m 25s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 27s | the patch passed | |
| +1 :green_heart: | shadedclient | 35m 14s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 56m 16s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. | |
| 178m 52s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 1cfe10ffbc3b 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 82b67dbebacd84001d21ff907bab38b772d10600 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/5/testReport/ |
| Max. process+thread count | 4412 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/5/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 49s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 42m 14s | trunk passed | |
| +1 :green_heart: | compile | 1m 12s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 43s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 31s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 47s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 43s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 33s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 31s | trunk passed | |
| +1 :green_heart: | shadedclient | 39m 20s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 36s | the patch passed | |
| +1 :green_heart: | compile | 1m 5s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 1m 5s | the patch passed | |
| +1 :green_heart: | compile | 0m 34s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 34s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 21s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 48 new + 0 unchanged - 0 fixed = 48 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 37s | the patch passed | |
| -1 :x: | javadoc | 0m 31s | /results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt | hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | javadoc | 0m 24s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 30s | the patch passed | |
| +1 :green_heart: | shadedclient | 39m 33s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 51m 13s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | |
| 187m 4s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/6/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 7977a2f1d4a4 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 82b67dbebacd84001d21ff907bab38b772d10600 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/6/testReport/ |
| Max. process+thread count | 3205 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/6/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 20s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 23m 4s | trunk passed | |
| +1 :green_heart: | compile | 0m 34s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 22s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 21s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 30s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 29s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 20s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 0m 54s | trunk passed | |
| +1 :green_heart: | shadedclient | 20m 1s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 21s | the patch passed | |
| +1 :green_heart: | compile | 0m 30s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 30s | the patch passed | |
| +1 :green_heart: | compile | 0m 19s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 19s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 11s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 48 new + 0 unchanged - 0 fixed = 48 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 23s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 22s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 17s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 0m 53s | the patch passed | |
| +1 :green_heart: | shadedclient | 20m 32s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 50m 35s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | |
| 122m 38s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/9/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux f8f34c40be82 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f1ae3aae740429cbd73a2a6c73b20938e2f717ac |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/9/testReport/ |
| Max. process+thread count | 5088 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/9/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 1s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 1s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 38m 36s | trunk passed | |
| +1 :green_heart: | compile | 1m 4s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 40s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 31s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 47s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 42s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 33s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 28s | trunk passed | |
| +1 :green_heart: | shadedclient | 36m 39s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 34s | the patch passed | |
| +1 :green_heart: | compile | 0m 56s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 56s | the patch passed | |
| +1 :green_heart: | compile | 0m 34s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 34s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 21s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 48 new + 0 unchanged - 0 fixed = 48 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 36s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 30s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 25s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 28s | the patch passed | |
| +1 :green_heart: | shadedclient | 35m 48s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 49m 45s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. | |
| 174m 45s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/7/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 72654b9b9f0f 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 2ee6269b82c9d9e8ef7b54b343d5999218b3510d |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/7/testReport/ |
| Max. process+thread count | 3356 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/7/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 37m 36s | trunk passed | |
| +1 :green_heart: | compile | 1m 6s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 42s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 33s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 47s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 43s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 34s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 31s | trunk passed | |
| +1 :green_heart: | shadedclient | 45m 10s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 37s | the patch passed | |
| +1 :green_heart: | compile | 1m 3s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 1m 3s | the patch passed | |
| +1 :green_heart: | compile | 0m 32s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 32s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 20s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 48 new + 0 unchanged - 0 fixed = 48 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 36s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 30s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 25s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 30s | the patch passed | |
| +1 :green_heart: | shadedclient | 34m 57s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 52m 22s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | |
| 184m 22s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/8/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 2862174a250f 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f1ae3aae740429cbd73a2a6c73b20938e2f717ac |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/8/testReport/ |
| Max. process+thread count | 3181 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/8/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 1s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 1s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 39m 14s | trunk passed | |
| +1 :green_heart: | compile | 1m 2s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 39s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 31s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 46s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 40s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 32s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 30s | trunk passed | |
| +1 :green_heart: | shadedclient | 36m 54s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 34s | the patch passed | |
| +1 :green_heart: | compile | 0m 57s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 57s | the patch passed | |
| +1 :green_heart: | compile | 0m 32s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 32s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 19s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 48 new + 0 unchanged - 0 fixed = 48 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 36s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 29s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 24s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 27s | the patch passed | |
| +1 :green_heart: | shadedclient | 37m 35s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| -1 :x: | unit | 61m 32s | /patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-rbf in the patch passed. |
| +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. | |
| 189m 0s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/10/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 0446d86649dc 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / afeab770fedd6e8bc855cb075bca713cc2ca497e |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/10/testReport/ |
| Max. process+thread count | 3772 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/10/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
or create two long-lived HDFS mini clusters with the configs, and have the test cases choose which to use based on the parameters
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 1s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 1s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 35m 40s | trunk passed | |
| +1 :green_heart: | compile | 1m 6s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 40s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 33s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 48s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 45s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 33s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 32s | trunk passed | |
| +1 :green_heart: | shadedclient | 34m 47s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 36s | the patch passed | |
| +1 :green_heart: | compile | 0m 58s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 0m 58s | the patch passed | |
| +1 :green_heart: | compile | 0m 33s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 33s | the patch passed | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| +1 :green_heart: | checkstyle | 0m 21s | the patch passed | |
| +1 :green_heart: | mvnsite | 0m 37s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 28s | the patch passed | |
| +1 :green_heart: | shadedclient | 34m 24s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 42m 15s | hadoop-hdfs-rbf in the patch passed. | |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. | |
| 161m 21s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/11/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 7a81330f66c2 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 0a1c5672e29b67f303388965c1115c5a44ee5ea9 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/11/testReport/ |
| Max. process+thread count | 2916 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/11/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
or create two long-lived HDFS mini clusters with the configs, and have the test cases choose which to use based on the parameters
@steveloughran Sir, thanks for your advice. I will give an example soonly and then let's choose one way.
@hfutatzhanghb Thank you very much for your contribution! From my personal perspective, the code in this version meets expectations. However, we still need to gather feedback from other members. I will provide more specific suggestions later this week.
if @slfan1989 is happy, so am I. I don't know hdfs well enough to review things there, at least not enough to merge things
Thanks @slfan1989 and @steveloughran , i will start develope this PR after HDFS-17749 merged~
Hi, @slfan1989 @KeeProMise @Hexiaoqiao . I wonder that whether should we split this PR or not ? If all in one, it would be unfriendly for reivewing. What's your opinions?
Hi, @slfan1989 @KeeProMise @Hexiaoqiao . I wonder that whether should we split this PR or not ? If all in one, it would be unfriendly for reivewing. What's your opinions?
@hfutatzhanghb Thank you for the information! I think we should first focus on updating all the unit tests in a single pr, and then consider splitting the changes into multiple prs afterward.
I believe a single PR should not exceed 3000 lines or affect more than 50 classes. Since we're only improving unit tests and not modifying core logic, the review effort should be manageable.
Hi, @slfan1989 @KeeProMise @Hexiaoqiao . I wonder that whether should we split this PR or not ? If all in one, it would be unfriendly for reivewing. What's your opinions?
@hfutatzhanghb Thank you for the information! I think we should first focus on updating all the unit tests in a single pr, and then consider splitting the changes into multiple prs afterward.
I believe a single PR should not exceed 3000 lines or affect more than 50 classes. Since we're only improving unit tests and not modifying core logic, the review effort should be manageable.
Got it, Thanks again!
Hi, @slfan1989 @KeeProMise @Hexiaoqiao . I wonder that whether should we split this PR or not ? If all in one, it would be unfriendly for reivewing. What's your opinions?
@hfutatzhanghb Thank you for the information! I think we should first focus on updating all the unit tests in a single pr, and then consider splitting the changes into multiple prs afterward.
I believe a single PR should not exceed 3000 lines or affect more than 50 classes. Since we're only improving unit tests and not modifying core logic, the review effort should be manageable.
+1
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 14m 7s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 6 new or modified test files. | |
| _ trunk Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 36m 2s | trunk passed | |
| +1 :green_heart: | compile | 1m 8s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | compile | 0m 44s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | checkstyle | 0m 34s | trunk passed | |
| +1 :green_heart: | mvnsite | 0m 49s | trunk passed | |
| +1 :green_heart: | javadoc | 0m 44s | trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 34s | trunk passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 32s | trunk passed | |
| +1 :green_heart: | shadedclient | 34m 11s | branch has no errors when building and testing our client artifacts. | |
| _ Patch Compile Tests _ | ||||
| +1 :green_heart: | mvninstall | 0m 37s | the patch passed | |
| +1 :green_heart: | compile | 1m 1s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javac | 1m 1s | the patch passed | |
| +1 :green_heart: | compile | 0m 33s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | javac | 0m 33s | the patch passed | |
| -1 :x: | blanks | 0m 0s | /blanks-eol.txt | The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -0 :warning: | checkstyle | 0m 19s | /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt | hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 37s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 | |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 | |
| +1 :green_heart: | spotbugs | 1m 28s | the patch passed | |
| +1 :green_heart: | shadedclient | 34m 20s | patch has no errors when building and testing our client artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 43m 20s | hadoop-hdfs-rbf in the patch passed. | |
| -1 :x: | asflicense | 0m 39s | /results-asflicense.txt | The patch generated 1 ASF License warnings. |
| 175m 52s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/12/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7470 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 531b32c7528a 5.15.0-134-generic #145-Ubuntu SMP Wed Feb 12 20:08:39 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / bd02510e9eef06db8768d999de874487e425b5c6 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/12/testReport/ |
| Max. process+thread count | 2817 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7470/12/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.