hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HADOOP-19201 S3A. Support external-id in assume role

Open Smith-Cruise opened this issue 1 year ago • 3 comments

Description of PR

Support external id in AssumedRoleCredentialProvider.java

https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html

How was this patch tested?

tested in my env

For code changes:

  • [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Smith-Cruise avatar Jun 08 '24 13:06 Smith-Cruise

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 31m 55s trunk passed
+1 :green_heart: compile 0m 23s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: compile 0m 23s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: checkstyle 0m 21s trunk passed
+1 :green_heart: mvnsite 0m 24s trunk passed
+1 :green_heart: javadoc 0m 21s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javadoc 0m 24s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: spotbugs 0m 48s trunk passed
+1 :green_heart: shadedclient 20m 22s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 18s the patch passed
+1 :green_heart: compile 0m 21s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javac 0m 21s the patch passed
+1 :green_heart: compile 0m 19s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: javac 0m 19s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 12s the patch passed
+1 :green_heart: mvnsite 0m 21s the patch passed
+1 :green_heart: javadoc 0m 10s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javadoc 0m 17s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: spotbugs 0m 41s the patch passed
+1 :green_heart: shadedclient 19m 49s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 25s hadoop-aws in the patch passed.
+1 :green_heart: asflicense 0m 24s The patch does not generate ASF License warnings.
81m 51s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6876
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux d89ad20b4705 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e17cdabea2dd5523ef6a6104b474fb58296a32cb
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/1/testReport/
Max. process+thread count 551 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jun 08 '24 15:06 hadoop-yetus

I didn't know about this -yes, it could be potentially useful

  • the docs need updating too
  • our delegation token support, where credentials get passed with a job, will also need this: org.apache.hadoop.fs.s3a.auth.delegation.RoleTokenBinding
  • And ideally, a way of explicitly adding a test in our assumed role tests -even if it is something we need to manually set up (e.g. we set the constraint in the role we assume for those tests and verify things work if set, fail if a wrong one is set.

Now, first step to testing: look at the test policy. You have to run all the s3 tests against a S3 store of your choice, and as you are doing things with roles, that must include the assumed role suites. Once you've done that, tell us where and then it's time to work on the test design -which we can help with.

https://hadoop.apache.org/docs/stable/hadoop-aws/tools/hadoop-aws/testing.html

steveloughran avatar Jun 10 '24 13:06 steveloughran

I didn't know about this -yes, it could be potentially useful

  • the docs need updating too
  • our delegation token support, where credentials get passed with a job, will also need this: org.apache.hadoop.fs.s3a.auth.delegation.RoleTokenBinding
  • And ideally, a way of explicitly adding a test in our assumed role tests -even if it is something we need to manually set up (e.g. we set the constraint in the role we assume for those tests and verify things work if set, fail if a wrong one is set.

Now, first step to testing: look at the test policy. You have to run all the s3 tests against a S3 store of your choice, and as you are doing things with roles, that must include the assumed role suites. Once you've done that, tell us where and then it's time to work on the test design -which we can help with.

https://hadoop.apache.org/docs/stable/hadoop-aws/tools/hadoop-aws/testing.html

Got it. I will do it when i am free.

Smith-Cruise avatar Jun 12 '24 02:06 Smith-Cruise

@Smith-Cruise this isn't going to get into 3.4.1 but if you can pick this up again we can target 3.4.2

steveloughran avatar Aug 29 '24 18:08 steveloughran

tested this. it works

If you can add a mention of this option in hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md

then this is ready to merge. We don't want to add features which are only visible to people who looked at the source code...

steveloughran avatar Aug 29 '24 19:08 steveloughran

tested this. it works

If you can add a mention of this option in hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md

then this is ready to merge. We don't want to add features which are only visible to people who looked at the source code...

OK, I will add it to doc

Smith-Cruise avatar Aug 30 '24 02:08 Smith-Cruise

tested this. it works

If you can add a mention of this option in hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md

then this is ready to merge. We don't want to add features which are only visible to people who looked at the source code...

I've updated the doc, PTAL

Smith-Cruise avatar Aug 30 '24 05:08 Smith-Cruise

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 19s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+0 :ok: markdownlint 0m 0s markdownlint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 :ok: mvndep 15m 2s Maven dependency ordering for branch
+1 :green_heart: mvninstall 20m 17s trunk passed
+1 :green_heart: compile 9m 5s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: compile 8m 12s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: checkstyle 2m 5s trunk passed
+1 :green_heart: mvnsite 1m 40s trunk passed
+1 :green_heart: javadoc 1m 15s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javadoc 1m 11s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: spotbugs 2m 20s trunk passed
+1 :green_heart: shadedclient 20m 49s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 22s Maven dependency ordering for patch
+1 :green_heart: mvninstall 0m 50s the patch passed
+1 :green_heart: compile 8m 35s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javac 8m 35s the patch passed
+1 :green_heart: compile 8m 12s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: javac 8m 12s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 5s the patch passed
+1 :green_heart: mvnsite 1m 40s the patch passed
+1 :green_heart: javadoc 1m 11s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javadoc 1m 5s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: spotbugs 2m 36s the patch passed
+1 :green_heart: shadedclient 21m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 16m 35s hadoop-common in the patch passed.
+1 :green_heart: unit 2m 8s hadoop-aws in the patch passed.
+1 :green_heart: asflicense 0m 43s The patch does not generate ASF License warnings.
152m 8s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6876
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint
uname Linux b01ec6b04c99 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d443ac7d2bd02230b9db3ad1491d4eb0ef8c0673
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/2/testReport/
Max. process+thread count 3109 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 30 '24 07:08 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+0 :ok: markdownlint 0m 1s markdownlint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 23s Maven dependency ordering for branch
+1 :green_heart: mvninstall 19m 54s trunk passed
+1 :green_heart: compile 9m 7s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: compile 8m 16s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: checkstyle 2m 6s trunk passed
+1 :green_heart: mvnsite 1m 37s trunk passed
+1 :green_heart: javadoc 1m 18s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javadoc 1m 8s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: spotbugs 2m 16s trunk passed
+1 :green_heart: shadedclient 20m 47s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 22s Maven dependency ordering for patch
+1 :green_heart: mvninstall 0m 54s the patch passed
+1 :green_heart: compile 8m 43s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javac 8m 43s the patch passed
+1 :green_heart: compile 8m 9s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: javac 8m 9s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 2s the patch passed
+1 :green_heart: mvnsite 1m 32s the patch passed
+1 :green_heart: javadoc 1m 10s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javadoc 1m 9s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: spotbugs 2m 31s the patch passed
+1 :green_heart: shadedclient 21m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 16m 43s hadoop-common in the patch passed.
+1 :green_heart: unit 2m 9s hadoop-aws in the patch passed.
+1 :green_heart: asflicense 0m 42s The patch does not generate ASF License warnings.
151m 22s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6876
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint
uname Linux 18c3a5aaec05 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b4a6ba5553d8db7801f8298188adc1d66d889745
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/3/testReport/
Max. process+thread count 1281 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 30 '24 16:08 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 19s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+0 :ok: markdownlint 0m 1s markdownlint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 30s Maven dependency ordering for branch
+1 :green_heart: mvninstall 20m 2s trunk passed
+1 :green_heart: compile 9m 3s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: compile 8m 14s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: checkstyle 2m 7s trunk passed
+1 :green_heart: mvnsite 1m 40s trunk passed
+1 :green_heart: javadoc 1m 19s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javadoc 1m 11s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: spotbugs 2m 21s trunk passed
+1 :green_heart: shadedclient 21m 24s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 20s Maven dependency ordering for patch
+1 :green_heart: mvninstall 0m 53s the patch passed
+1 :green_heart: compile 8m 45s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javac 8m 45s the patch passed
+1 :green_heart: compile 8m 8s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: javac 8m 8s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 2s the patch passed
+1 :green_heart: mvnsite 1m 31s the patch passed
+1 :green_heart: javadoc 1m 6s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javadoc 1m 6s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: spotbugs 2m 30s the patch passed
+1 :green_heart: shadedclient 21m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 16m 38s hadoop-common in the patch passed.
+1 :green_heart: unit 2m 10s hadoop-aws in the patch passed.
+1 :green_heart: asflicense 0m 43s The patch does not generate ASF License warnings.
152m 7s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6876
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint
uname Linux 1bb6d7542e49 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d68a856ed7e96ca014e12d9080131ed72016375e
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/4/testReport/
Max. process+thread count 3109 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 31 '24 04:08 hadoop-yetus

@steveloughran Can call anyone help to have a review? Thks!

Smith-Cruise avatar Sep 09 '24 12:09 Smith-Cruise

#7021

I'm curious about one thing, If I only tell you which endpoint I tested, how can you verify it? Do I need to provide ak/sk for you?

Smith-Cruise avatar Sep 10 '24 08:09 Smith-Cruise

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 6m 45s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+0 :ok: markdownlint 0m 0s markdownlint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 4s Maven dependency ordering for branch
+1 :green_heart: mvninstall 19m 59s trunk passed
+1 :green_heart: compile 9m 2s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: compile 8m 12s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: checkstyle 2m 6s trunk passed
+1 :green_heart: mvnsite 1m 35s trunk passed
+1 :green_heart: javadoc 1m 27s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javadoc 1m 9s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: spotbugs 2m 20s trunk passed
+1 :green_heart: shadedclient 20m 51s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 21s Maven dependency ordering for patch
+1 :green_heart: mvninstall 0m 53s the patch passed
+1 :green_heart: compile 8m 35s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javac 8m 35s the patch passed
+1 :green_heart: compile 8m 16s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: javac 8m 16s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 6s the patch passed
+1 :green_heart: mvnsite 1m 38s the patch passed
+1 :green_heart: javadoc 1m 17s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 :green_heart: javadoc 1m 9s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 :green_heart: spotbugs 2m 33s the patch passed
+1 :green_heart: shadedclient 20m 48s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 16m 33s hadoop-common in the patch passed.
+1 :green_heart: unit 2m 15s hadoop-aws in the patch passed.
+1 :green_heart: asflicense 0m 42s The patch does not generate ASF License warnings.
157m 15s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/5/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6876
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint
uname Linux 5fedc6b5aa18 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d75fb47ce3a40b0d70059da5f015760c0e62eb09
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/5/testReport/
Max. process+thread count 1273 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6876/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 10 '24 10:09 hadoop-yetus

merged to trunk and 3.4 branches; added the option to my account. lets see if any surprises show up. Though I know that not enough people are running the hadoop-aws test with the assume role options correctly set.

steveloughran avatar Sep 10 '24 16:09 steveloughran

merged to trunk and 3.4 branches; added the option to my account. lets see if any surprises show up. Though I know that not enough people are running the hadoop-aws test with the assume role options correctly set.

Actually, we've already run it in StarRocks project, everything looks OK https://github.com/StarRocks/starrocks/blob/main/fe/fe-core/src/main/java/com/starrocks/credential/provider/AssumedRoleCredentialProvider.java

Smith-Cruise avatar Sep 11 '24 02:09 Smith-Cruise