hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HDFS-17463. Support the switch StringTable Split ID feature

Open XbaoWu opened this issue 1 year ago • 8 comments

Description of PR

Hadoop 3.2 introduced optimization features for HDFS StringTable (b60ca37914b22550e3630fa02742d40697decb3), It resulted in lower versions of Hadoop upgraded to 3.2 and later versions not supporting downgrade operations. Therefore, we have added an optimization to support downgrading. In the upgrade with large version span, it avoids the low version can not read the fs-image generated by the 3.2 and later version, which support for the 3.2 and later version to be downgraded to the low version.

For more information about this PR, please refer to the following issue: HDFS-17463 Support the switch StringTable Split ID feature

How was this patch tested?

add TestSerialFSImage.java

For code changes:

  • [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

XbaoWu avatar Apr 16 '24 07:04 XbaoWu

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 7m 32s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 32m 12s trunk passed
+1 :green_heart: compile 0m 42s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: compile 0m 40s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: checkstyle 0m 39s trunk passed
+1 :green_heart: mvnsite 0m 42s trunk passed
+1 :green_heart: javadoc 0m 43s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 1m 5s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 1m 47s trunk passed
+1 :green_heart: shadedclient 21m 54s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 38s the patch passed
+1 :green_heart: compile 0m 37s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javac 0m 37s the patch passed
+1 :green_heart: compile 0m 37s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: javac 0m 37s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 29s /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 250 unchanged - 2 fixed = 259 total (was 252)
+1 :green_heart: mvnsite 0m 38s the patch passed
+1 :green_heart: javadoc 0m 29s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 0m 59s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 1m 44s the patch passed
+1 :green_heart: shadedclient 22m 59s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 203m 20s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 32s The patch does not generate ASF License warnings.
302m 51s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestFileContextAcl
hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
hadoop.hdfs.server.namenode.TestAclConfigFlag
hadoop.hdfs.server.namenode.TestNameNodeAcl
hadoop.hdfs.server.namenode.TestFSImageWithAcl
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
hadoop.hdfs.web.TestWebHDFSAcl
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6736
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 72686231164d 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9dbf7538beb1addad796f81a915c874157f812b0
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/1/testReport/
Max. process+thread count 4409 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 16 '24 12:04 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 32m 52s trunk passed
+1 :green_heart: compile 0m 41s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: compile 0m 43s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: checkstyle 0m 40s trunk passed
+1 :green_heart: mvnsite 0m 46s trunk passed
+1 :green_heart: javadoc 0m 42s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 1m 8s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 1m 47s trunk passed
+1 :green_heart: shadedclient 21m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 35s the patch passed
+1 :green_heart: compile 0m 39s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javac 0m 39s the patch passed
+1 :green_heart: compile 0m 37s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: javac 0m 37s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 30s /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 252 unchanged - 0 fixed = 259 total (was 252)
+1 :green_heart: mvnsite 0m 38s the patch passed
+1 :green_heart: javadoc 0m 32s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 1m 0s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 1m 45s the patch passed
+1 :green_heart: shadedclient 21m 45s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 209m 23s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 30s The patch does not generate ASF License warnings.
300m 52s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestFileContextAcl
hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
hadoop.hdfs.server.namenode.TestAclConfigFlag
hadoop.hdfs.server.namenode.TestNameNodeAcl
hadoop.hdfs.server.namenode.TestFSImageWithAcl
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
hadoop.hdfs.web.TestWebHDFSAcl
hadoop.hdfs.server.namenode.TestSerialFSImage
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6736
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux db0a11fc995d 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f78c740a23e1a9d140a56098297642541a6f8343
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/2/testReport/
Max. process+thread count 4077 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 19 '24 14:04 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 :green_heart: dupname 0m 02s No case conflicting files found.
+0 :ok: spotbugs 0m 00s spotbugs executables are not available.
+0 :ok: codespell 0m 00s codespell was not available.
+0 :ok: detsecrets 0m 00s detect-secrets was not available.
+0 :ok: xmllint 0m 00s xmllint was not available.
+1 :green_heart: @author 0m 01s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 87m 03s trunk passed
+1 :green_heart: compile 6m 15s trunk passed
+1 :green_heart: checkstyle 4m 51s trunk passed
+1 :green_heart: mvnsite 6m 42s trunk passed
+1 :green_heart: javadoc 5m 59s trunk passed
+1 :green_heart: shadedclient 150m 12s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 38s the patch passed
+1 :green_heart: compile 3m 33s the patch passed
+1 :green_heart: javac 3m 34s the patch passed
+1 :green_heart: blanks 0m 00s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 24s the patch passed
+1 :green_heart: mvnsite 4m 13s the patch passed
+1 :green_heart: javadoc 4m 23s the patch passed
+1 :green_heart: shadedclient 164m 04s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: asflicense 5m 55s The patch does not generate ASF License warnings.
429m 35s
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hadoop/pull/6736
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname MINGW64_NT-10.0-17763 263e1c7dd5ce 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / f78c740a23e1a9d140a56098297642541a6f8343
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6736/1/testReport/
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6736/1/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 23 '24 16:04 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 7m 34s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 33m 3s trunk passed
+1 :green_heart: compile 0m 40s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: compile 0m 39s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: checkstyle 0m 39s trunk passed
+1 :green_heart: mvnsite 0m 47s trunk passed
+1 :green_heart: javadoc 0m 42s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 1m 3s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 1m 43s trunk passed
+1 :green_heart: shadedclient 21m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 35s the patch passed
+1 :green_heart: compile 0m 38s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javac 0m 38s the patch passed
+1 :green_heart: compile 0m 36s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: javac 0m 36s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 31s the patch passed
+1 :green_heart: mvnsite 0m 36s the patch passed
+1 :green_heart: javadoc 0m 31s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 0m 59s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 1m 47s the patch passed
+1 :green_heart: shadedclient 21m 19s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 210m 20s hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 31s The patch does not generate ASF License warnings.
307m 43s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6736
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux d39cd7a88ad5 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 8399f99ae05faafbd8e272ca638038b8806ec94f
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/3/testReport/
Max. process+thread count 4366 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 23 '24 18:04 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 49m 52s trunk passed
+1 :green_heart: compile 1m 24s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: compile 1m 14s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: checkstyle 1m 13s trunk passed
+1 :green_heart: mvnsite 1m 21s trunk passed
+1 :green_heart: javadoc 1m 9s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 1m 42s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 3m 17s trunk passed
+1 :green_heart: shadedclient 40m 53s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 11s the patch passed
+1 :green_heart: compile 1m 15s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javac 1m 15s the patch passed
+1 :green_heart: compile 1m 9s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: javac 1m 9s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 4s the patch passed
+1 :green_heart: mvnsite 1m 13s the patch passed
+1 :green_heart: javadoc 0m 55s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 1m 35s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 3m 17s the patch passed
+1 :green_heart: shadedclient 41m 49s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 274m 42s hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 43s The patch does not generate ASF License warnings.
432m 38s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6736
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 38640423e977 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d4197ab0fab16d60037594b06089181b8db46467
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/4/testReport/
Max. process+thread count 2639 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6736/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 25 '24 11:04 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 :green_heart: dupname 0m 01s No case conflicting files found.
+0 :ok: spotbugs 0m 01s spotbugs executables are not available.
+0 :ok: codespell 0m 01s codespell was not available.
+0 :ok: detsecrets 0m 01s detect-secrets was not available.
+0 :ok: xmllint 0m 01s xmllint was not available.
+1 :green_heart: @author 0m 00s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 86m 09s trunk passed
+1 :green_heart: compile 5m 49s trunk passed
+1 :green_heart: checkstyle 4m 50s trunk passed
+1 :green_heart: mvnsite 6m 17s trunk passed
+1 :green_heart: javadoc 5m 44s trunk passed
+1 :green_heart: shadedclient 141m 30s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 20s the patch passed
+1 :green_heart: compile 3m 19s the patch passed
+1 :green_heart: javac 3m 19s the patch passed
+1 :green_heart: blanks 0m 00s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 22s the patch passed
+1 :green_heart: mvnsite 4m 02s the patch passed
+1 :green_heart: javadoc 3m 20s the patch passed
+1 :green_heart: shadedclient 154m 16s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: asflicense 6m 02s The patch does not generate ASF License warnings.
408m 47s
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hadoop/pull/6736
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname MINGW64_NT-10.0-17763 6b971c86bc4b 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / d4197ab0fab16d60037594b06089181b8db46467
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6736/4/testReport/
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6736/4/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 29 '24 12:04 hadoop-yetus

@XbaoWu @hiwangzhihui Thanks for your works. I prefer to push this feature into tool module. a. I totally agree that fsimage is not compatible with all versions (include some segment format, parellel loading etc) especially with some old verions, but some end users could need it. b. However after traverse all active branches, it shows all of them are keeping the same format now. c. Even this feature is ready online now, if you meet the compatible issues about fsimage, you need to restart NameNode to generate another new one, so I think fsimage tools could be more convenient. What do you think about?

Hexiaoqiao avatar Apr 29 '24 12:04 Hexiaoqiao

@Hexiaoqiao I agree with your propose , We will proceed with work for it. Thank you for your guide.

hiwangzhihui avatar May 13 '24 06:05 hiwangzhihui

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again. Thanks all for your contribution.

github-actions[bot] avatar Sep 28 '25 00:09 github-actions[bot]