hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

MAPREDUCE-7465: Parallelize file moves in FileOutputCommitter

Open steveloughran opened this issue 1 year ago • 1 comments

Description of PR

Alternate implement to #6378

Contributed by Rajesh Balamohan.

How was this patch tested?

Not tested this cherrypick from cdh to hadoop trunk; no intent to merge. just putting up to say "this was our interim fix before the manifest committer was complete". note that it was this work which helped identify the abfs rename scale issues.

For code changes:

  • [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

steveloughran avatar Jan 01 '24 19:01 steveloughran

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 1s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 35s Maven dependency ordering for branch
+1 :green_heart: mvninstall 31m 2s trunk passed
+1 :green_heart: compile 1m 39s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 1m 32s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: checkstyle 1m 10s trunk passed
+1 :green_heart: mvnsite 1m 19s trunk passed
+1 :green_heart: javadoc 1m 2s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 55s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: spotbugs 2m 6s trunk passed
+1 :green_heart: shadedclient 32m 11s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 31s Maven dependency ordering for patch
-1 :x: mvninstall 0m 19s /patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt hadoop-mapreduce-client-core in the patch failed.
-1 :x: mvninstall 0m 23s /patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt hadoop-mapreduce-client-jobclient in the patch failed.
-1 :x: compile 0m 19s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.txt hadoop-mapreduce-client in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.
-1 :x: javac 0m 19s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.txt hadoop-mapreduce-client in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.
-1 :x: compile 0m 19s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkPrivateBuild-1.8.0_392-8u392-ga-1~20.04-b08.txt hadoop-mapreduce-client in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08.
-1 :x: javac 0m 19s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkPrivateBuild-1.8.0_392-8u392-ga-1~20.04-b08.txt hadoop-mapreduce-client in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 1m 0s /results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 15 new + 38 unchanged - 0 fixed = 53 total (was 38)
-1 :x: mvnsite 0m 20s /patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt hadoop-mapreduce-client-core in the patch failed.
-1 :x: mvnsite 0m 23s /patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt hadoop-mapreduce-client-jobclient in the patch failed.
-1 :x: javadoc 0m 19s /patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.txt hadoop-mapreduce-client-core in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.
-1 :x: javadoc 0m 18s /patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdkPrivateBuild-1.8.0_392-8u392-ga-1~20.04-b08.txt hadoop-mapreduce-client-core in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08.
-1 :x: spotbugs 0m 18s /patch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt hadoop-mapreduce-client-core in the patch failed.
-1 :x: spotbugs 0m 23s /patch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt hadoop-mapreduce-client-jobclient in the patch failed.
-1 :x: shadedclient 14m 38s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 0m 21s /patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt hadoop-mapreduce-client-core in the patch failed.
-1 :x: unit 0m 25s /patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt hadoop-mapreduce-client-jobclient in the patch failed.
+1 :green_heart: asflicense 0m 35s The patch does not generate ASF License warnings.
108m 36s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6399/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6399
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 064d3d53fa22 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2a53373fe772b8b96c3cc69aab913db508764c27
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6399/1/testReport/
Max. process+thread count 560 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6399/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jan 01 '24 21:01 hadoop-yetus