hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HADOOP-19005. Upgrade Guava to 32.0.1 due to CVE-2023-2976.

Open eshwitha opened this issue 2 years ago • 8 comments

Description of PR

Upgrade Guava to 32.0.1 due to CVE-2023-2976.

How was this patch tested?

For code changes:

  • [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

eshwitha avatar Dec 11 '23 17:12 eshwitha

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 23s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 34m 36s trunk passed
+1 :green_heart: compile 0m 13s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 0m 11s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: mvnsite 0m 16s trunk passed
+1 :green_heart: javadoc 0m 16s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 15s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: shadedclient 57m 56s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 11s the patch passed
+1 :green_heart: compile 0m 10s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 0m 10s the patch passed
+1 :green_heart: compile 0m 8s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: javac 0m 8s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: mvnsite 0m 11s the patch passed
+1 :green_heart: javadoc 0m 10s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 11s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: shadedclient 20m 51s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 0m 11s hadoop-project in the patch passed.
+1 :green_heart: asflicense 0m 22s The patch does not generate ASF License warnings.
82m 50s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6344/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6344
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 9fa44ef42b82 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 17fdabb04e19b1b6468be9a6b7c15423f88855a4
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6344/1/testReport/
Max. process+thread count 554 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6344/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Dec 11 '23 18:12 hadoop-yetus

If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

can you do this. thanks

steveloughran avatar Dec 12 '23 16:12 steveloughran

Updated the changes, please review @steveloughran Thanks.

eshwitha avatar Dec 15 '23 18:12 eshwitha

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+0 :ok: shelldocs 0m 0s Shelldocs was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 33s Maven dependency ordering for branch
+1 :green_heart: mvninstall 36m 4s trunk passed
+1 :green_heart: compile 18m 2s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 16m 30s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: mvnsite 19m 31s trunk passed
+1 :green_heart: javadoc 8m 52s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 7m 31s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: shadedclient 53m 7s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 33s Maven dependency ordering for patch
+1 :green_heart: mvninstall 33m 54s the patch passed
+1 :green_heart: compile 17m 28s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 17m 28s the patch passed
+1 :green_heart: compile 16m 33s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: javac 16m 33s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: mvnsite 14m 55s the patch passed
+1 :green_heart: shellcheck 0m 0s No new issues.
+1 :green_heart: javadoc 8m 41s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 7m 32s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: shadedclient 54m 21s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 788m 57s /patch-unit-root.txt root in the patch passed.
+1 :green_heart: asflicense 1m 27s The patch does not generate ASF License warnings.
1092m 1s
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6344/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6344
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 6c44ccb80602 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 90b7d7abd2305adf91cd1a77ab904e4db0c656c3
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6344/2/testReport/
Max. process+thread count 2253 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6344/2/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Dec 16 '23 12:12 hadoop-yetus

I'm on vacation until 2024. Sorry. (From my phone, not a laptop)

steveloughran avatar Dec 18 '23 09:12 steveloughran

Please review @steveloughran, Thanks

eshwitha avatar Mar 14 '24 15:03 eshwitha

can you do a rebase and then a forced push? that'll kick off another build and test

Internally we always use our hadoop thirdparty guava jar, this change will not directly cause problems.

This declaration is for things we pull down, so we should get another test run in.

we can't test downstream -we just have to see what breaks.

steveloughran avatar Apr 04 '24 12:04 steveloughran

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 0s Docker mode activated.
-1 :x: docker 0m 10s Docker failed to build run-specific yetus/hadoop:tp-18722}.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hadoop/pull/6344
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6344/3/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jul 24 '24 07:07 hadoop-yetus

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again. Thanks all for your contribution.

github-actions[bot] avatar Oct 07 '25 00:10 github-actions[bot]