hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HADOOP-18492: upgrade commons-text to 1.10.0

Open pjfanning opened this issue 2 years ago • 2 comments

Description of PR

How was this patch tested?

For code changes:

  • [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

pjfanning avatar Oct 12 '22 14:10 pjfanning

+1 LGTM, jenkins pending

that's a bit optimistic for any dependency change. they always look good until the builds/tests run

steveloughran avatar Oct 12 '22 17:10 steveloughran

+1 LGTM, jenkins pending

that's a bit optimistic for any dependency change. they always look good until the builds/tests run

Can't agree more :)

ashutoshcipher avatar Oct 12 '22 17:10 ashutoshcipher

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 1m 13s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+0 :ok: shelldocs 0m 1s Shelldocs was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 :ok: mvndep 15m 20s Maven dependency ordering for branch
+1 :green_heart: mvninstall 28m 39s trunk passed
+1 :green_heart: compile 26m 11s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 22m 23s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: mvnsite 20m 39s trunk passed
+1 :green_heart: javadoc 8m 43s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 7m 28s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: shadedclient 38m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 33s Maven dependency ordering for patch
+1 :green_heart: mvninstall 25m 17s the patch passed
+1 :green_heart: compile 24m 57s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 24m 57s the patch passed
+1 :green_heart: compile 22m 15s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 22m 15s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: mvnsite 20m 15s the patch passed
+1 :green_heart: shellcheck 0m 0s No new issues.
+1 :green_heart: javadoc 8m 22s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 7m 25s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: shadedclient 39m 51s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 1036m 49s root in the patch passed.
+1 :green_heart: asflicense 2m 41s The patch does not generate ASF License warnings.
1329m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5007/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/5007
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 27998e6f7e3f 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / fc34b37566b0dd9c5a62492433f94113a93ac81c
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5007/1/testReport/
Max. process+thread count 3344 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5007/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Oct 13 '22 12:10 hadoop-yetus

@ashutoshcipher CI build seems to have run ok

pjfanning avatar Oct 13 '22 12:10 pjfanning

@ashutoshcipher CI build seems to have run ok

Yeah, Looks good.

ashutoshcipher avatar Oct 13 '22 12:10 ashutoshcipher

Just committed #5037 (which is seem as this PR) to trunk and mark 'Contributed by PJ Fanning'. Thanks all for your reviews.

Hexiaoqiao avatar Oct 18 '22 03:10 Hexiaoqiao