HADOOP-18481. Don't warn on EnvironmentCredentialsProvider.

[ahmarsuhail]

Description of PR

JIRA

This PR prevents logging of V1 Credential provider warning for EnvironmentCredentialsProvider.

How was this patch tested?

Ran an integration test, checked what's logged. No warning logged for EnvironmentCredentialsProvider, warning logged when I set cred provider as com.amazonaws.auth.InstanceProfileCredentialsProvider

[hadoop-yetus]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 45s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
-1 :x:	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 :green_heart:	mvninstall	40m 50s		trunk passed
+1 :green_heart:	compile	0m 58s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	compile	0m 45s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart:	checkstyle	0m 43s		trunk passed
+1 :green_heart:	mvnsite	0m 55s		trunk passed
+1 :green_heart:	javadoc	0m 39s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javadoc	0m 42s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart:	spotbugs	1m 30s		trunk passed
+1 :green_heart:	shadedclient	21m 50s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	0m 38s		the patch passed
+1 :green_heart:	compile	0m 41s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javac	0m 41s		the patch passed
+1 :green_heart:	compile	0m 37s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart:	javac	0m 37s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 27s		the patch passed
+1 :green_heart:	mvnsite	0m 42s		the patch passed
+1 :green_heart:	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javadoc	0m 31s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart:	spotbugs	1m 12s		the patch passed
+1 :green_heart:	shadedclient	20m 38s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 :green_heart:	unit	2m 39s		hadoop-aws in the patch passed.
+1 :green_heart:	asflicense	0m 45s		The patch does not generate ASF License warnings.
		99m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4973/1/artifact/out/Dockerfile
GITHUB PR	https://github.com/apache/hadoop/pull/4973
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 197de77f960a 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 35c78b998c1203a02d818bb219adaade5b3a5c72
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4973/1/testReport/
Max. process+thread count	558 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4973/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[ahmarsuhail]

@steveloughran could you please review? I'll then pick up testing for https://github.com/apache/hadoop/pull/4698 (prerequisites for upgrading to V2) against branch-3.3.

[ahmarsuhail]

thanks @steveloughran, have added EC2ContainerCredentialsProviderWrapper and InstanceProfileCredentialsProvider

[hadoop-yetus]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 1s		codespell was not available.
+0 :ok:	detsecrets	0m 1s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
-1 :x:	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 :green_heart:	mvninstall	40m 56s		trunk passed
+1 :green_heart:	compile	0m 55s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	compile	0m 48s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart:	checkstyle	0m 45s		trunk passed
+1 :green_heart:	mvnsite	0m 59s		trunk passed
+1 :green_heart:	javadoc	0m 41s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javadoc	0m 40s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart:	spotbugs	1m 28s		trunk passed
+1 :green_heart:	shadedclient	23m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	0m 42s		the patch passed
+1 :green_heart:	compile	0m 42s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javac	0m 42s		the patch passed
+1 :green_heart:	compile	0m 35s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart:	javac	0m 35s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	0m 24s		the patch passed
+1 :green_heart:	mvnsite	0m 40s		the patch passed
+1 :green_heart:	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart:	javadoc	0m 29s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart:	spotbugs	1m 16s		the patch passed
+1 :green_heart:	shadedclient	20m 39s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 :green_heart:	unit	2m 38s		hadoop-aws in the patch passed.
+1 :green_heart:	asflicense	0m 41s		The patch does not generate ASF License warnings.
		101m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4973/2/artifact/out/Dockerfile
GITHUB PR	https://github.com/apache/hadoop/pull/4973
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 00d9d8c2ca79 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 192d039bb21c7a653602f71a88177af63146af02
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4973/2/testReport/
Max. process+thread count	562 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4973/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[steveloughran]

and you tested it against an s3 store again, right?

[ahmarsuhail]

Yes, sorry should have mentioned! Tested by setting fs.s3a.aws.credentials.provider to com.amazonaws.auth.AWSStaticCredentialsProvider, and ran an Integration test (ITestPrefetchingInputStream) which logs warning. Then tested with com.amazonaws.auth.EnvironmentVariableCredentialsProvider, com.amazonaws.auth.EC2ContainerCredentialsProviderWrapper and com.amazonaws.auth.InstanceProfileCredentialsProvider which do not log warning.

[steveloughran]

merged to trunk; will backport