hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

[Testing] Upgrade hadolint to 2.10.0

Open GauthamBanasandra opened this issue 2 years ago • 6 comments

  • The current version of hadolint (1.11.1) is only suitable for linting Linux commands in Dockerfile. It fails to recognize Windows command syntax.
  • HADOOP-18133 adds Dockerfile for Windows. Thus, it's essential to upgrade hadolint to 2.10.0 which has the ability to recognize Windows command syntax.

Description of PR

How was this patch tested?

For code changes:

  • [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

GauthamBanasandra avatar Sep 29 '22 06:09 GauthamBanasandra

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/1/console in case of problems.

hadoop-yetus avatar Sep 29 '22 06:09 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 53m 4s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: yamllint 0m 0s yamllint was not available.
+0 :ok: hadolint 0m 0s hadolint was not available.
+0 :ok: shellcheck 0m 0s Shellcheck was not available.
+0 :ok: shelldocs 0m 0s Shelldocs was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 15m 50s Maven dependency ordering for branch
+1 :green_heart: mvninstall 34m 59s trunk passed
+1 :green_heart: mvnsite 22m 28s trunk passed
+1 :green_heart: shadedclient 96m 18s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 30s Maven dependency ordering for patch
+1 :green_heart: mvninstall 27m 15s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: mvnsite 20m 59s the patch passed
+1 :green_heart: shadedclient 43m 53s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 24m 26s root in the patch passed.
+1 :green_heart: asflicense 1m 14s The patch does not generate ASF License warnings.
248m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4950
Optional Tests dupname asflicense codespell detsecrets yamllint hadolint shellcheck shelldocs mvnsite unit shadedclient
uname Linux 5f3de747c9ed 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1750ea072e5abc66cc71430f09eeb66c8ba11f0a
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/1/testReport/
Max. process+thread count 529 (vs. ulimit of 5500)
modules C: hadoop-client-modules/hadoop-client-check-invariants . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/1/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 29 '22 10:09 hadoop-yetus

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/1/console in case of problems.

hadoop-yetus avatar Sep 29 '22 10:09 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 26m 37s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: yamllint 0m 0s yamllint was not available.
+0 :ok: hadolint 0m 0s hadolint was not available.
+0 :ok: shellcheck 0m 0s Shellcheck was not available.
+0 :ok: shelldocs 0m 0s Shelldocs was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 0m 39s Maven dependency ordering for branch
+1 :green_heart: mvninstall 26m 15s trunk passed
-1 :x: mvnsite 9m 1s /branch-mvnsite-root.txt root in trunk failed.
+1 :green_heart: shadedclient 62m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 37s Maven dependency ordering for patch
+1 :green_heart: mvninstall 25m 57s the patch passed
+1 :green_heart: blanks 0m 1s The patch has no blanks issues.
-1 :x: mvnsite 6m 59s /patch-mvnsite-root.txt root in the patch failed.
+1 :green_heart: shadedclient 29m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 22m 3s root in the patch passed.
+1 :green_heart: asflicense 1m 28s The patch does not generate ASF License warnings.
170m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4950
Optional Tests dupname asflicense codespell detsecrets yamllint hadolint shellcheck shelldocs mvnsite unit shadedclient
uname Linux c8e1c3153dd5 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1750ea072e5abc66cc71430f09eeb66c8ba11f0a
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/1/testReport/
Max. process+thread count 531 (vs. ulimit of 5500)
modules C: hadoop-client-modules/hadoop-client-check-invariants . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/1/console
versions git=2.27.0 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 29 '22 13:09 hadoop-yetus

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/3/console in case of problems.

hadoop-yetus avatar Sep 29 '22 14:09 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 19m 56s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: yamllint 0m 0s yamllint was not available.
+0 :ok: shellcheck 0m 0s Shellcheck was not available.
+0 :ok: shelldocs 0m 0s Shelldocs was not available.
+0 :ok: hadolint 0m 0s hadolint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 20m 16s Maven dependency ordering for branch
+1 :green_heart: mvninstall 32m 35s trunk passed
-1 :x: mvnsite 7m 29s /branch-mvnsite-root.txt root in trunk failed.
+1 :green_heart: shadedclient 82m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 38s Maven dependency ordering for patch
+1 :green_heart: mvninstall 26m 23s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-1 :x: mvnsite 6m 59s /patch-mvnsite-root.txt root in the patch failed.
+1 :green_heart: shadedclient 29m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 22m 1s root in the patch passed.
+1 :green_heart: asflicense 1m 32s The patch does not generate ASF License warnings.
184m 29s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4950
Optional Tests dupname asflicense codespell detsecrets yamllint shellcheck shelldocs hadolint mvnsite unit shadedclient
uname Linux 6047bcfbe6af 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 59854e0c77bc5e2f0068f6f9315bf3d30d66d663
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/3/testReport/
Max. process+thread count 630 (vs. ulimit of 5500)
modules C: hadoop-client-modules/hadoop-client-check-invariants . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4950/3/console
versions git=2.27.0 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 29 '22 17:09 hadoop-yetus