hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HADOOP-18437. Fix type in StartEndTimeBase

Open Samrat002 opened this issue 2 years ago • 3 comments

Description of PR

HADOOP-18437

How was this patch tested?

Typo fix in the code

For code changes:

  • [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Samrat002 avatar Sep 15 '22 17:09 Samrat002

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 39m 25s trunk passed
+1 :green_heart: compile 0m 45s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 0m 43s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 0m 49s trunk passed
+1 :green_heart: mvnsite 0m 51s trunk passed
+1 :green_heart: javadoc 0m 50s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 46s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 1m 23s trunk passed
+1 :green_heart: shadedclient 20m 55s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 35s the patch passed
+1 :green_heart: compile 0m 34s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 0m 34s the patch passed
+1 :green_heart: compile 0m 31s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 0m 31s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 25s the patch passed
+1 :green_heart: mvnsite 0m 36s the patch passed
+1 :green_heart: javadoc 0m 28s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 30s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 1m 9s the patch passed
+1 :green_heart: shadedclient 20m 23s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 8m 52s hadoop-mapreduce-client-app in the patch passed.
+1 :green_heart: asflicense 0m 48s The patch does not generate ASF License warnings.
103m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4894/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4894
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 6a7bc77f0a0c 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 40011ba1f5928f43e226ab1cc3e84b488273581d
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4894/1/testReport/
Max. process+thread count 740 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4894/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Sep 15 '22 19:09 hadoop-yetus

please review this small change

Samrat002 avatar Sep 22 '22 04:09 Samrat002

This looks like a good typo fix to me. I don't see any instance of slowTaskRelativeTresholds elsewhere in the Hadoop code base.

cbaenziger avatar Oct 07 '22 04:10 cbaenziger

Let me move to MapReduce project and change the title

aajisaka avatar Oct 29 '22 19:10 aajisaka

Thank you @Samrat002 for your contribution and thank you @cbaenziger for your review.

aajisaka avatar Oct 29 '22 19:10 aajisaka