hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

Open ashutoshcipher opened this issue 2 years ago • 7 comments

Description of PR

Upgrade JUnit from 4 to 5 in hadoop-yarn-common

JIRA - YARN-6946

For code changes:

  • [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

ashutoshcipher avatar Aug 07 '22 20:08 ashutoshcipher

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 2s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 104 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 41m 29s trunk passed
+1 :green_heart: compile 0m 58s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 0m 53s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 0m 51s trunk passed
+1 :green_heart: mvnsite 0m 57s trunk passed
+1 :green_heart: javadoc 1m 7s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 54s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 2m 5s trunk passed
+1 :green_heart: shadedclient 24m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 45s the patch passed
+1 :green_heart: compile 0m 47s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 :x: javac 0m 47s /results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 5 new + 54 unchanged - 9 fixed = 59 total (was 63)
+1 :green_heart: compile 0m 41s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 0m 41s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 52 unchanged - 4 fixed = 52 total (was 56)
-1 :x: blanks 0m 0s /blanks-eol.txt The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 :warning: checkstyle 0m 32s /results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 122 new + 206 unchanged - 163 fixed = 328 total (was 369)
+1 :green_heart: mvnsite 0m 44s the patch passed
+1 :green_heart: javadoc 0m 43s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 43s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 1m 47s the patch passed
+1 :green_heart: shadedclient 24m 24s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 5m 20s hadoop-yarn-common in the patch passed.
+1 :green_heart: asflicense 0m 42s The patch does not generate ASF License warnings.
112m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4717
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux d6c66865725b 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 54fc62df3b9057ef6f6fd51a38a4a06db87af02f
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/1/testReport/
Max. process+thread count 625 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 07 '22 21:08 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 2s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 104 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 41m 7s trunk passed
+1 :green_heart: compile 1m 3s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 0m 52s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 0m 52s trunk passed
+1 :green_heart: mvnsite 0m 58s trunk passed
+1 :green_heart: javadoc 1m 6s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 57s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 2m 4s trunk passed
+1 :green_heart: shadedclient 24m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 43s the patch passed
+1 :green_heart: compile 0m 47s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javac 0m 47s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 54 unchanged - 9 fixed = 54 total (was 63)
+1 :green_heart: compile 0m 43s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 0m 43s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 52 unchanged - 4 fixed = 52 total (was 56)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 0m 31s /results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 12 new + 198 unchanged - 171 fixed = 210 total (was 369)
+1 :green_heart: mvnsite 0m 44s the patch passed
+1 :green_heart: javadoc 0m 43s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 42s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 1m 51s the patch passed
+1 :green_heart: shadedclient 24m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 5m 20s hadoop-yarn-common in the patch passed.
+1 :green_heart: asflicense 0m 42s The patch does not generate ASF License warnings.
111m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4717
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 4971f4dd1315 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 3a52ab51b957b5cc7f975aa73df95e178d2fbf27
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/2/testReport/
Max. process+thread count 535 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 08 '22 01:08 hadoop-yetus

@ashutoshcipher Thank you very much for your contribution, it is very useful. can you submit it as a subpackage, I feel that the changes are a bit big.

slfan1989 avatar Aug 08 '22 14:08 slfan1989

@ashutoshcipher Thank you very much for your contribution, it is very useful. can you submit it as a subpackage, I feel that the changes are a bit big.

@slfan1989 - Thanks for review and approval. I think its overall one package and we keep it as it. The changes seems be kinda okay not really huge :) May be in further modules - I will try to keep short. Again, Thanks for suggestion.

ashutoshcipher avatar Aug 08 '22 14:08 ashutoshcipher

@aajisaka - Please help in reviewing the PR. Thanks.

ashutoshcipher avatar Aug 30 '22 08:08 ashutoshcipher

@aajisaka - Please help in reviewing the PR. Thanks.

ashutoshcipher avatar Oct 01 '22 17:10 ashutoshcipher

@aajisaka Please help in reviewing the PR. Thank a lot.

ashutoshcipher avatar Oct 09 '22 15:10 ashutoshcipher

Thank you @ashutoshcipher for your patch. I reviewed 57 out of 105 files and now I have no comments. I'll review the rest tomorrow.

aajisaka avatar Nov 07 '22 15:11 aajisaka

Thank you so much @aajisaka

ashutoshcipher avatar Nov 07 '22 15:11 ashutoshcipher

I want to check if there's other YARN modules depend on the test class in hadoop-yarn-common before merging this.

aajisaka avatar Nov 08 '22 08:11 aajisaka

Will trigger jenkins by adding a temp empty line in hadoop-yarn-project/pom.xml to make sure all the YARN tests run fine.

ashutoshcipher avatar Nov 08 '22 09:11 ashutoshcipher

@aajisaka - I am not able trigger jenkins. I dont see any merge conflict as well. Can you please have a look? Thanks.

ashutoshcipher avatar Nov 11 '22 04:11 ashutoshcipher

CONFLICT (content): Merge conflict in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/BasePBImplRecordsTest.java

I could reproduce it. It's related to YARN-11294. Would you rebase it for the latest trunk? I'm not sure why GitHub doesn't complain about it.

aajisaka avatar Nov 14 '22 01:11 aajisaka

Thanks @aajisaka, will do that.

ashutoshcipher avatar Nov 14 '22 02:11 ashutoshcipher

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 2s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: xmllint 0m 1s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 104 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 15m 37s Maven dependency ordering for branch
+1 :green_heart: mvninstall 28m 55s trunk passed
+1 :green_heart: compile 10m 45s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 9m 8s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 2m 4s trunk passed
+1 :green_heart: mvnsite 6m 51s trunk passed
+1 :green_heart: javadoc 4m 23s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 37s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 14m 38s trunk passed
+1 :green_heart: shadedclient 36m 5s branch has no errors when building and testing our client artifacts.
-0 :warning: patch 36m 28s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 25s Maven dependency ordering for patch
+1 :green_heart: mvninstall 5m 31s the patch passed
+1 :green_heart: compile 9m 59s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 9m 59s hadoop-yarn-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 723 unchanged - 9 fixed = 723 total (was 732)
+1 :green_heart: compile 9m 5s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 9m 5s hadoop-yarn-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 0 new + 639 unchanged - 4 fixed = 639 total (was 643)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 1m 51s /results-checkstyle-hadoop-yarn-project.txt hadoop-yarn-project: The patch generated 12 new + 196 unchanged - 171 fixed = 208 total (was 367)
+1 :green_heart: mvnsite 6m 22s the patch passed
+1 :green_heart: javadoc 4m 1s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 28s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 15m 0s the patch passed
+1 :green_heart: shadedclient 35m 59s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 5m 29s hadoop-yarn-common in the patch passed.
-1 :x: unit 251m 19s /patch-unit-hadoop-yarn-project.txt hadoop-yarn-project in the patch passed.
+1 :green_heart: asflicense 1m 13s The patch does not generate ASF License warnings.
462m 13s
Reason Tests
Failed junit tests hadoop.yarn.server.router.webapp.TestFederationWebApp
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/8/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4717
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux bba1cd345083 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 3b21d45f0627dda6fa753bce4fad56a5cfea8799
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/8/testReport/
Max. process+thread count 1751 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project U: hadoop-yarn-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/8/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Nov 14 '22 09:11 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 1m 5s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 2s No case conflicting files found.
+0 :ok: codespell 0m 2s codespell was not available.
+0 :ok: detsecrets 0m 2s detect-secrets was not available.
+0 :ok: xmllint 0m 2s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 104 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 15m 24s Maven dependency ordering for branch
+1 :green_heart: mvninstall 29m 5s trunk passed
+1 :green_heart: compile 11m 3s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 9m 11s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 2m 3s trunk passed
+1 :green_heart: mvnsite 7m 43s trunk passed
+1 :green_heart: javadoc 4m 54s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 4m 8s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 15m 28s trunk passed
+1 :green_heart: shadedclient 35m 4s branch has no errors when building and testing our client artifacts.
-0 :warning: patch 35m 25s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 25s Maven dependency ordering for patch
+1 :green_heart: mvninstall 5m 55s the patch passed
+1 :green_heart: compile 10m 3s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 10m 3s hadoop-yarn-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 723 unchanged - 9 fixed = 723 total (was 732)
+1 :green_heart: compile 9m 4s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 9m 4s hadoop-yarn-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 0 new + 639 unchanged - 4 fixed = 639 total (was 643)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 1m 52s /results-checkstyle-hadoop-yarn-project.txt hadoop-yarn-project: The patch generated 12 new + 196 unchanged - 171 fixed = 208 total (was 367)
+1 :green_heart: mvnsite 7m 5s the patch passed
+1 :green_heart: javadoc 4m 28s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 55s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 15m 54s the patch passed
+1 :green_heart: shadedclient 35m 52s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 5m 29s hadoop-yarn-common in the patch passed.
+1 :green_heart: unit 0m 34s hadoop-yarn-server-router in the patch passed.
+1 :green_heart: unit 243m 24s hadoop-yarn-project in the patch passed.
+1 :green_heart: asflicense 1m 14s The patch does not generate ASF License warnings.
459m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/9/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4717
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 591baf25293d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f5701205dd42f0a6e1f7369a6f4bf8465c82943c
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/9/testReport/
Max. process+thread count 1853 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project U: hadoop-yarn-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/9/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Nov 15 '22 11:11 hadoop-yetus

@aajisaka - Results looks good to me. Can you also check once?

If it looks good to you, I can revert the empty line changes made in this file - hadoop-yarn-project/pom.xml and update the PR.

Thanks.

ashutoshcipher avatar Nov 15 '22 11:11 ashutoshcipher

Thank you @ashutoshcipher The test result looks good to me. Could you revert the empty line change?

aajisaka avatar Nov 21 '22 05:11 aajisaka

Thanks @aajisaka I will revert that

ashutoshcipher avatar Nov 21 '22 05:11 ashutoshcipher

Thank you @ashutoshcipher The test result looks good to me. Could you revert the empty line change?

@aajisaka - Done in my last commit.

ashutoshcipher avatar Nov 21 '22 05:11 ashutoshcipher

Thank you @ashutoshcipher for your contribution and thank you @slfan1989 for your review! Also, thank you for cleaning up bunch of checkstyle issues :)

hadoop-yarn-project: The patch generated 12 new + 196 unchanged - 171 fixed = 208 total (was 367)

aajisaka avatar Nov 21 '22 05:11 aajisaka

Thanks @aajisaka for reviewing and merging.

ashutoshcipher avatar Nov 21 '22 05:11 ashutoshcipher

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 53s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 2s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 104 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 15m 12s Maven dependency ordering for branch
+1 :green_heart: mvninstall 29m 1s trunk passed
+1 :green_heart: compile 10m 41s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 9m 6s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 2m 5s trunk passed
+1 :green_heart: mvnsite 2m 1s trunk passed
+1 :green_heart: javadoc 2m 4s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 55s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 23s trunk passed
+1 :green_heart: shadedclient 24m 23s branch has no errors when building and testing our client artifacts.
-0 :warning: patch 24m 48s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 24s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 8s the patch passed
+1 :green_heart: compile 9m 58s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 9m 58s hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 723 unchanged - 9 fixed = 723 total (was 732)
+1 :green_heart: compile 9m 9s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 9m 9s hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 0 new + 639 unchanged - 4 fixed = 639 total (was 643)
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 1m 54s /results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt hadoop-yarn-project/hadoop-yarn: The patch generated 12 new + 196 unchanged - 171 fixed = 208 total (was 367)
+1 :green_heart: mvnsite 1m 49s the patch passed
+1 :green_heart: javadoc 1m 46s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 41s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 22s the patch passed
+1 :green_heart: shadedclient 24m 33s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 5m 43s hadoop-yarn-common in the patch passed.
+1 :green_heart: unit 0m 49s hadoop-yarn-server-router in the patch passed.
+1 :green_heart: asflicense 1m 2s The patch does not generate ASF License warnings.
168m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/10/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4717
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 2323e162b162 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 01b10139f4af9715cbbda889f708ff26ef46397f
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/10/testReport/
Max. process+thread count 535 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4717/10/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Nov 21 '22 08:11 hadoop-yetus