hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HADOOP-18181. Move prefetch common classes to hadoop common

Open steveloughran opened this issue 2 years ago • 3 comments

This moves the "common" classes for the prefetch code from hadoop-aws to hadoop common under org.apache.hadoop.fs.impl.prefetch

How was this patch tested?

s3 london; all good apart from landsat scale test timeout which i am now seeing everywhere

For code changes:

  • [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

steveloughran avatar Aug 03 '22 16:08 steveloughran

  • @mukund-thakur can you look at this?

steveloughran avatar Aug 03 '22 16:08 steveloughran

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 2s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 43 new or modified test files.
_ feature-HADOOP-18028-s3a-prefetch Compile Tests _
+0 :ok: mvndep 14m 39s Maven dependency ordering for branch
+1 :green_heart: mvninstall 24m 55s feature-HADOOP-18028-s3a-prefetch passed
+1 :green_heart: compile 23m 10s feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 20m 37s feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 4m 30s feature-HADOOP-18028-s3a-prefetch passed
+1 :green_heart: mvnsite 3m 43s feature-HADOOP-18028-s3a-prefetch passed
+1 :green_heart: javadoc 2m 57s feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 2m 40s feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 5m 2s feature-HADOOP-18028-s3a-prefetch passed
+1 :green_heart: shadedclient 22m 34s branch has no errors when building and testing our client artifacts.
-0 :warning: patch 23m 6s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 33s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 46s the patch passed
+1 :green_heart: compile 22m 24s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javac 22m 24s the patch passed
+1 :green_heart: compile 20m 48s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 20m 48s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 4m 16s the patch passed
+1 :green_heart: mvnsite 3m 34s the patch passed
+1 :green_heart: javadoc 2m 52s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 2m 43s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 5m 12s the patch passed
+1 :green_heart: shadedclient 22m 39s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 18m 56s hadoop-common in the patch passed.
+1 :green_heart: unit 3m 27s hadoop-aws in the patch passed.
+1 :green_heart: asflicense 1m 35s The patch does not generate ASF License warnings.
242m 3s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4690/8/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4690
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 4fc7f1caf820 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision feature-HADOOP-18028-s3a-prefetch / 21b53182d8bcca137464a69ffdd564fbbf68649f
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4690/8/testReport/
Max. process+thread count 1251 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4690/8/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 16 '22 15:08 hadoop-yetus

ready for review again @mukund-thakur

steveloughran avatar Aug 16 '22 18:08 steveloughran