hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HADOOP-18345: Enhance client protocol to propagate last seen state IDs for multiple nameservices.

Open simbadzina opened this issue 2 years ago • 13 comments

Description of PR

Enhance client protocol to propagate last seen state IDs for multiple nameservices.

How was this patch tested?

This is a prerequisite for HDFS-13522. There are tests in the that JIRA.

For code changes:

  • [ X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

simbadzina avatar Jul 18 '22 17:07 simbadzina

@ZanderXu do you mind taking a look.

goiri avatar Jul 18 '22 17:07 goiri

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 38m 10s trunk passed
+1 :green_heart: compile 23m 6s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 20m 53s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 48s trunk passed
+1 :green_heart: mvnsite 2m 15s trunk passed
+1 :green_heart: javadoc 1m 50s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 23s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 11s trunk passed
+1 :green_heart: shadedclient 23m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 6s the patch passed
+1 :green_heart: compile 22m 31s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: cc 22m 31s the patch passed
+1 :green_heart: javac 22m 31s the patch passed
+1 :green_heart: compile 21m 0s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: cc 21m 0s the patch passed
+1 :green_heart: javac 21m 0s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 36s hadoop-common-project/hadoop-common: The patch generated 0 new + 164 unchanged - 1 fixed = 164 total (was 165)
+1 :green_heart: mvnsite 2m 11s the patch passed
+1 :green_heart: javadoc 1m 39s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 23s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 9s the patch passed
+1 :green_heart: shadedclient 23m 27s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 18m 49s hadoop-common in the patch passed.
+1 :green_heart: asflicense 1m 36s The patch does not generate ASF License warnings.
217m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4584
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname Linux 3ab3fe6f001f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / dbf82e043059caefecf468731951a1625291d53d
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/1/testReport/
Max. process+thread count 1263 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jul 18 '22 20:07 hadoop-yetus

@simbadzina About "RBF supports Observer Read", it's a hug and helpful project. We'd better discuss the overall implementation plan first, and then start development and code review after reaching an agreement, how?

ZanderXu avatar Jul 18 '22 22:07 ZanderXu

@ZanderXu please take a look at: https://issues.apache.org/jira/browse/HDFS-13522 @simbadzina added a design doc too: https://issues.apache.org/jira/secure/attachment/13046815/observer_reads_in_rbf_proposal_simbadzina_v1.pdf

goiri avatar Jul 18 '22 22:07 goiri

@ZanderXu please take a look at: https://issues.apache.org/jira/browse/HDFS-13522 @simbadzina added a design doc too: https://issues.apache.org/jira/secure/attachment/13046815/observer_reads_in_rbf_proposal_simbadzina_v1.pdf

Copy, sir. I will follow up this feature and push it forward with @simbadzina together.

ZanderXu avatar Jul 19 '22 02:07 ZanderXu

Yes, it should be optional. Thanks for spotting the error. I'll fix that. I'm considering making the field a byte array in the client protocol. Only routers need to parse it.

On Mon, Jul 25, 2022, 16:51 Erik Krogen @.***> wrote:

@.**** commented on this pull request.

In hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto https://github.com/apache/hadoop/pull/4584#discussion_r929398786:

@@ -157,6 +158,7 @@ message RpcResponseHeaderProto { optional bytes clientId = 7; // Globally unique client ID optional sint32 retryCount = 8 [default = -1]; optional int64 stateId = 9; // The last written Global State ID

  • map<string, int64> nameserviceStateIds = 10; // Last seen state IDs for multiple nameservices.

Doesn't this field need to be optional for backwards compatibility?

— Reply to this email directly, view it on GitHub https://github.com/apache/hadoop/pull/4584#discussion_r929398786, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6NI6DC23A4WNI4AARIIW3VV4SBNANCNFSM53457PHA . You are receiving this because you were mentioned.Message ID: @.***>

simbadzina avatar Jul 26 '22 02:07 simbadzina

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 57s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: buf 0m 1s buf was not available.
+0 :ok: buf 0m 1s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 40m 55s trunk passed
+1 :green_heart: compile 25m 9s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 21m 58s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 31s trunk passed
+1 :green_heart: mvnsite 2m 0s trunk passed
+1 :green_heart: javadoc 1m 32s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 5s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 7s trunk passed
+1 :green_heart: shadedclient 26m 10s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 5s the patch passed
+1 :green_heart: compile 24m 22s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: cc 24m 22s the patch passed
+1 :green_heart: javac 24m 22s the patch passed
+1 :green_heart: compile 21m 57s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: cc 21m 57s the patch passed
+1 :green_heart: javac 21m 57s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 27s hadoop-common-project/hadoop-common: The patch generated 0 new + 164 unchanged - 1 fixed = 164 total (was 165)
+1 :green_heart: mvnsite 1m 57s the patch passed
-1 :x: javadoc 1m 22s /results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0)
+1 :green_heart: javadoc 1m 7s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 :x: spotbugs 3m 5s /new-spotbugs-hadoop-common-project_hadoop-common.html hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 :green_heart: shadedclient 26m 23s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 18m 27s hadoop-common in the patch passed.
+1 :green_heart: asflicense 1m 16s The patch does not generate ASF License warnings.
227m 9s
Reason Tests
SpotBugs module:hadoop-common-project/hadoop-common
Class org.apache.hadoop.hdfs.server.federation.router.RouterFederatedState$RouterFederatedStateProto defines non-transient non-serializable instance field namespaceStateIds_ In RouterFederatedState.java:instance field namespaceStateIds_ In RouterFederatedState.java
Useless control flow in org.apache.hadoop.hdfs.server.federation.router.RouterFederatedState$RouterFederatedStateProto$Builder.maybeForceBuilderInitialization() At RouterFederatedState.java: At RouterFederatedState.java:[line 483]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4584
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname Linux 2b55e67b3454 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 92a3e9a54b37237b1c03d92f68d05a76528857f7
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/2/testReport/
Max. process+thread count 1253 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jul 28 '22 01:07 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 1m 14s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: buf 0m 1s buf was not available.
+0 :ok: buf 0m 1s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 39m 24s trunk passed
+1 :green_heart: compile 25m 21s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 23m 4s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 34s trunk passed
+1 :green_heart: mvnsite 2m 3s trunk passed
+1 :green_heart: javadoc 1m 39s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 15s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 9s trunk passed
+1 :green_heart: shadedclient 25m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 9s the patch passed
+1 :green_heart: compile 23m 51s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: cc 23m 51s the patch passed
+1 :green_heart: javac 23m 51s the patch passed
+1 :green_heart: compile 22m 29s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: cc 22m 29s the patch passed
+1 :green_heart: javac 22m 29s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 32s hadoop-common-project/hadoop-common: The patch generated 0 new + 164 unchanged - 1 fixed = 164 total (was 165)
+1 :green_heart: mvnsite 2m 0s the patch passed
-1 :x: javadoc 1m 31s /results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0)
+1 :green_heart: javadoc 1m 16s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 :x: spotbugs 3m 10s /new-spotbugs-hadoop-common-project_hadoop-common.html hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 :green_heart: shadedclient 25m 23s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 18m 58s hadoop-common in the patch passed.
+1 :green_heart: asflicense 1m 36s The patch does not generate ASF License warnings.
227m 51s
Reason Tests
SpotBugs module:hadoop-common-project/hadoop-common
Class org.apache.hadoop.hdfs.server.federation.router.RouterFederatedState$RouterFederatedStateProto defines non-transient non-serializable instance field namespaceStateIds_ In RouterFederatedState.java:instance field namespaceStateIds_ In RouterFederatedState.java
Useless control flow in org.apache.hadoop.hdfs.server.federation.router.RouterFederatedState$RouterFederatedStateProto$Builder.maybeForceBuilderInitialization() At RouterFederatedState.java: At RouterFederatedState.java:[line 483]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4584
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname Linux a4bf34733bd4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ebf23a32eb48eab30a51dd1de9d9e742ad2e1a26
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/3/testReport/
Max. process+thread count 2404 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jul 28 '22 01:07 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 1m 2s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 41m 28s trunk passed
+1 :green_heart: compile 25m 9s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 21m 44s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 31s trunk passed
+1 :green_heart: mvnsite 1m 58s trunk passed
+1 :green_heart: javadoc 1m 31s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 4s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 3s trunk passed
+1 :green_heart: shadedclient 26m 11s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 6s the patch passed
+1 :green_heart: compile 24m 24s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: cc 24m 24s the patch passed
+1 :green_heart: javac 24m 24s the patch passed
+1 :green_heart: compile 21m 45s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: cc 21m 45s the patch passed
+1 :green_heart: javac 21m 45s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 164 unchanged - 1 fixed = 164 total (was 165)
+1 :green_heart: mvnsite 1m 58s the patch passed
+1 :green_heart: javadoc 1m 19s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 5s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 2s the patch passed
+1 :green_heart: shadedclient 26m 9s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 18m 25s hadoop-common in the patch passed.
+1 :green_heart: asflicense 1m 15s The patch does not generate ASF License warnings.
227m 25s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4584
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname Linux 272be5321868 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ecca8e63d55eed9f48803861f111998326586109
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/4/testReport/
Max. process+thread count 1341 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jul 28 '22 06:07 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 37m 56s trunk passed
+1 :green_heart: compile 23m 14s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 20m 45s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 49s trunk passed
+1 :green_heart: mvnsite 2m 13s trunk passed
+1 :green_heart: javadoc 1m 49s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 24s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 14s trunk passed
+1 :green_heart: shadedclient 23m 54s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 :x: mvninstall 0m 42s /patch-mvninstall-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 :x: compile 1m 10s /patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 :x: cc 1m 10s /patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 :x: javac 1m 10s /patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 :x: compile 1m 5s /patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 :x: cc 1m 5s /patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 :x: javac 1m 5s /patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 52s hadoop-common-project/hadoop-common: The patch generated 0 new + 164 unchanged - 1 fixed = 164 total (was 165)
-1 :x: mvnsite 0m 49s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 :green_heart: javadoc 0m 52s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 0m 37s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 :x: spotbugs 0m 44s /patch-spotbugs-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 :x: shadedclient 8m 59s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 0m 46s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 :green_heart: asflicense 0m 38s The patch does not generate ASF License warnings.
128m 14s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/5/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4584
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname Linux d869c7e998de 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 981e17c672926340a1a889388b0dc288ae8275bc
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/5/testReport/
Max. process+thread count 561 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jul 28 '22 07:07 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 41m 22s trunk passed
+1 :green_heart: compile 25m 8s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 21m 52s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 31s trunk passed
+1 :green_heart: mvnsite 1m 59s trunk passed
+1 :green_heart: javadoc 1m 33s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 4s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 5s trunk passed
+1 :green_heart: shadedclient 26m 3s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 1m 5s the patch passed
+1 :green_heart: compile 24m 23s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: cc 24m 23s the patch passed
+1 :green_heart: javac 24m 23s the patch passed
+1 :green_heart: compile 21m 47s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: cc 21m 47s the patch passed
+1 :green_heart: javac 21m 47s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 1m 26s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 7 new + 169 unchanged - 1 fixed = 176 total (was 170)
+1 :green_heart: mvnsite 1m 56s the patch passed
+1 :green_heart: javadoc 1m 22s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 1m 4s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 3m 2s the patch passed
+1 :green_heart: shadedclient 26m 8s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 18m 40s hadoop-common in the patch passed.
+1 :green_heart: asflicense 1m 16s The patch does not generate ASF License warnings.
227m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/6/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4584
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname Linux 8c5c1734376f 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / efd4e35c05faca7985fc7cfccf16fd1475f1a686
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/6/testReport/
Max. process+thread count 1253 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/6/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jul 28 '22 21:07 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+0 :ok: buf 0m 1s buf was not available.
+0 :ok: buf 0m 1s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 15m 30s Maven dependency ordering for branch
+1 :green_heart: mvninstall 25m 38s trunk passed
+1 :green_heart: compile 23m 16s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 20m 46s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 4m 26s trunk passed
+1 :green_heart: mvnsite 3m 45s trunk passed
+1 :green_heart: javadoc 3m 18s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 3m 6s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 5m 15s trunk passed
+1 :green_heart: shadedclient 22m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 33s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 48s the patch passed
+1 :green_heart: compile 22m 28s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: cc 22m 28s the patch passed
+1 :green_heart: javac 22m 28s the patch passed
+1 :green_heart: compile 20m 49s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: cc 20m 49s the patch passed
+1 :green_heart: javac 20m 49s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 4m 13s /results-checkstyle-root.txt root: The patch generated 8 new + 167 unchanged - 1 fixed = 175 total (was 168)
+1 :green_heart: mvnsite 3m 45s the patch passed
+1 :green_heart: javadoc 3m 8s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 3m 11s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 5m 28s the patch passed
+1 :green_heart: shadedclient 22m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 18m 44s hadoop-common in the patch passed.
+1 :green_heart: unit 22m 48s hadoop-hdfs-rbf in the patch passed.
+1 :green_heart: asflicense 1m 37s The patch does not generate ASF License warnings.
264m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/7/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4584
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname Linux bd22356db5f2 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2a76bb5fba6b6d052429c78ba8808d472b75482c
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/7/testReport/
Max. process+thread count 2612 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/7/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 09 '22 21:08 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: buf 0m 0s buf was not available.
+0 :ok: buf 0m 0s buf was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 15m 2s Maven dependency ordering for branch
+1 :green_heart: mvninstall 28m 21s trunk passed
+1 :green_heart: compile 25m 22s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: compile 21m 43s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 4m 28s trunk passed
+1 :green_heart: mvnsite 3m 13s trunk passed
+1 :green_heart: javadoc 2m 41s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 2m 32s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 4m 53s trunk passed
+1 :green_heart: shadedclient 24m 48s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 27s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 44s the patch passed
+1 :green_heart: compile 24m 26s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: cc 24m 26s the patch passed
+1 :green_heart: javac 24m 26s the patch passed
+1 :green_heart: compile 21m 47s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: cc 21m 47s the patch passed
+1 :green_heart: javac 21m 47s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 4m 21s /results-checkstyle-root.txt root: The patch generated 8 new + 167 unchanged - 1 fixed = 175 total (was 168)
+1 :green_heart: mvnsite 3m 10s the patch passed
+1 :green_heart: javadoc 2m 34s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 :green_heart: javadoc 2m 36s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: spotbugs 5m 3s the patch passed
+1 :green_heart: shadedclient 25m 5s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 18m 31s hadoop-common in the patch passed.
+1 :green_heart: unit 34m 20s hadoop-hdfs-rbf in the patch passed.
+1 :green_heart: asflicense 1m 18s The patch does not generate ASF License warnings.
282m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/8/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/4584
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat
uname Linux b03cbe3b64b0 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ccdb70c36dcf87e141490d37682273739e7ae92d
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/8/testReport/
Max. process+thread count 2306 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4584/8/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Aug 12 '22 07:08 hadoop-yetus

@omalley I'm guessing the close was accidental?

goiri avatar Aug 23 '22 18:08 goiri

@goiri No, I committed the change to trunk and branch-3.3. Was there still an open issue on this PR?

omalley avatar Aug 23 '22 19:08 omalley

No worries, you merged manually instead of merging the existing PR. It is fine.

goiri avatar Aug 23 '22 20:08 goiri