guacamole-server icon indicating copy to clipboard operation
guacamole-server copied to clipboard
verified publisher icon apache

GUACAMOLE-1973: Add support for XTerm bracketed-paste mode

Open scottp-dpaw opened this issue 1 year ago • 2 comments

scottp-dpaw avatar Jul 30 '24 04:07 scottp-dpaw

@scottp-dpaw Since this is a new feature, and not a bug fix, this can be based against the main branch of the Apache repo rather than the patch branch. :-)

necouchman avatar Jul 30 '24 13:07 necouchman

No worries. In lieu of making constants for every bitmask, I've added clearer comments describing the sequence of bits that we're trying to find for each codepoint. Hopefully that should provide enough context to the reader about what we're trying to do, if not I'm open to suggestions. Gotta say writing out more comments was a worthwhile exercise; I found two errors with my original logic. Turns out Unicode is hard!

scottp-dpaw avatar Jul 31 '24 03:07 scottp-dpaw