guacamole-client icon indicating copy to clipboard operation
guacamole-client copied to clipboard

GUACAMOLE-1468: Adds SKIP_IF_UNAVAILABLE in options

Open kevinimbrechts opened this issue 3 years ago • 3 comments

Adds properties to guacamole.process wich configure other options (like skip-if-unavailable)

kevinimbrechts avatar Nov 26 '21 15:11 kevinimbrechts

Thanks, @kevinimbrechts. This will need to be associated with a Jira issue and tagged appropriately before we will merge it.

necouchman avatar Nov 26 '21 19:11 necouchman

Hi @necouchman. Yes sorry. Is it ok now ? Thanks.

kevinimbrechts avatar Nov 26 '21 23:11 kevinimbrechts

Hi @mike-jumper. Thank you for the review. I corrected typos and change du function name to associate_general_options. I added a better description.

Personally, I prefer to keep the function. Maybe placing guacd-hostname and guacd-port into associate_general_options is a good idea? Let me know and I will adapt accordingly. Thanks

kevinimbrechts avatar Nov 29 '21 09:11 kevinimbrechts

Closing this, as this option was added by #794.

necouchman avatar Mar 14 '23 17:03 necouchman