guacamole-client icon indicating copy to clipboard operation
guacamole-client copied to clipboard

GUACAMOLE-1056: Add support for tracking the time drift between guacamole and TOTP-tokens

Open ghost opened this issue 4 years ago • 5 comments

We added a new attribute for storing the value of the time drift next to the TOTP-Key. The module will accept 3 codes, one previous, one on time and one in the future. Depending on the accepted code the value will be decremented (previous) or incremented (future) or unchanged (on time). The new value will be used to compensate the timedrift on the next login.

ghost avatar Apr 30 '20 06:04 ghost

You have an extra commit (8239c16), now, that needs to be removed.

necouchman avatar Nov 19 '20 12:11 necouchman

You have an extra commit (8239c16), now, that needs to be removed.

Commit removed, I was created by resolving the conflict. Now it's present again. What have I to do to resolve it?

ghost avatar Nov 19 '20 12:11 ghost

What have I to do to resolve it?

Make sure that your forked copy of the master branch of the repo is up-to-date, and then rebase your TOTPTimeDrift branch on top of master via the command git rebase master. You'll likely run into the conflicts there and you'll need to resolve them.

necouchman avatar Nov 20 '20 19:11 necouchman

I seeams that I did it correct now. @necouchman Thank you for your help.

ghost avatar Nov 23 '20 13:11 ghost

I do not have time drift problems but I would nevertheless love to see this integrated to avoid issues around the time when a code expires and a new one must be used.

amelchio avatar Aug 24 '21 20:08 amelchio