gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard
Published 4 days ago • verified publisher icon apache

[MINOR] feat(core): Support global cache

Open Abyss-lord opened this issue 8 months ago • 1 comments

What changes were proposed in this pull request?

Support global cache

Why are the changes needed?

MINOR

Does this PR introduce any user-facing change?

no

How was this patch tested?

local test.

Abyss-lord avatar Apr 29 '25 08:04 Abyss-lord

Hi @xunliu , I've completed the code updates and would appreciate your review of the PR when you have a moment.

Abyss-lord avatar Apr 30 '25 17:04 Abyss-lord

hi @mchades Please help review this PR, thanks.

xunliu avatar May 14 '25 07:05 xunliu

Hi @yuqi1129 @xunliu , I've completed the code updates and would appreciate your review of the PR when you have a moment. Here's a summary of the commits:

  1. Fix comment issues
  2. Replace this with a static map in CacheUtil
  3. Fix version number to 0.10.0

Abyss-lord avatar May 15 '25 05:05 Abyss-lord

Hi @yuqi1129 @xunliu , I've completed the code updates and would appreciate your review of the PR when you have a moment. Here's a summary of the commits:

  1. Fix comment issues
  2. Replace this with a static map in CacheUtil
  3. Fix version number to 0.10.0

I see and will take a look today, good job.

yuqi1129 avatar May 15 '25 05:05 yuqi1129

Hi @yuqi1129 @xunliu , I've completed the code updates and would appreciate your review of the PR when you have a moment. Here's a summary of the commits:

  1. Fix comment issues
  2. Replace this with a static map in CacheUtil
  3. Fix version number to 0.10.0

I see and will take a look today, good job.

Generally, LGTM, could you split this PR into small ones? The first one can only contain the interface skeleton.

yuqi1129 avatar May 16 '25 01:05 yuqi1129

I think this PR is obsolete, I'm going to close this PR.

jerryshao avatar Jul 02 '25 03:07 jerryshao