apache
[MINOR] Improvement(cli): Refactor the help command.
What changes were proposed in this pull request?
Refactor the help command.
Why are the changes needed?
just a draft
Does this PR introduce any user-facing change?
Better help command.
How was this patch tested?
local test.
I'm currently on holiday, so only had a quick look, I have some minor concerns:
- It doesn't use the existing library's functionality when it could
- It's less flexible when it comes to possible future changes like internationalisation
- It changes existing functionality outside of the help command
- Some of the output requires improvement
I'm currently on holiday, so only had a quick look, I have some minor concerns:
- It doesn't use the existing library's functionality when it could
- It's less flexible when it comes to possible future changes like internationalisation
- It changes existing functionality outside of the help command
- Some of the output requires improvement
Hi @justinmclean , I've completed the code updates and would appreciate your review of the PR when you have a moment. plz also review the #6798 if you have time.
Again, the added code seems to duplicate functionality that exists in the CLI library we use, why not use that? Having the help text in text files is on purpose, as this makes editing them easy.
See for example: https://commons.apache.org/proper/commons-cli/javadocs/api-release/org/apache/commons/cli/HelpFormatter.html