gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard

[Improvement] Muliple repeated strings in Ranger classes

Open justinmclean opened this issue 10 months ago • 4 comments

What would you like to be improved?

In RangerAuthorizationProperties.java, RangerAuthorizationHDFSPlugin.java, RangerAuthorizationHadoopSQLPlugin.java, RangerClientExtension.java several strings are repeated multiple times and could be made static. e.g. "%s is required", "The privilege %s is not supported for the securable object: %s" and "The metadata object must be a PathBasedMetadataObject"

How should we improve?

Refactor, extract and make a static.

justinmclean avatar Feb 26 '25 03:02 justinmclean

I would like to work on it.

Abyss-lord avatar Feb 26 '25 03:02 Abyss-lord

Note I just put in a PR to improve some of the messages, you might want to wait until that is merged.

justinmclean avatar Feb 26 '25 04:02 justinmclean

Note I just put in a PR to improve some of the messages, you might want to wait until that is merged.

@justinmclean hi, Justin is #6531 ?

Abyss-lord avatar Mar 02 '25 08:03 Abyss-lord

Yes it's #6531

justinmclean avatar Mar 02 '25 11:03 justinmclean