gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard
Published 4 days ago • verified publisher icon apache

[#6467] improve(core): Allow JDBC backend configs be configurable

Open TEOTEO520 opened this issue 10 months ago • 6 comments

What changes were proposed in this pull request?

Add 2 user properties: gravitino.entity.store.relational.max.total.connection gravitino.entity.store.relational.max.wait.millis

Why are the changes needed?

To support users to configure JDBC connection pool parameters

Fix: #6467

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need to test

TEOTEO520 avatar Feb 17 '25 14:02 TEOTEO520

@yuqi1129 can you please help to review?

jerryshao avatar Feb 18 '25 02:02 jerryshao

All suggestions have been incorporated. Thank you for your thorough review!

TEOTEO520 avatar Feb 23 '25 20:02 TEOTEO520

lgtm

tengqm avatar Feb 24 '25 00:02 tengqm

@TEOTEO520 Please address the comments and try to determine the reason for the CI 's failure.

yuqi1129 avatar Feb 24 '25 02:02 yuqi1129

lgtm

tengqm avatar Feb 26 '25 22:02 tengqm

I think you should also update the related documents about newly added configurations.

jerryshao avatar Mar 03 '25 09:03 jerryshao

I think you should also update the related documents about newly added configurations.

done

TEOTEO520 avatar Mar 08 '25 15:03 TEOTEO520

@jerqi @jerryshao @tengqm Do you have any further comments on this PR?

yuqi1129 avatar Mar 11 '25 09:03 yuqi1129

You should modify the PR description to align to the latest code.

jerqi avatar Mar 12 '25 02:03 jerqi