gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard
Published 4 days ago • verified publisher icon apache

[#6236] fix(core): fix possible resource leak in BaseCatalog

Open Abyss-lord opened this issue 11 months ago • 3 comments

What changes were proposed in this pull request?

Use try-with-resource to fix possible resource leak in BaseCatalog.

Why are the changes needed?

Fix: #6236

Does this PR introduce any user-facing change?

No.

How was this patch tested?

local test.

Abyss-lord avatar Jan 15 '25 09:01 Abyss-lord

@justinmclean @tengqm ,could you please review this PR when you have time? I’d really appreciate your feedback.

Abyss-lord avatar Jan 15 '25 09:01 Abyss-lord

@xunliu @jerqi can you please help to review?

jerryshao avatar Jan 15 '25 11:01 jerryshao

@jerqi @xunliu can you please review again to see if it is a necessary fix?

jerryshao avatar Jan 22 '25 11:01 jerryshao

@xunliu I’ve finished updating the code. Please take a look at the PR again when you have time.

Abyss-lord avatar Mar 10 '25 01:03 Abyss-lord