gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard

[Improvement] GravitinoClient needs metalake to obtain version

Open justinmclean opened this issue 1 year ago • 4 comments

What would you like to be improved?

Currently the GravitinoClient requires a known metalake name if you want to get the server version number. This is an issue if no metalakes exist.

How should we improve?

You should be able to get the version number without knowing the name of any existing metalakes.

justinmclean avatar Sep 30 '24 03:09 justinmclean

Hello, I would like to give it a try. Can this task be assigned to me

lsyulong avatar Sep 30 '24 06:09 lsyulong

Where should I have made the modifications? Can you provide me with assistance

lsyulong avatar Oct 02 '24 01:10 lsyulong

You want to take a look at GravitinoClient.java / GravitinoClientBase.java and the serverVersion() method. serverVersion() doesn't require a metalake, but the GravitinoClient build method checks that the metalake is not null or empty. The GravitinoClient constructor also calls loadMetalake.

justinmclean avatar Oct 02 '24 05:10 justinmclean

You want to take a look at GravitinoClient.java / GravitinoClientBase.java and the serverVersion() method. serverVersion() doesn't require a metalake, but the GravitinoClient build method checks that the metalake is not null or empty. The GravitinoClient constructor also calls loadMetalake.

Hello, I have made some modifications based on your prompt. Do you have any questions? Feel free to communicate with me anytime

lsyulong avatar Oct 03 '24 03:10 lsyulong

Hey, was that possible that I can work with this task together?

YuanG0319tt avatar Oct 07 '24 03:10 YuanG0319tt

Hi @justinmclean, I'd like to work on this issue. Could you please assign it to me?

waukin avatar Mar 24 '25 06:03 waukin

@justinmclean @jerryshao hello,I think this problem has not been fixed yet, and the related PRs are closed. Can I continue to fix it?

lsyulong avatar Jul 16 '25 09:07 lsyulong

I think @jerryshao is of the opinion that a fix is not needed here. There are other good first issues you can look at - https://github.com/apache/gravitino/contribute

justinmclean avatar Jul 16 '25 09:07 justinmclean