gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard
Published 4 days ago • verified publisher icon apache

[#4903] feat(core,server): Support to grant or revoke privileges for a role

Open jerqi opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

Supports to grant or revoke privileges for a role

Why are the changes needed?

Fix: #4903

Does this PR introduce any user-facing change?

I will add the document later.

How was this patch tested?

Add the UT.

jerqi avatar Sep 25 '24 11:09 jerqi

@lw-yang Could you help me review this pull request?

jerqi avatar Sep 25 '24 12:09 jerqi

@yuqi1129 please help to review this again.

jerryshao avatar Sep 30 '24 02:09 jerryshao

I have no further comments, except for these two.

yuqi1129 avatar Sep 30 '24 06:09 yuqi1129

I split it into two pull requests. https://github.com/apache/gravitino/pull/5053

jerqi avatar Sep 30 '24 06:09 jerqi

Can you please fix the style issue?

jerryshao avatar Oct 08 '24 03:10 jerryshao

Generally LGTM, @yuqi1129 can you please take another look at this PR?

jerryshao avatar Oct 08 '24 15:10 jerryshao

@jerqi the cherry-pick is failed, please do it manually against branch-0.6.

jerryshao avatar Oct 09 '24 03:10 jerryshao