gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard
Published 3 days ago • verified publisher icon apache

feat(oceanbase-catalog): Support schema operations for OceanBase JDBC catalog.

Open yuanoOo opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

  • Support schema operations for OceanBase JDBC catalog.
  • Add OceanBaseContainer to test schema operations.

Why are the changes needed?

Fix: #4990

Does this PR introduce any user-facing change?

no

How was this patch tested?

Add unit test: TestOceanBaseDatabaseOperations.

yuanoOo avatar Sep 25 '24 02:09 yuanoOo

@mchades PTAL.

yuanoOo avatar Sep 25 '24 02:09 yuanoOo

@mchades can you please move forward this PR?

jerryshao avatar Oct 09 '24 03:10 jerryshao

LGTM. Thanks for your contributions and sorry for my later response.

I think the next PR should be support simple table operations for Oceanbase catalog

I think it might be a better choice to implement the org.apache.gravitino.catalog.oceanbase.converter package first. Both schema and table operations depend on it, and we can test it while testing schema and table operations.What do you think?

yuanoOo avatar Oct 12 '24 02:10 yuanoOo

LGTM. Thanks for your contributions and sorry for my later response. I think the next PR should be support simple table operations for Oceanbase catalog

I think it might be a better choice to implement the org.apache.gravitino.catalog.oceanbase.converter package first. Both schema and table operations depend on it, and we can test it while testing schema and table operations.What do you think?

ok, plz go ahead

mchades avatar Oct 12 '24 02:10 mchades