gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard
Published 4 days ago • verified publisher icon apache

[#4370]feat(iceberg): support view interface for Iceberg REST server

Open theoryxu opened this issue 1 year ago • 5 comments

What changes were proposed in this pull request?

support view interface for Iceberg REST server

Why are the changes needed?

Fix: #4370

Does this PR introduce any user-facing change?

no

How was this patch tested?

  1. add UT
  2. manual test

theoryxu avatar Sep 13 '24 09:09 theoryxu

@FANNG1 please help to review, Thanks.

theoryxu avatar Sep 19 '24 08:09 theoryxu

@theoryxu , thanks for the PR, after supporting views, could Spark create the view in the Iceberg REST catalog? If yes, could you add corresponding integration test?

FANNG1 avatar Sep 20 '24 14:09 FANNG1

@theoryxu , thanks for the PR, after supporting views, could Spark create the view in the Iceberg REST catalog? If yes, could you add corresponding integration test?

Sure, I tested it in an internal environment and will add an integration test soon.

theoryxu avatar Sep 26 '24 01:09 theoryxu

@FANNG1 Integration tests have been added. Please review. Thanks!

theoryxu avatar Sep 26 '24 10:09 theoryxu

LGTM except one comment, @theoryxu could you fix the ci error?

FANNG1 avatar Sep 27 '24 13:09 FANNG1

@theoryxu , merged to main, thanks for your contribution.

FANNG1 avatar Oct 08 '24 08:10 FANNG1