gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard
Published 19 hours ago • verified publisher icon apache

[FEATURE] Add github logo, stars number and forks number for UI

Open LauraXia123 opened this issue 1 year ago • 9 comments

Describe the feature

Add github logo, stars number and forks number for UI, click the logo block will link to gravitino github image

  1. We need to get the stars and forks number need from the GitHub RESTful interface
  2. Please notice, when starts and forks number than 1000, We need to show 1.x K

Motivation

No response

Describe the solution

No response

Additional context

No response

LauraXia123 avatar Aug 05 '24 09:08 LauraXia123

Hey @LauraXia123,

I would like to work on this issue. Can you please assign it to me?

jenish-thapa avatar Aug 05 '24 16:08 jenish-thapa

I think people will expect that clicking on the logo will take you to the first page of the application, not the GitHub repo. Unless you mean clicking on a new GitHub logo?

justinmclean avatar Aug 05 '24 23:08 justinmclean

@justinmclean yeah, I mean clicking on the clicking on the new logo in the top right corner.

LauraXia123 avatar Aug 06 '24 02:08 LauraXia123

Thank you for clarifying the requirements. I can take care of adding the GitHub logo, star count, and fork count to the top right corner of the UI, with the logo linking to the Gravitino GitHub page as specified.

jenish-thapa avatar Aug 06 '24 08:08 jenish-thapa

hi @jenish-thapa Thank you for your interesting this issue. I updated issue detail information, Please look it.

  1. We need to get the stars and forks number need from the GitHub RESTful interface
  2. Please notice that when the starts and forks number than 1000, We need to show 1.x K

xunliu avatar Aug 07 '24 01:08 xunliu

hi @jenish-thapa Do you have time for this issue?

LauraXia123 avatar Sep 19 '24 01:09 LauraXia123

hey @jenish-thapa if you are not working on this issue can you assign this to me.

Shravanth007 avatar Sep 23 '24 20:09 Shravanth007

@CodingWithError Hi, thank you for your interesting this issue. You can submit the pr for this issue, we'll assign to you later.

LauraXia123 avatar Sep 29 '24 03:09 LauraXia123

@LauraXia123 i will raise the pr by tomorrow EOD.

Shravanth007 avatar Sep 30 '24 11:09 Shravanth007

@CodingWithError hi, have you raise the pr?

LauraXia123 avatar Oct 12 '24 02:10 LauraXia123

Hey @LauraXia123 I didn't yet raise my pr. I have searched for this page, but couldn't find it can you please help me with it. Thank you.

Shravanth007 avatar Oct 21 '24 17:10 Shravanth007

@CodingWithError you can find it at https://github.com/apache/gravitino/blob/main/web/web/src/app/rootLayout/AppBar.js

LauraXia123 avatar Oct 22 '24 02:10 LauraXia123

Hi @LauraXia123

I would like to work on this issue. Can you assign it to me? Thanks

SZL741023 avatar Nov 01 '24 03:11 SZL741023

hi @SZL741023 Thank you for your interesting this issue. I assign this issue to you.

xunliu avatar Nov 01 '24 03:11 xunliu