apache
[#4277] feat(client/server): Add the `getFileLocation` interface in the Java Client/Server
What changes were proposed in this pull request?
Added an interface for obtaining the file location so that the client can report some necessary information for the server to audit and simplify some check logics in GVFS later.
Why are the changes needed?
Fix: #4277
How was this patch tested?
Add some UTs and ITs.
@jerryshao @yuqi1129 @mchades Could you help me review this PR when you have time? Thanks a lot.
@xloya is it ready for review?
Yeah, the code have been changed according to the discussion.
Hi @xloya This PR is a little big. I would suggest to split into several small PRs. For this PR, I think we can focus on the definition and skeleton code, what do you think?
Hi @xloya This PR is a little big. I would suggest to split into several small PRs. For this PR, I think we can focus on the definition and skeleton code, what do you think?
OK, I will take some time to split the current PR.
@jerryshao I have split the code, this PR only contains some code skeleton in the Server / Java Client, and some base classes. I will add the interface implementations, UTs and ITs in another PR.
Hi @xloya In this PR, let's only focus on the API and common part, several implementations in core and server can be separated into a different PR.
Overall LGTM, can you please do as I mentioned?
Sure, I will finish it today.
@jerryshao Hi, since some classes in Core / Catalog modules involved in this PR currently implement the FilesetCatalog interface, I can only use throw new UnsupportedOperationException("Not implemented") to handle method implementation. Others have been removed as required and will be added in subsequent implementations. Please take a look at it when you have time, thanks.