gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard

Published 20 hours ago • verified publisher icon apache

[#2434] Improvement: if DropXXX success, return true, if not exists return false

Open charliecheng630 opened this issue 9 months ago • 8 comments

What changes were proposed in this pull request?

When dropping the XXX(Metalake/Catalog/Schema/Table/Fileset/Partition/Topic), if the XXX does not exist, then return false.

Why are the changes needed?

a clear drop behavior of return value and exception thrown.

Fix: #2434

Does this PR introduce any user-facing change?

No

How was this patch tested?

ITs and UTs

charliecheng630 avatar Apr 29 '24 13:04 charliecheng630

@mchades would you please help to review this?

jerryshao avatar May 06 '24 04:05 jerryshao

Are the changes in core module the same as #3100 ?

mchades avatar May 06 '24 07:05 mchades

Are the changes in core module the same as #3100 ?

Yes.

charliecheng630 avatar May 07 '24 01:05 charliecheng630

Update. Please help to review again when you have time~

charliecheng630 avatar May 07 '24 01:05 charliecheng630

Updated. Please help to review again when you have time, thanks!

charliecheng630 avatar May 09 '24 01:05 charliecheng630

@mchades Updated. Please help to review again when you have time, thanks!

charliecheng630 avatar May 09 '24 13:05 charliecheng630

@charliecheng630 would you please rebase the code?

jerryshao avatar May 10 '24 05:05 jerryshao

@charliecheng630 can you please also confirm that if anything should be changed in the client side?

jerryshao avatar May 10 '24 06:05 jerryshao

@mchades Rebased & updated. Please help to review again when you have time, thanks!

charliecheng630 avatar May 21 '24 15:05 charliecheng630