gora icon indicating copy to clipboard operation
gora copied to clipboard

GORA-276: Refactor and organize o.a.g.mapreduce package naming

Open nbrendah opened this issue 4 years ago • 6 comments

Issue Link: https://issues.apache.org/jira/browse/GORA-276

Migrated classes in package org.apache.gora.mapreduce to org.apache.gora.io.serializer

cc @djkevincr

nbrendah avatar Oct 27 '21 01:10 nbrendah

My PR is failing. @lewismc, what is the cause of

Going to parse results form **/*-reports/TEST-*.xml
Result: 1352 tests run, 29 skipped, 0 failed.
Posting status 'completed' with conclusion 'success' to https://github.com/apache/gora/pull/251 (sha: 07293dc17249838fb781c01ca624318f4b29917e)
Error: Resource not accessible by integration

Screenshot from 2021-10-29 00-49-19

nbrendah avatar Oct 28 '21 21:10 nbrendah

Yeah I saw that and I tried to fix it. @djkevincr do you know when the Github Actions build started failing? I did see https://github.com/actions/first-interaction/issues/10#issuecomment-910605074

lewismc avatar Oct 28 '21 23:10 lewismc

Yeah I saw that and I tried to fix it.

@lewismc I saw your current commit https://github.com/apache/gora/commit/44ecabb241201c37f94ade36806b2070eca0144c . It was passing build, though failing with sonar scanners. However, most of these builds pass locally.

nbrendah avatar Oct 28 '21 23:10 nbrendah

This is a real blast from the past @nbrendah This patch introduces a major API break... so we need to think about how clients will address that.

lewismc avatar Nov 04 '21 04:11 lewismc

Sorry @lewismc for taking long without replying to this. I was finishing my outreachy application

This patch introduces a major API break... so we need to think about how clients will address that.

@lewismc @djkevincr Should we create documentation to show this change or I close this because negative results outweigh the positive?

nbrendah avatar Nov 08 '21 23:11 nbrendah

I had to send an empty commit to re-run the build. I guess it passes and we continue with our discussion

nbrendah avatar Nov 09 '21 01:11 nbrendah