gobblin
gobblin copied to clipboard
[GOBBLIN-1674] : Add an option in gobblin.sh to specify whether to run the Gobblin job in background or not
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
Description
- [ ] Here are some details about my PR, including screenshots (if applicable): Currently, the command uses 'nohup' and '&' which always makes it run in background. This makes it inconvenient in use-cases that need to do some action after the run is completed (like curling for some logs). Hence, providing an option to choose whether to run in background or not.
Tests
- [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason: Tested in local environment with the new flag, unit tests Not applicable.
Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
+1 It looks good to me.
Codecov Report
Merging #3534 (a1b3d3f) into master (9ce1e65) will decrease coverage by
0.00%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #3534 +/- ##
============================================
- Coverage 46.69% 46.68% -0.01%
- Complexity 10432 10436 +4
============================================
Files 2083 2083
Lines 81516 81516
Branches 9100 9100
============================================
- Hits 38061 38056 -5
- Misses 39944 39946 +2
- Partials 3511 3514 +3
| Impacted Files | Coverage Δ | |
|---|---|---|
| .../modules/scheduler/GobblinServiceJobScheduler.java | 65.38% <0.00%> (-6.25%) |
:arrow_down: |
| ...a/org/apache/gobblin/cluster/GobblinHelixTask.java | 60.21% <0.00%> (-2.16%) |
:arrow_down: |
| .../apache/gobblin/runtime/api/JobExecutionState.java | 79.43% <0.00%> (-0.94%) |
:arrow_down: |
| ...lin/util/filesystem/FileSystemInstrumentation.java | 92.85% <0.00%> (ø) |
|
| ...main/java/org/apache/gobblin/util/HadoopUtils.java | 29.87% <0.00%> (+0.32%) |
:arrow_up: |
| ...in/java/org/apache/gobblin/cluster/HelixUtils.java | 35.97% <0.00%> (+4.26%) |
:arrow_up: |
| ...he/gobblin/source/PartitionAwareFileRetriever.java | 55.55% <0.00%> (+7.40%) |
:arrow_up: |
| ...a/org/apache/gobblin/util/limiter/NoopLimiter.java | 60.00% <0.00%> (+20.00%) |
:arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
@bharos Could you rebase from master? It conflicts with the previous changes that you've made