gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

GOBBLIN-867 use logger from class instead of passing it around

Open IvanGavlik opened this issue 4 years ago • 1 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-867] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-867

Description

  • [x] Here are some details about my PR, including screenshots (if applicable): Static methods now have their own logger. It is not passed as param.

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: No need for testing because this is very simple change in parmas of the method. Project build is good check for this PR.

Commits

  • [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

IvanGavlik avatar Dec 20 '20 20:12 IvanGavlik

Codecov Report

Merging #3183 (52cfa16) into master (38765e7) will decrease coverage by 4.23%. The diff coverage is 26.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3183      +/-   ##
============================================
- Coverage     46.20%   41.96%   -4.24%     
+ Complexity     9759     8904     -855     
============================================
  Files          2014     2014              
  Lines         77099    77098       -1     
  Branches       8559     8555       -4     
============================================
- Hits          35625    32356    -3269     
- Misses        38170    41697    +3527     
+ Partials       3304     3045     -259     
Impacted Files Coverage Δ Complexity Δ
...blin/cluster/ScheduledJobConfigurationManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...blin/cluster/StreamingJobConfigurationManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ache/gobblin/compaction/mapreduce/MRCompactor.java 7.04% <0.00%> (ø) 9.00 <0.00> (ø)
...lin/compaction/mapreduce/MRCompactorJobRunner.java 0.00% <0.00%> (-17.08%) 0.00 <0.00> (-2.00)
...in/compaction/verify/DataCompletenessVerifier.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nstrumented/writer/InstrumentedDataWriterBase.java 46.15% <0.00%> (ø) 14.00 <0.00> (ø)
.../org/apache/gobblin/writer/AsyncWriterManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/gobblin/publisher/HiveRegistrationPublisher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...apache/gobblin/writer/http/AbstractHttpWriter.java 0.00% <0.00%> (-56.07%) 0.00 <0.00> (-12.00)
...blin/data/management/retention/DatasetCleaner.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38765e7...52cfa16. Read the comment docs.

codecov-io avatar Dec 24 '20 13:12 codecov-io