gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[WIP] Adding some protection logic to check jar file's existance before copying in CompactionSource

Open autumnust opened this issue 5 years ago • 1 comments

WIP

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

  • [ ] Here are some details about my PR, including screenshots (if applicable):

Tests

  • [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

autumnust avatar Nov 06 '20 06:11 autumnust

Codecov Report

Merging #3149 into master will decrease coverage by 4.26%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3149      +/-   ##
============================================
- Coverage     46.05%   41.78%   -4.27%     
+ Complexity     9603     8761     -842     
============================================
  Files          1989     1989              
  Lines         75896    75900       +4     
  Branches       8452     8452              
============================================
- Hits          34953    31715    -3238     
- Misses        37662    41163    +3501     
+ Partials       3281     3022     -259     
Impacted Files Coverage Δ Complexity Δ
...he/gobblin/compaction/source/CompactionSource.java 0.00% <0.00%> (-72.09%) 0.00 <0.00> (-14.00)
.../org/apache/gobblin/util/filters/HiddenFilter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...g/apache/gobblin/cluster/HelixMessageSubTypes.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...gobblin/runtime/mapreduce/GobblinOutputFormat.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
.../gobblin/compaction/suite/CompactionSuiteBase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-10.00%)
...obblin/compaction/source/CompactionFailedTask.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...n/cluster/event/ClusterManagerShutdownRequest.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...blin/compaction/mapreduce/RecordKeyMapperBase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...in/compaction/action/CompactionCompleteAction.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...n/compaction/mapreduce/orc/OrcKeyDedupReducer.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-10.00%)
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fc978c...940bd5c. Read the comment docs.

codecov-io avatar Nov 06 '20 07:11 codecov-io