gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-1139] Aerospike writer

Open jhsenjaliya opened this issue 5 years ago • 2 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [x] My PR addresses the following [Gobblin JIRA]
    • https://issues.apache.org/jira/browse/GOBBLIN-1139

Description

  • [x] Here are some details about my PR, including screenshots (if applicable):
  • aerospike writer with basic functionality

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
  • Aerospike does not provide any mock server to interact with, we will have to figure this out on how to do the test framework for aerospike

Commits

  • [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

jhsenjaliya avatar May 04 '20 02:05 jhsenjaliya

Codecov Report

Merging #2978 into master will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2978      +/-   ##
============================================
+ Coverage     45.60%   45.62%   +0.01%     
- Complexity     9204     9205       +1     
============================================
  Files          1943     1943              
  Lines         73732    73732              
  Branches       8138     8138              
============================================
+ Hits          33625    33637      +12     
+ Misses        36975    36962      -13     
- Partials       3132     3133       +1     
Impacted Files Coverage Δ Complexity Δ
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 67.91% <0.00%> (+0.37%) 33.00% <0.00%> (ø%)
...main/java/org/apache/gobblin/yarn/YarnService.java 16.21% <0.00%> (+0.81%) 5.00% <0.00%> (+1.00%)
...lin/restli/throttling/ZookeeperLeaderElection.java 72.22% <0.00%> (+2.22%) 13.00% <0.00%> (ø%)
...e/gobblin/runtime/app/ServiceBasedAppLauncher.java 49.51% <0.00%> (+5.82%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3624a4f...95ce09f. Read the comment docs.

codecov-io avatar May 04 '20 04:05 codecov-io

@sv2000, pls review.

jhsenjaliya avatar May 18 '20 19:05 jhsenjaliya