gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-984] Add log4j2.xml to enable log4j2 functionality

Open jhsenjaliya opened this issue 6 years ago • 4 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-984

Description

  • [x] Here are some details about my PR, including screenshots (if applicable):

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: script and log config changes

Commits

  • [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

jhsenjaliya avatar Nov 26 '19 21:11 jhsenjaliya

@Will-Lo , pls review. pls also take a look at this, its also related to config changes: https://github.com/apache/incubator-gobblin/pull/2788 Thanks

jhsenjaliya avatar Nov 26 '19 21:11 jhsenjaliya

Codecov Report

Merging #2830 into master will increase coverage by <.01%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2830      +/-   ##
============================================
+ Coverage     45.62%   45.63%   +<.01%     
- Complexity     8971     8976       +5     
============================================
  Files          1902     1902              
  Lines         71284    71284              
  Branches       7862     7862              
============================================
+ Hits          32523    32529       +6     
+ Misses        35771    35764       -7     
- Partials       2990     2991       +1
Impacted Files Coverage Δ Complexity Δ
...lin/restli/throttling/ZookeeperLeaderElection.java 70% <0%> (-2.23%) 13% <0%> (ø)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 63.88% <0%> (-1.39%) 29% <0%> (-1%)
...main/java/org/apache/gobblin/util/HadoopUtils.java 30.87% <0%> (+0.67%) 25% <0%> (+1%) :arrow_up:
...main/java/org/apache/gobblin/yarn/YarnService.java 15.68% <0%> (+0.84%) 4% <0%> (+1%) :arrow_up:
...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java 64.44% <0%> (+1.11%) 16% <0%> (+1%) :arrow_up:
...in/java/org/apache/gobblin/cluster/HelixUtils.java 35.51% <0%> (+2.8%) 12% <0%> (+1%) :arrow_up:
...lin/util/filesystem/FileSystemInstrumentation.java 92.85% <0%> (+7.14%) 4% <0%> (+1%) :arrow_up:
...a/org/apache/gobblin/util/limiter/NoopLimiter.java 60% <0%> (+20%) 3% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1da1e40...7a90589. Read the comment docs.

codecov-io avatar Nov 26 '19 22:11 codecov-io

So far LGTM, going to test it out first after #2788 is good to go

Will-Lo avatar Nov 27 '19 18:11 Will-Lo

This needs #2685 back in to support the base log4j2 functionality.

jhsenjaliya avatar Jul 12 '20 17:07 jhsenjaliya