gobblin
gobblin copied to clipboard
[Gobblin-982] Fix JDBC extraction dependencies issue
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-982] Dependencies missing for running JDBC extraction job"
- https://issues.apache.org/jira/browse/GOBBLIN-982
Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Add "gobblin-sql" module into distribution dependencies so that it could be packaged into built tarball, otherwise while running JDBC extraction job, it will pop up ClassNotFound exception for all "gobblin-sql" classes.
Add jdbc related libraries into mr libs as jdbc extraction codes are actually running on mappers and need these dependencies (same as above got ClassNotFound exception otherwise).
Tests
- [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: Gradle config and shell scripts modification.
Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
@PnPie Thanks for fixing this, I had to fix the same, this looks good but can u pls take a look at the jenkins failure? If it looks intermittent, pls just push this again to trigger the CI. Thanks
Hi Jay @jhsenjaliya ! CI is in maintenance and I merged master in to trigger it again.
looks like the build is getting stalled, I also see many elasticsearch exceptions, not sure if that is causing any test failure though.
Yes seems the elasticsearch exceptions are on the internal ES test server, and at the moment will not impact the build, I can successfully build the ES module locally, so I just pushed some logging info changes to trigger it again.
Codecov Report
Merging #2828 into master will increase coverage by
0.95%. The diff coverage is0.00%.
@@ Coverage Diff @@
## master #2828 +/- ##
============================================
+ Coverage 44.60% 45.55% +0.95%
- Complexity 8980 9149 +169
============================================
Files 1936 1936
Lines 73234 73234
Branches 8083 8083
============================================
+ Hits 32669 33365 +696
+ Misses 37515 36773 -742
- Partials 3050 3096 +46
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a634612...ab44e56. Read the comment docs.